Fixed static test failures

engcom-Echo · engcom-Echo · commit f59e628dd0c1 · 2024-07-09T08:03:19.000+05:30
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Data.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Data.php
@@ -16,8 +16,6 @@
 class Data extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
 {
     /**
-     * Currency factory
-     *
      * @var \Magento\Directory\Model\CurrencyFactory
      */
     protected $_currencyFactory;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php
@@ -35,15 +35,11 @@
 class Account extends AbstractForm
 {
     /**
-     * Metadata form factory
-     *
      * @var MetadataFormFactory
      */
     protected $_metadataFormFactory;
 
     /**
-     * Customer repository
-     *
      * @var CustomerRepositoryInterface
      */
     protected $customerRepository;
@@ -98,8 +94,6 @@ public function __construct(
     }
 
     /**
-     * Group Management
-     *
      * @var GroupManagementInterface
      */
     private $groupManagement;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Giftmessage.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Giftmessage.php
@@ -16,15 +16,11 @@
 class Giftmessage extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
 {
     /**
-     * Gift message save
-     *
      * @var \Magento\GiftMessage\Model\Save
      */
     protected $_giftMessageSave;
 
     /**
-     * Message helper
-     *
      * @var \Magento\GiftMessage\Helper\Message
      */
     protected $_messageHelper;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Load.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Load.php
@@ -19,8 +19,6 @@ class Load extends \Magento\Framework\View\Element\Template
     protected $_jsHelper = null;
 
     /**
-     * Json encoder
-     *
      * @var \Magento\Framework\Json\EncoderInterface
      */
     protected $_jsonEncoder;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Newsletter.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Newsletter.php
@@ -45,7 +45,8 @@ public function getHeaderCssClass()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * phpcs:disable
      */
     protected function _toHtml()
     {
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Search/Grid.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Search/Grid.php
@@ -18,29 +18,21 @@
 class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
 {
     /**
-     * Sales config
-     *
      * @var \Magento\Sales\Model\Config
      */
     protected $_salesConfig;
 
     /**
-     * Session quote
-     *
      * @var \Magento\Backend\Model\Session\Quote
      */
     protected $_sessionQuote;
 
     /**
-     * Catalog config
-     *
      * @var \Magento\Catalog\Model\Config
      */
     protected $_catalogConfig;
 
     /**
-     * Product factory
-     *
      * @var \Magento\Catalog\Model\ProductFactory
      */
     protected $_productFactory;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Search/Grid/Renderer/Qty.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Search/Grid/Renderer/Qty.php
@@ -11,8 +11,6 @@
 class Qty extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Input
 {
     /**
-     * Type config
-     *
      * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface
      */
     protected $typeConfig;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Method/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Method/Form.php
@@ -23,8 +23,6 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
     protected $_rates;
 
     /**
-     * Tax data
-     *
      * @var \Magento\Tax\Helper\Data
      */
     protected $_taxData = null;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar.php
@@ -21,6 +21,7 @@ class Sidebar extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
     protected function _prepareLayout()
     {
         if ($this->getCustomerId()) {
+            // phpstan:ignore "Undefined variable"
             $button = $this->getLayout()->createBlock(
                 \Magento\Backend\Block\Widget\Button::class
             )->setData(
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php
@@ -26,8 +26,6 @@ class AbstractSidebar extends \Magento\Sales\Block\Adminhtml\Order\Create\Abstra
     protected $_sidebarStorageAction = 'add';
 
     /**
-     * Sales config
-     *
      * @var \Magento\Sales\Model\Config
      */
     protected $_salesConfig;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Pcompared.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Pcompared.php
@@ -16,15 +16,11 @@
 class Pcompared extends \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\AbstractSidebar
 {
     /**
-     * Product factory
-     *
      * @var \Magento\Catalog\Model\ProductFactory
      */
     protected $_productFactory;
 
     /**
-     * Event
-     *
      * @var \Magento\Reports\Model\ResourceModel\Event
      */
     protected $_event;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Pviewed.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Pviewed.php
@@ -16,15 +16,11 @@
 class Pviewed extends \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\AbstractSidebar
 {
     /**
-     * Product factory
-     *
      * @var \Magento\Catalog\Model\ProductFactory
      */
     protected $_productFactory;
 
     /**
-     * Event factory
-     *
      * @var \Magento\Reports\Model\EventFactory
      */
     protected $_eventFactory;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Reorder.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/Reorder.php
@@ -23,8 +23,6 @@ class Reorder extends \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Abstra
     protected $_sidebarStorageAction = 'add_order_item';
 
     /**
-     * Orders factory
-     *
      * @var \Magento\Sales\Model\ResourceModel\Order\CollectionFactory
      */
     protected $_ordersFactory;
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php
@@ -16,29 +16,21 @@
 class Totals extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
 {
     /**
-     * Total renderers
-     *
      * @var array
      */
     protected $_totalRenderers;
 
     /**
-     * Default renderer
-     *
      * @var string
      */
     protected $_defaultRenderer = \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals::class;
 
     /**
-     * Sales data
-     *
      * @var \Magento\Sales\Helper\Data
      */
     protected $_salesData = null;
 
     /**
-     * Sales config
-     *
      * @var \Magento\Sales\Model\Config
      */
     protected $_salesConfig;
@@ -164,6 +156,7 @@ public function renderTotal($total, $area = null, $colspan = 1)
     /**
      * Render totals
      *
+     * phpcs:disable
      * @param null $area
      * @param int $colspan
      * @return string
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/DefaultTotals.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/DefaultTotals.php
@@ -13,8 +13,6 @@
 class DefaultTotals extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals
 {
     /**
-     * Template
-     *
      * @var string
      */
     protected $_template = 'Magento_Sales::order/create/totals/default.phtml';

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@`
`16`	`16`	`class Data extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate`
`17`	`17`	`{`
`18`	`18`	`/**`
`19`		`- * Currency factory`
`20`		`- *`
`21`	`19`	`* @var \Magento\Directory\Model\CurrencyFactory`
`22`	`20`	`*/`
`23`	`21`	`protected $_currencyFactory;`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,8 @@ public function getHeaderCssClass()`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`/**`
`48`		`- * {@inheritdoc}`
	`48`	`+ * @inheritdoc`
	`49`	`+ * phpcs:disable`
`49`	`50`	`*/`
`50`	`51`	`protected function _toHtml()`
`51`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@`
`11`	`11`	`class Qty extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Input`
`12`	`12`	`{`
`13`	`13`	`/**`
`14`		`- * Type config`
`15`		`- *`
`16`	`14`	`* @var \Magento\Catalog\Model\ProductTypes\ConfigInterface`
`17`	`15`	`*/`
`18`	`16`	`protected $typeConfig;`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ class Sidebar extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate`
`21`	`21`	`protected function _prepareLayout()`
`22`	`22`	`{`
`23`	`23`	`if ($this->getCustomerId()) {`
	`24`	`+ // phpstan:ignore "Undefined variable"`
`24`	`25`	`$button = $this->getLayout()->createBlock(`
`25`	`26`	`\Magento\Backend\Block\Widget\Button::class`
`26`	`27`	`)->setData(`