MAGETWO-33502: Inline JS code elimination (Priority 1 scripts)

- Fix maximum line length error
- Remove unnecessary functions

Author: Denys Rul

app/code/Magento/Ui/view/base/templates/form/default.phtml

@@ -6,11 +6,12 @@
 /**
  * @var \Magento\Ui\Component\Form $block
  */
+$formConfig = $block->getRenderContext()->getConfigBuilder()->toJsonNew($block->getRenderContext()->getStorage());
 ?>
 <script type="text/x-magento-init">
     {
         "*": {
-            "Magento_Ui/js/core/app": <?php echo $block->getRenderContext()->getConfigBuilder()->toJsonNew($block->getRenderContext()->getStorage()); ?>
+            "Magento_Ui/js/core/app": <?php echo $formConfig; ?>
         }
     }
 </script>

lib/web/mage/apply/main.js

@@ -33,19 +33,6 @@ define([
         });
     }
 
-    /**
-     * Searches for elements with a 'data-mage-init' attribute.
-     *
-     * @returns {Array} An array of elements with 'data-mage-init' attribute.
-     */
-    function getElems() {
-        var elems;
-
-        elems = document.querySelectorAll(nodeSelector);
-
-        return _.toArray(elems);
-    }
-
     /**
      * Parses elements 'data-mage-init' attribute as a valid JSON data.
      * Note: data-mage-init attribute will be removed.
@@ -72,11 +59,12 @@ define([
          *      data-mage-init='{"path/to/component": {"foo": "bar"}}'
          */
         apply: function () {
-            var virtual = processScripts();
+            var virtuals = processScripts(),
+                nodes = document.querySelectorAll(nodeSelector);
 
-            getElems()
+            _.toArray(nodes)
                 .map(getData)
-                .concat(virtual)
+                .concat(virtuals)
                 .forEach(function (item) {
                     _.each(item.data, init.bind(null, item.el));
                 });

lib/web/mage/apply/scripts.js

@@ -10,15 +10,15 @@ define([
 
     var scriptSelector = 'script[type="text/x-magento-init"]',
         dataAttr = 'data-mage-init',
-        virtual = [];
+        virtuals = [];
 
     /**
      * Adds components to the virtula list.
      *
      * @param {Object} components
      */
     function addVirtual(components) {
-        virtual.push({
+        virtuals.push({
             el: false,
             data: components
         });
@@ -63,19 +63,6 @@ define([
         _.toArray(elems).forEach(iterator);
     }
 
-    /**
-     * Searches for script tags whith a 'text/x-magento-init' type.
-     *
-     * @returns {Array} An array of elements script nodes.
-     */
-    function getNodes() {
-        var elems;
-
-        elems = document.querySelectorAll(scriptSelector);
-
-        return _.toArray(elems);
-    }
-
     /**
      * Parses content of a provided script node.
      * Note: node will be removed from DOM.
@@ -115,12 +102,14 @@ define([
      *      }
      */
     return function () {
-        getNodes()
+        var nodes = document.querySelectorAll(scriptSelector);
+
+        _.toArray(nodes)
             .map(getNodeData)
             .forEach(function (item) {
                 _.each(item, processElems);
             });
 
-        return virtual.splice(0, virtual.length);
+        return virtuals.splice(0, virtuals.length);
     };
 });