MAGETWO-66696: Expand the Dependency static test to validate reports.xml dependencies

Author: fascinosum

dev/tests/static/framework/Magento/TestFramework/Dependency/ReportsConfigRule.php

@@ -0,0 +1,56 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\TestFramework\Dependency;
+
+/**
+ * Class provides dependency rule for reports.xml config file.
+ */
+class ReportsConfigRule implements RuleInterface
+{
+    /**
+     * Map of tables and modules
+     *
+     * @var array
+     */
+    private $moduleTableMap;
+
+    /**
+     * @param array $tables
+     */
+    public function __construct(array $tables)
+    {
+        $this->moduleTableMap = $tables;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getDependencyInfo($currentModule, $fileType, $file, &$contents)
+    {
+        if ('config' != $fileType || !preg_match('#.*/reports\.xml$#', $file)) {
+            return [];
+        }
+
+        $dependenciesInfo = [];
+        if (preg_match_all('#<source[^>]*name=[\'"]([^\'"]+)[\'"]#i', $contents, $matches)) {
+            $tables = array_pop($matches);
+            foreach ($tables as $table) {
+                if (!isset($this->moduleTableMap[$table])) {
+                    continue;
+                }
+                if (strtolower($currentModule) !== strtolower($this->moduleTableMap[$table])) {
+                    $dependenciesInfo[] = [
+                        'module' => $this->moduleTableMap[$table],
+                        'type' => RuleInterface::TYPE_HARD,
+                        'source' => $table,
+                    ];
+                }
+            }
+        }
+
+        return $dependenciesInfo;
+    }
+}

dev/tests/static/testsuite/Magento/Test/Integrity/DependencyTest.php

@@ -14,6 +14,7 @@
 use Magento\TestFramework\Dependency\DiRule;
 use Magento\TestFramework\Dependency\LayoutRule;
 use Magento\TestFramework\Dependency\PhpRule;
+use Magento\TestFramework\Dependency\ReportsConfigRule;
 use Magento\TestFramework\Dependency\VirtualType\VirtualTypeMapper;
 
 /**
@@ -222,7 +223,8 @@ protected static function _initRules()
                 self::$_mapLayoutBlocks,
                 self::$_mapLayoutHandles
             ),
-            new DiRule(new VirtualTypeMapper())
+            new DiRule(new VirtualTypeMapper()),
+            new ReportsConfigRule($dbRuleTables),
         ];
     }