MC-42249: No form validation for negative quantity on bundle products

- Fixed CR comments

Author: devarul

app/code/Magento/Bundle/ViewModel/ValidateQuantity.php

@@ -7,31 +7,41 @@
 
 namespace Magento\Bundle\ViewModel;
 
-use Magento\CatalogInventory\Model\StockRegistry;
+use Magento\Framework\Serialize\Serializer\Json;
 use Magento\Framework\View\Element\Block\ArgumentInterface;
 use Magento\Catalog\Block\Product\View as ProductView;
 
 /**
  * ViewModel for Bundle Option Block
  */
-
 class ValidateQuantity implements ArgumentInterface
 {
+    /**
+     * @var Json
+     */
+    private Json $serializer;
+
     /**
      * @var ProductView
      */
-    private $productView;
+    private ProductView $productView;
 
     /**
+     * @param Json $serializer
      * @param ProductView $productView
      */
-    public function __construct(ProductView $productView)
-    {
+    public function __construct(
+        Json $serializer,
+        ProductView $productView
+    ) {
+        $this->serializer = $serializer;
         $this->productView = $productView;
     }
 
-    public function getQuantityValidators(): array
+    public function getQuantityValidators(): string
     {
-        return $this->productView->getQuantityValidators();
+        return $this->serializer->serialize(
+            $this->productView->getQuantityValidators()
+        );
     }
 }

app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/radio.phtml

@@ -76,7 +76,7 @@ $viewModel = $block->getData('validateQuantityViewModel');
                            class="input-text qty<?php if (!$_canChangeQty) { echo ' qty-disabled'; } ?>"
                            type="number"
                            min="0"
-                           data-validate="<?= $block->escapeHtml(json_encode($viewModel->getQuantityValidators())) ?>"
+                           data-validate="<?= $block->escapeHtmlAttr($viewModel->getQuantityValidators()) ?>"
                            name="bundle_option_qty[<?= $block->escapeHtmlAttr($_option->getId()) ?>]"
                            data-selector="bundle_option_qty[<?= $block->escapeHtmlAttr($_option->getId()) ?>]"
                            value="<?= $block->escapeHtmlAttr($_defaultQty) ?>"/>

app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/select.phtml

@@ -62,7 +62,7 @@ $viewModel = $block->getData('validateQuantityViewModel');
                            class="input-text qty<?php if (!$_canChangeQty) { echo ' qty-disabled'; } ?>"
                            type="number"
                            min="0"
-                           data-validate="<?= $block->escapeHtml(json_encode($viewModel->getQuantityValidators())) ?>"
+                           data-validate="<?= $block->escapeHtmlAttr($viewModel->getQuantityValidators()) ?>"
                            name="bundle_option_qty[<?= $block->escapeHtmlAttr($_option->getId()) ?>]"
                            data-selector="bundle_option_qty[<?= $block->escapeHtmlAttr($_option->getId()) ?>]"
                            value="<?= $block->escapeHtmlAttr($_defaultQty) ?>"/>