Skip to content

Commit f50cb72

Browse files
committed
MAGETWO-89168: Develop UI component
1 parent bb43ca6 commit f50cb72

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/url-input.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ define([
3737
}
3838
},
3939
listens: {
40-
value: 'renderComponent',
4140
checked: 'updateSettingValue',
4241
disabled: 'hideLinkedElement'
4342
},
@@ -154,22 +153,24 @@ define([
154153
*
155154
* @return void
156155
*/
157-
renderComponent: function (value) {
156+
setDifferedFromDefault: function (value) {
157+
this._super();
158+
158159
if (!_.isUndefined(value) && value) {
159-
this.setChildUrlInputComponent(value);
160+
this.createChildUrlInputComponent(value);
160161
//to store current element
161162
this.linkedElement = this.linkedElementInstances[value];
162163
this.linkType(value);
163164
}
164165
},
165166

166167
/**
167-
* Set child component by value
168+
* Create child component by value
168169
*
169170
* @param {String} value
170171
* @return void
171172
*/
172-
setChildUrlInputComponent: function (value) {
173+
createChildUrlInputComponent: function (value) {
173174
var elementConfig;
174175

175176
if (_.isUndefined(this.linkedElementInstances[value])) {

app/code/Magento/Ui/view/base/web/templates/form/element/url-input.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@
2121
<!--display field to insert link value based on link type-->
2222
<div ko-scope="getLinkedElementName()" class="url-input-element-linked-element">
2323
<render/>
24-
<label class="admin__field-error" if="error" attr="for: uid" text="error"/>
24+
<label class="admin__field-error" visible="error" attr="for: uid" text="error"/>
2525
</div>
2626
</div>
2727

2828
<!--display container to specify url options(Example: open in new tab)-->
29-
<render if="isDisplayAdditionalSettings" args="settingTemplate"/>
30-
<div/>
29+
<div render="settingTemplate" if="isDisplayAdditionalSettings"/>
3130
</div>
3231
</div>

0 commit comments

Comments
 (0)