Skip to content

Commit f5004d3

Browse files
committed
MC-23989: Mini cart missing when you edit inline welcome message for guest and use special characters
1 parent 668dd3d commit f5004d3

File tree

1 file changed

+3
-2
lines changed
  • app/code/Magento/Theme/view/frontend/templates/html

1 file changed

+3
-2
lines changed

app/code/Magento/Theme/view/frontend/templates/html/header.phtml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,20 @@
66

77
/**
88
* @var \Magento\Theme\Block\Html\Header $block
9+
* @var \Magento\Framework\Escaper $escaper
910
*/
1011
$welcomeMessage = $block->getWelcome();
1112
?>
1213
<?php if ($block->getShowPart() == 'welcome') : ?>
1314
<li class="greet welcome" data-bind="scope: 'customer'">
1415
<!-- ko if: customer().fullname -->
1516
<span class="logged-in"
16-
data-bind="text: new String('<?= $block->escapeHtml(__('Welcome, %1!', '%1')) ?>').replace('%1', customer().fullname)">
17+
data-bind="text: new String('<?= $escaper->escapeHtml(__('Welcome, %1!', '%1')) ?>').replace('%1', customer().fullname)">
1718
</span>
1819
<!-- /ko -->
1920
<!-- ko ifnot: customer().fullname -->
2021
<span class="not-logged-in"
21-
data-bind="html: '<?= $block->escapeHtml($welcomeMessage) ?>'"></span>
22+
data-bind="html: "<?= $escaper->escapeHtml($welcomeMessage) ?>"></span>
2223
<?= $block->getBlockHtml('header.additional') ?>
2324
<!-- /ko -->
2425
</li>

0 commit comments

Comments
 (0)