MAGETWO-51929: Web Setup Wizard does not work when Magento is installed in pub

- Do not show setup wizard when document root is pub

Author: mazhalai

app/code/Magento/Backend/Model/Setup/MenuBuilder.php

@@ -0,0 +1,48 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Backend\Model\Setup;
+
+use Magento\Backend\Model\Menu;
+use Magento\Backend\Model\Menu\Builder;
+use Magento\Framework\App\DocRoot;
+
+/**
+ * Plugin class to remove web setup wizard from menu if application root is pub/ and no setup url variable is specified.
+ */
+class MenuBuilder
+{
+
+    /**
+     * @var DocRoot
+     */
+    protected $docRoot;
+
+    /**
+     * MenuBuilder constructor.
+     *
+     * @param DocRoot $docRoot
+     */
+    public function __construct(DocRoot $docRoot)
+    {
+        $this->docRoot = $docRoot;
+    }
+
+    /**
+     * Removes 'Web Setup Wizard' from the menu if doc root is pub and no setup url variable is specified.
+     *
+     * @param Builder $subject
+     * @param Menu $menu
+     * @return Menu
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function afterGetResult(Builder $subject, Menu $menu)
+    {
+        if ($this->docRoot->hasThisSubDir('pub', 'setup')) {
+            $menu->remove('Magento_Backend::setup_wizard');
+        }
+        return $menu;
+    }
+}

app/code/Magento/Backend/etc/di.xml

@@ -214,4 +214,7 @@
             </argument>
         </arguments>
     </type>
+    <type name="Magento\Backend\Model\Menu\Builder">
+        <plugin name="SetupMenuBuilder" type="Magento\Backend\Model\Setup\MenuBuilder" />
+    </type>
 </config>

lib/internal/Magento/Framework/App/DocRoot.php

@@ -0,0 +1,47 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Framework\App;
+
+use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Filesystem\Directory\ReadFactory;
+
+/**
+ * This class calculates if document root is set to pub
+ */
+class DocRoot
+{
+    /**
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @var ReadFactory
+     */
+    private $readFactory;
+
+    /**
+     * @param RequestInterface $request
+     * @param ReadFactory $readFactory
+     */
+    public function __construct(RequestInterface $request, ReadFactory $readFactory) {
+        $this->request = $request;
+        $this->readFactory = $readFactory;
+    }
+
+    /**
+     * Returns true if doc root is pub/ and not BP
+     *
+     * @return string
+     */
+    public function hasThisSubDir($dirToCheck, $missingDir)
+    {
+        $rootBasePath = $this->request->getServer('DOCUMENT_ROOT');
+        $readDirectory = $this->readFactory->create(DirectoryList::ROOT);
+        return strpos($rootBasePath, $dirToCheck) && !$readDirectory->isExist($rootBasePath + $missingDir);
+    }
+}