Skip to content

Commit f47d5e1

Browse files
author
Dale Sikkema
committed
Merge branch 'MAGETWO-32624' into develop
Conflicts: app/code/Magento/Tax/Controller/Adminhtml/Tax/IgnoreTaxNotification.php
2 parents 12ce0a1 + a162233 commit f47d5e1

File tree

9 files changed

+11
-7
lines changed

9 files changed

+11
-7
lines changed

app/code/Magento/Config/Model/Config/ScopeDefiner.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ public function getScope()
3939
'store'
4040
) ? StoreScopeInterface::SCOPE_STORE : ($this->_request->getParam(
4141
'website'
42-
) ? StoreScopeInterface::SCOPE_WEBSITE : StoreScopeInterface::SCOPE_DEFAULT);
42+
) ? StoreScopeInterface::SCOPE_WEBSITE : ScopeConfigInterface::SCOPE_TYPE_DEFAULT);
4343
}
4444
}

app/code/Magento/Email/Model/BackendTemplate.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* See COPYING.txt for license details.
55
*/
66
namespace Magento\Email\Model;
7+
78
use Magento\Framework\App\Config\ScopeConfigInterface;
89

910
/**

app/code/Magento/Sales/Test/Unit/Model/Config/Backend/Email/AsyncSendingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected function setUp()
6363
public function testAfterSave($value, $oldValue, $eventName)
6464
{
6565
$path = 'sales_email/general/async_sending';
66-
$scope = \Magento\Framework\App\ScopeInterface::SCOPE_DEFAULT;
66+
$scope = \Magento\Framework\App\Config\ScopeConfigInterface::SCOPE_TYPE_DEFAULT;
6767

6868
$this->object->setData(['value' => $value, 'path' => $path, 'scope' => $scope]);
6969

app/code/Magento/Sales/Test/Unit/Model/Config/Backend/Grid/AsyncIndexingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected function setUp()
6363
public function testAfterSave($value, $oldValue, $eventName)
6464
{
6565
$path = 'dev/grid/async_indexing';
66-
$scope = \Magento\Framework\App\ScopeInterface::SCOPE_DEFAULT;
66+
$scope = \Magento\Framework\App\Config\ScopeConfigInterface::SCOPE_TYPE_DEFAULT;
6767

6868
$this->object->setData(['value' => $value, 'path' => $path, 'scope' => $scope]);
6969

app/code/Magento/Store/Model/Config/Reader/DefaultReader.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
namespace Magento\Store\Model\Config\Reader;
99

1010
use Magento\Framework\App\Config\ScopeConfigInterface;
11+
use Magento\Framework\Exception\LocalizedException;
1112

1213
class DefaultReader implements \Magento\Framework\App\Config\Scope\ReaderInterface
1314
{
@@ -45,14 +46,14 @@ public function __construct(
4546
* Read configuration data
4647
*
4748
* @param null|string $scope
48-
* @throws \Magento\Framework\Exception Exception is thrown when scope other than default is given
49+
* @throws LocalizedException Exception is thrown when scope other than default is given
4950
* @return array
5051
*/
5152
public function read($scope = null)
5253
{
5354
$scope = $scope === null ? ScopeConfigInterface::SCOPE_TYPE_DEFAULT : $scope;
5455
if ($scope !== ScopeConfigInterface::SCOPE_TYPE_DEFAULT) {
55-
throw new \Magento\Framework\Exception("Only default scope allowed");
56+
throw new \Magento\Framework\Exception\LocalizedException(__("Only default scope allowed"));
5657
}
5758

5859
$config = $this->_initialConfig->getData($scope);

app/code/Magento/Tax/Controller/Adminhtml/Tax/IgnoreTaxNotification.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
*/
77
namespace Magento\Tax\Controller\Adminhtml\Tax;
88

9-
use Magento\Framework\Controller\ResultFactory;
109
use Magento\Framework\App\Config\ScopeConfigInterface;
10+
use Magento\Framework\Controller\ResultFactory;
11+
1112

1213
class IgnoreTaxNotification extends \Magento\Tax\Controller\Adminhtml\Tax
1314
{

app/code/Magento/Theme/Model/View/Design.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
namespace Magento\Theme\Model\View;
8+
89
use Magento\Framework\App\Config\ScopeConfigInterface;
910

1011
/**

dev/tests/integration/testsuite/Magento/Payment/Model/ObserverTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* See COPYING.txt for license details.
55
*/
66
namespace Magento\Payment\Model;
7+
78
use Magento\Framework\App\Config\ScopeConfigInterface;
89

910
/**

lib/internal/Magento/Framework/App/Config/Value.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66
namespace Magento\Framework\App\Config;
7-
use Magento\Framework\App\Config\ScopeConfigInterface;
87

98
/**
109
* Config data model

0 commit comments

Comments
 (0)