Skip to content

Commit f439b52

Browse files
Indrani SonawaneIndrani Sonawane
authored andcommitted
Merge remote-tracking branch '38439/bugfix/data-collection-typehint' into community_prs_march
2 parents 963c22c + cb496b3 commit f439b52

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/AbstractCollectionStub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class AbstractCollectionStub extends AbstractCollection
1616
* Retrieve item by id
1717
*
1818
* @param mixed $id
19-
* @return DataObject
19+
* @return DataObject|null
2020
*/
2121
public function getItemById($id)
2222
{

app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/VersionControl/AbstractCollectionStub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class AbstractCollectionStub extends AbstractCollection
1919
* Retrieve item by id
2020
*
2121
* @param mixed $id
22-
* @return DataObject
22+
* @return DataObject|null
2323
*/
2424
public function getItemById($id)
2525
{

lib/internal/Magento/Framework/Data/Collection.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class Collection implements
7777
/**
7878
* Pager page size
7979
*
80-
* if page size is false, then we works with all items
80+
* if page size is false, then we work with all items
8181
*
8282
* @var int|false
8383
*/
@@ -161,8 +161,8 @@ public function addFilter($field, $value, $type = 'and')
161161
* - ["finset" => $valueInSet]
162162
* </pre>
163163
*
164-
* If non matched - sequential parallel arrays are expected and OR conditions
165-
* will be built using above mentioned structure.
164+
* If non-matched - sequential parallel arrays are expected and OR conditions
165+
* will be built using above-mentioned structure.
166166
*
167167
* Example:
168168
* <pre>
@@ -825,7 +825,7 @@ protected function _toOptionHash($valueField = 'id', $labelField = 'name')
825825
* Retrieve item by id
826826
*
827827
* @param string|int $idValue
828-
* @return DataObject
828+
* @return DataObject|null
829829
*/
830830
public function getItemById($idValue)
831831
{

0 commit comments

Comments
 (0)