Skip to content

Commit f3c190f

Browse files
VasylKozyrenkoVasylKozyrenko
committed
MTA-3236: Order Management: Extend existing functional automated tests
2 parents c5aec01 + 2f35c1c commit f3c190f

File tree

2 files changed

+48
-27
lines changed

2 files changed

+48
-27
lines changed

‎dev/tests/functional/tests/app/Magento/Sales/Test/TestCase/CreateCreditMemoEntityTest.php

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
use Magento\Mtf\Fixture\FixtureFactory;
1111
use Magento\Mtf\Fixture\FixtureInterface;
1212
use Magento\Mtf\TestCase\Injectable;
13+
use Magento\Mtf\TestStep\TestStepFactory;
1314

1415
/**
1516
* Preconditions:
16-
* 1. Enable payment method "Check/Money Order".
17+
* 1. Enable payment method one of "Check/Money Order/Bank Transfer/Cash on Delivery/Purchase Order".
1718
* 2. Enable shipping method one of "Flat Rate/Free Shipping".
1819
* 3. Create order.
1920
* 4. Create Invoice.
@@ -54,38 +55,34 @@ class CreateCreditMemoEntityTest extends Injectable
5455
'price',
5556
];
5657

57-
/**
58-
* Set up configuration.
59-
*
60-
* @param FixtureFactory $fixtureFactory
61-
* @return void
62-
*/
63-
public function __prepare(FixtureFactory $fixtureFactory)
64-
{
65-
$this->fixtureFactory = $fixtureFactory;
66-
67-
$setupConfigurationStep = $this->objectManager->create(
68-
\Magento\Config\Test\TestStep\SetupConfigurationStep::class,
69-
['configData' => 'checkmo, flatrate']
70-
);
71-
$setupConfigurationStep->run();
72-
}
73-
7458
/**
7559
* Create credit memo.
7660
*
61+
* @param TestStepFactory $stepFactory
62+
* @param FixtureFactory $fixtureFactory
7763
* @param OrderInjectable $order
7864
* @param array $data
65+
* @param string $configData
7966
* @return array
8067
*/
81-
public function test(OrderInjectable $order, array $data)
82-
{
68+
public function test(
69+
TestStepFactory $stepFactory,
70+
FixtureFactory $fixtureFactory,
71+
OrderInjectable $order,
72+
array $data,
73+
$configData
74+
) {
8375
// Preconditions
76+
$this->fixtureFactory = $fixtureFactory;
77+
$stepFactory->create(
78+
\Magento\Config\Test\TestStep\SetupConfigurationStep::class,
79+
['configData' => $configData]
80+
)->run();
8481
$order->persist();
85-
$this->objectManager->create(\Magento\Sales\Test\TestStep\CreateInvoiceStep::class, ['order' => $order])->run();
82+
$stepFactory->create(\Magento\Sales\Test\TestStep\CreateInvoiceStep::class, ['order' => $order])->run();
8683

8784
// Steps
88-
$createCreditMemoStep = $this->objectManager->create(
85+
$createCreditMemoStep = $stepFactory->create(
8986
\Magento\Sales\Test\TestStep\CreateCreditMemoStep::class,
9087
['order' => $order, 'data' => $data]
9188
);

‎dev/tests/functional/tests/app/Magento/Sales/Test/TestCase/CreateCreditMemoEntityTest.xml

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
99
<testCase name="Magento\Sales\Test\TestCase\CreateCreditMemoEntityTest" summary="Create Credit Memo for Offline Payment Methods" ticketId="MAGETWO-29116">
10-
<variation name="CreateCreditMemoEntityTestVariation1">
11-
<data name="description" xsi:type="string">Assert items return to stock (partial refund)</data>
10+
<variation name="CreateCreditMemoEntityTestVariation1" summary="Assert items return to stock (partial refund)">
1211
<data name="data/items_data/0/back_to_stock" xsi:type="string">Yes</data>
1312
<data name="data/items_data/0/qty" xsi:type="string">1</data>
1413
<data name="data/form_data/send_email" xsi:type="string">Yes</data>
1514
<data name="order/dataset" xsi:type="string">default</data>
1615
<data name="order/data/entity_id/products" xsi:type="string">catalogProductSimple::product_100_dollar</data>
1716
<data name="order/data/price/dataset" xsi:type="string">partial_refund</data>
17+
<data name="configData" xsi:type="string">checkmo</data>
1818
<constraint name="Magento\Sales\Test\Constraint\AssertRefundSuccessCreateMessage" />
1919
<constraint name="Magento\Sales\Test\Constraint\AssertCreditMemoButton" />
2020
<constraint name="Magento\Sales\Test\Constraint\AssertRefundInCreditMemoTab" />
@@ -25,21 +25,45 @@
2525
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
2626
<constraint name="Magento\Sales\Test\Constraint\AssertCreditMemoItems" />
2727
</variation>
28-
<variation name="CreateCreditMemoEntityTestVariation2">
29-
<data name="description" xsi:type="string">Assert 0 shipping refund</data>
28+
<variation name="CreateCreditMemoEntityTestVariation2" summary="Assert 0 shipping refund">
3029
<data name="data/items_data/0/qty" xsi:type="string">1</data>
3130
<data name="data/form_data/shipping_amount" xsi:type="string">0</data>
3231
<data name="data/form_data/adjustment_positive" xsi:type="string">5</data>
3332
<data name="data/form_data/adjustment_negative" xsi:type="string">10</data>
3433
<data name="order/dataset" xsi:type="string">default</data>
35-
<data name="order/data/entity_id/products" xsi:type="string">catalogProductSimple::default</data>
34+
<data name="order/data/payment_auth_expiration/method" xsi:type="string">banktransfer</data>
3635
<data name="order/data/price/dataset" xsi:type="string">full_refund_with_zero_shipping_refund</data>
36+
<data name="configData" xsi:type="string">banktransfer</data>
3737
<constraint name="Magento\Sales\Test\Constraint\AssertRefundSuccessCreateMessage" />
3838
<constraint name="Magento\Sales\Test\Constraint\AssertCreditMemoButton" />
3939
<constraint name="Magento\Sales\Test\Constraint\AssertRefundInCreditMemoTab" />
4040
<constraint name="Magento\Sales\Test\Constraint\AssertRefundInRefundsGrid" />
4141
<constraint name="Magento\Sales\Test\Constraint\AssertRefundedGrandTotalOnFrontend" />
4242
<constraint name="Magento\Sales\Test\Constraint\AssertCreditMemoItems" />
4343
</variation>
44+
<variation name="CreateCreditMemoEntityTestVariationWithCashOnDeliveryPaymentMethod" summary="Assert 0 shipping refund with Cash on delivery payment method">
45+
<data name="data/items_data/0/qty" xsi:type="string">1</data>
46+
<data name="data/form_data/shipping_amount" xsi:type="string">0</data>
47+
<data name="data/form_data/adjustment_positive" xsi:type="string">5</data>
48+
<data name="data/form_data/adjustment_negative" xsi:type="string">10</data>
49+
<data name="order/dataset" xsi:type="string">default</data>
50+
<data name="order/data/payment_auth_expiration/method" xsi:type="string">cashondelivery</data>
51+
<data name="order/data/price/dataset" xsi:type="string">full_refund_with_zero_shipping_refund</data>
52+
<data name="configData" xsi:type="string">cashondelivery</data>
53+
<constraint name="Magento\Sales\Test\Constraint\AssertRefundSuccessCreateMessage" />
54+
<constraint name="Magento\Sales\Test\Constraint\AssertRefundedGrandTotalOnFrontend" />
55+
</variation>
56+
<variation name="CreateCreditMemoEntityTestVariationWithPurchaseOrderPaymentMethod" summary="Assert 0 shipping refund with Purchase Order payment method">
57+
<data name="data/items_data/0/qty" xsi:type="string">1</data>
58+
<data name="data/form_data/shipping_amount" xsi:type="string">0</data>
59+
<data name="data/form_data/adjustment_positive" xsi:type="string">5</data>
60+
<data name="data/form_data/adjustment_negative" xsi:type="string">10</data>
61+
<data name="order/dataset" xsi:type="string">default</data>
62+
<data name="order/data/payment_auth_expiration/method" xsi:type="string">purchaseorder</data>
63+
<data name="order/data/price/dataset" xsi:type="string">full_refund_with_zero_shipping_refund</data>
64+
<data name="configData" xsi:type="string">purchaseorder</data>
65+
<constraint name="Magento\Sales\Test\Constraint\AssertRefundSuccessCreateMessage" />
66+
<constraint name="Magento\Sales\Test\Constraint\AssertRefundedGrandTotalOnFrontend" />
67+
</variation>
4468
</testCase>
4569
</config>

0 commit comments

Comments
 (0)