AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit f3a4302ad3d0 · 2025-01-31T20:49:19.000+05:30
To fix rounding error in PHP 8.4
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -152,6 +152,10 @@ protected function getStore($scope = null)
      */
     public function round($price)
     {
+        // To fix rounding error in PHP 8.4
+        if (str_contains(PHP_VERSION, '8.4')) {
+            return round(round((float) $price, 3), 2);
+        }
         return round((string) $price, 2);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,10 @@ protected function getStore($scope = null)`
`152`	`152`	`*/`
`153`	`153`	`public function round($price)`
`154`	`154`	`{`
	`155`	`+ // To fix rounding error in PHP 8.4`
	`156`	`+ if (str_contains(PHP_VERSION, '8.4')) {`
	`157`	`+ return round(round((float) $price, 3), 2);`
	`158`	`+ }`
`155`	`159`	`return round((string) $price, 2);`
`156`	`160`	`}`
`157`	`161`