MAGETWO-50770: Impossible upload image for product via API

Author: igrybkov

lib/internal/Magento/Framework/Api/ImageProcessor.php

@@ -9,7 +9,6 @@
 use Magento\Framework\Api\Data\ImageContentInterface;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Exception\InputException;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Filesystem;
 use Magento\Framework\Phrase;
 
@@ -186,7 +185,7 @@ private function getFileName($imageContent)
         $fileName = $imageContent->getName();
         if (!pathinfo($fileName, PATHINFO_EXTENSION)) {
             if (!$imageContent->getType() || !$this->getMimeTypeExtension($imageContent->getType())) {
-                throw new LocalizedException(__('Cannot recognize image extension'));
+                throw new InputException(new Phrase('Cannot recognize image extension.'));
             }
             $fileName .= '.' . $this->getMimeTypeExtension($imageContent->getType());
         }

lib/internal/Magento/Framework/Api/Test/Unit/Api/ImageProcessorTest.php

@@ -162,6 +162,9 @@ public function testSaveWithNoPreviousData()
         $imageContent->expects($this->any())
             ->method('getName')
             ->willReturn('testFileName');
+        $imageContent->expects($this->any())
+            ->method('getType')
+            ->willReturn('image/jpg');
 
         $imageDataObject = $this->getMockBuilder('Magento\Framework\Api\AttributeValue')
             ->disableOriginalConstructor()
@@ -200,7 +203,7 @@ public function testSaveWithPreviousData()
             ->willReturn('testImageData');
         $imageContent->expects($this->any())
             ->method('getName')
-            ->willReturn('testFileName');
+            ->willReturn('testFileName.png');
 
         $imageDataObject = $this->getMockBuilder('Magento\Framework\Api\AttributeValue')
             ->disableOriginalConstructor()
@@ -238,4 +241,43 @@ public function testSaveWithPreviousData()
 
         $this->assertEquals($imageData, $this->imageProcessor->save($imageData, 'testEntityType', $prevImageData));
     }
+
+    /**
+     * @expectedException \Magento\Framework\Exception\InputException
+     * @expectedExceptionMessage Cannot recognize image extension.
+     */
+    public function testSaveWithoutFileExtension()
+    {
+        $imageContent = $this->getMockBuilder('Magento\Framework\Api\Data\ImageContentInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $imageContent->expects($this->once())
+            ->method('getBase64EncodedData')
+            ->willReturn('testImageData');
+        $imageContent->expects($this->once())
+            ->method('getName')
+            ->willReturn('testFileName');
+
+        $imageDataObject = $this->getMockBuilder('Magento\Framework\Api\AttributeValue')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $imageDataObject->expects($this->once())
+            ->method('getValue')
+            ->willReturn($imageContent);
+
+        $imageData = $this->getMockForAbstractClass('Magento\Framework\Api\CustomAttributesDataInterface');
+        $imageData->expects($this->once())
+            ->method('getCustomAttributes')
+            ->willReturn([]);
+
+        $this->dataObjectHelperMock->expects($this->once())
+            ->method('getCustomAttributeValueByType')
+            ->willReturn([$imageDataObject]);
+
+        $this->contentValidatorMock->expects($this->once())
+            ->method('isValid')
+            ->willReturn(true);
+
+        $this->assertEquals($imageData, $this->imageProcessor->save($imageData, 'testEntityType'));
+    }
 }