Skip to content

Commit f2fcc31

Browse files
committed
unit test update
1 parent d18887c commit f2fcc31

File tree

1 file changed

+35
-16
lines changed

1 file changed

+35
-16
lines changed

app/code/Magento/Developer/Test/Unit/Model/TemplateEngine/Plugin/DebugHintsTest.php

Lines changed: 35 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,12 @@ protected function setUp()
6060
* @return void
6161
* @dataProvider afterCreateActiveDataProvider
6262
*/
63-
public function testAfterCreateActive($debugHintsPath, $showBlockHints)
64-
{
63+
public function testAfterCreateActive(
64+
$debugHintsPath,
65+
$showBlockHints,
66+
$debugHintsShowWithParameter,
67+
$debugHintsParameter
68+
) {
6569
$this->devHelperMock->expects($this->once())
6670
->method('isDevAllowed')
6771
->willReturn(true);
@@ -88,12 +92,17 @@ public function testAfterCreateActive($debugHintsPath, $showBlockHints)
8892
->disableOriginalConstructor()
8993
->getMock();
9094

95+
$this->httpMock = $this->createMock(\Magento\Framework\App\Request\Http::class);
96+
9197
$debugHints = new DebugHints(
9298
$this->scopeConfigMock,
9399
$this->storeManager,
94100
$this->devHelperMock,
95101
$this->debugHintsFactory,
96-
$debugHintsPath
102+
$debugHintsPath,
103+
$this->httpMock,
104+
$debugHintsShowWithParameter,
105+
$debugHintsParameter
97106
);
98107

99108
$this->assertEquals($debugHintsDecorator, $debugHints->afterCreate($subjectMock, $engine));
@@ -105,10 +114,10 @@ public function testAfterCreateActive($debugHintsPath, $showBlockHints)
105114
public function afterCreateActiveDataProvider()
106115
{
107116
return [
108-
['dev/debug/template_hints_storefront', false],
109-
['dev/debug/template_hints_storefront', true],
110-
['dev/debug/template_hints_admin', false],
111-
['dev/debug/template_hints_admin', true],
117+
['dev/debug/template_hints_storefront', false, false, null],
118+
['dev/debug/template_hints_storefront', true, false, null],
119+
['dev/debug/template_hints_admin', false, false, null],
120+
['dev/debug/template_hints_admin', true, false, null],
112121
];
113122
}
114123

@@ -119,8 +128,13 @@ public function afterCreateActiveDataProvider()
119128
* @return void
120129
* @dataProvider afterCreateInactiveDataProvider
121130
*/
122-
public function testAfterCreateInactive($debugHintsPath, $isDevAllowed, $showTemplateHints)
123-
{
131+
public function testAfterCreateInactive(
132+
$debugHintsPath,
133+
$isDevAllowed,
134+
$showTemplateHints,
135+
$debugHintsShowWithParameter,
136+
$debugHintsParameter
137+
) {
124138
$this->devHelperMock->expects($this->any())
125139
->method('isDevAllowed')
126140
->willReturn($isDevAllowed);
@@ -133,12 +147,17 @@ public function testAfterCreateInactive($debugHintsPath, $isDevAllowed, $showTem
133147
->disableOriginalConstructor()
134148
->getMock();
135149

150+
$this->httpMock = $this->createMock(\Magento\Framework\App\Request\Http::class);
151+
136152
$debugHints = new DebugHints(
137153
$this->scopeConfigMock,
138154
$this->storeManager,
139155
$this->devHelperMock,
140156
$this->debugHintsFactory,
141-
$debugHintsPath
157+
$debugHintsPath,
158+
$this->httpMock,
159+
$debugHintsShowWithParameter,
160+
$debugHintsParameter
142161
);
143162

144163
$this->assertSame($engine, $debugHints->afterCreate($subjectMock, $engine));
@@ -150,12 +169,12 @@ public function testAfterCreateInactive($debugHintsPath, $isDevAllowed, $showTem
150169
public function afterCreateInactiveDataProvider()
151170
{
152171
return [
153-
['dev/debug/template_hints_storefront', false, false],
154-
['dev/debug/template_hints_storefront', false, true],
155-
['dev/debug/template_hints_storefront', true, false],
156-
['dev/debug/template_hints_admin', false, false],
157-
['dev/debug/template_hints_admin', false, true],
158-
['dev/debug/template_hints_admin', true, false],
172+
['dev/debug/template_hints_storefront', false, false, false, null],
173+
['dev/debug/template_hints_storefront', false, true, false, null],
174+
['dev/debug/template_hints_storefront', true, false, false, null],
175+
['dev/debug/template_hints_admin', false, false, false, null],
176+
['dev/debug/template_hints_admin', false, true, false, null],
177+
['dev/debug/template_hints_admin', true, false, false, null],
159178
];
160179
}
161180

0 commit comments

Comments
 (0)