Skip to content

Commit f2cc29c

Browse files
author
Robert He
committed
Merge branch 'FearlessKiwis-MAGETWO-44075-Incorrect-Price-With-Option' of https://github.corp.magento.com/magento-fearless-kiwis/magento2ce into develop
2 parents fb8db89 + 98f2c43 commit f2cc29c

File tree

7 files changed

+111
-59
lines changed

7 files changed

+111
-59
lines changed

‎app/code/Magento/Tax/Model/Calculation/AbstractAggregateCalculator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ protected function calculateWithTaxInPrice(QuoteDetailsItemInterface $item, $qua
2828
$priceInclTax = $this->calculationTool->round($item->getUnitPrice());
2929
$rowTotalInclTax = $priceInclTax * $quantity;
3030
if (!$this->isSameRateAsStore($rate, $storeRate)) {
31-
$priceInclTax = $this->calculatePriceInclTax($priceInclTax, $storeRate, $rate);
31+
$priceInclTax = $this->calculatePriceInclTax($priceInclTax, $storeRate, $rate, $round);
3232
$rowTotalInclTax = $priceInclTax * $quantity;
3333
}
3434
$rowTaxExact = $this->calculationTool->calcTaxAmount($rowTotalInclTax, $rate, true, false);

‎app/code/Magento/Tax/Model/Calculation/AbstractCalculator.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,14 +433,18 @@ protected function deltaRound($price, $rate, $direction, $type = self::KEY_REGUL
433433
* @param float $storePriceInclTax
434434
* @param float $storeRate
435435
* @param float $customerRate
436+
* @param boolean $round
436437
* @return float
437438
*/
438-
protected function calculatePriceInclTax($storePriceInclTax, $storeRate, $customerRate)
439+
protected function calculatePriceInclTax($storePriceInclTax, $storeRate, $customerRate, $round = true)
439440
{
440441
$storeTax = $this->calculationTool->calcTaxAmount($storePriceInclTax, $storeRate, true, false);
441442
$priceExclTax = $storePriceInclTax - $storeTax;
442443
$customerTax = $this->calculationTool->calcTaxAmount($priceExclTax, $customerRate, false, false);
443-
$customerPriceInclTax = $this->calculationTool->round($priceExclTax + $customerTax);
444+
$customerPriceInclTax = $priceExclTax + $customerTax;
445+
if ($round) {
446+
$customerPriceInclTax = $this->calculationTool->round($customerPriceInclTax);
447+
}
444448
return $customerPriceInclTax;
445449
}
446450
}

‎app/code/Magento/Tax/Model/Calculation/UnitBaseCalculator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ protected function calculateWithTaxInPrice(QuoteDetailsItemInterface $item, $qua
4545
$applyTaxAfterDiscount = $this->config->applyTaxAfterDiscount($this->storeId);
4646
$priceInclTax = $this->calculationTool->round($item->getUnitPrice());
4747
if (!$this->isSameRateAsStore($rate, $storeRate)) {
48-
$priceInclTax = $this->calculatePriceInclTax($priceInclTax, $storeRate, $rate);
48+
$priceInclTax = $this->calculatePriceInclTax($priceInclTax, $storeRate, $rate, $round);
4949
}
5050
$uniTax = $this->calculationTool->calcTaxAmount($priceInclTax, $rate, true, false);
5151
$deltaRoundingType = self::KEY_REGULAR_DELTA_ROUNDING;

‎app/code/Magento/Tax/Test/Unit/Model/Calculation/RowBaseAndTotalBaseCalculatorTestCase.php

Lines changed: 55 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ class RowBaseAndTotalBaseCalculatorTestCase extends \PHPUnit_Framework_TestCase
2020
const RATE = 10;
2121
const STORE_RATE = 11;
2222

23+
const UNIT_PRICE_INCL_TAX = 495.49549549545;
24+
const UNIT_PRICE_INCL_TAX_ROUNDED = 495.5;
25+
2326
const CODE = 'CODE';
2427
const TYPE = 'TYPE';
2528

@@ -71,7 +74,7 @@ public function initMocks($isTaxIncluded)
7174
{
7275
$this->initMockItem($isTaxIncluded);
7376
$this->initMockConfig();
74-
$this->initMockCalculationTool();
77+
$this->initMockCalculationTool($isTaxIncluded);
7578
$this->initMockAppliedTaxDataObjectFactory();
7679
}
7780

@@ -93,7 +96,7 @@ public function setUp()
9396
$this->mockCalculationTool = $this->getMockBuilder('\Magento\Tax\Model\Calculation')
9497
->disableOriginalConstructor()
9598
->setMethods(
96-
['__wakeup', 'round', 'getRate', 'getStoreRate', 'getRateRequest', 'getAppliedRates', 'calcTaxAmount']
99+
['__wakeup', 'round', 'getRate', 'getStoreRate', 'getRateRequest', 'getAppliedRates']
97100
)
98101
->getMock();
99102
$this->mockConfig = $this->getMockBuilder('\Magento\Tax\Model\Config')
@@ -129,11 +132,12 @@ public function setUp()
129132

130133
/**
131134
* @param $calculator RowBaseCalculator|TotalBaseCalculator
135+
* @param boolean $round
132136
* @return \Magento\Tax\Api\Data\TaxDetailsItemInterface
133137
*/
134-
public function calculate($calculator)
138+
public function calculate($calculator, $round = true)
135139
{
136-
return $calculator->calculate($this->mockItem, 1);
140+
return $calculator->calculate($this->mockItem, 1, $round);
137141
}
138142

139143
/**
@@ -147,7 +151,7 @@ protected function initMockItem($isTaxIncluded)
147151
$this->mockItem,
148152
[
149153
[
150-
self::ONCE => true,
154+
self::ONCE => false,
151155
self::MOCK_METHOD_NAME => 'getDiscountAmount',
152156
self::MOCK_VALUE => 1,
153157
],
@@ -157,17 +161,17 @@ protected function initMockItem($isTaxIncluded)
157161
self::MOCK_VALUE => self::CODE
158162
],
159163
[
160-
self::ONCE => true,
164+
self::ONCE => false,
161165
self::MOCK_METHOD_NAME => 'getType',
162166
self::MOCK_VALUE => self::TYPE
163167
],
164168
[
165-
self::ONCE => true,
169+
self::ONCE => false,
166170
self::MOCK_METHOD_NAME => 'getUnitPrice',
167171
self::MOCK_VALUE => self::UNIT_PRICE
168172
],
169173
[
170-
self::ONCE => true,
174+
self::ONCE => false,
171175
self::MOCK_METHOD_NAME => 'getIsTaxIncluded',
172176
self::MOCK_VALUE => $isTaxIncluded
173177
]
@@ -185,7 +189,7 @@ protected function initMockConfig()
185189
$this->mockConfig,
186190
[
187191
[
188-
self::ONCE => true,
192+
self::ONCE => false,
189193
self::MOCK_METHOD_NAME => 'applyTaxAfterDiscount',
190194
self::MOCK_VALUE => true,
191195
]
@@ -196,47 +200,55 @@ protected function initMockConfig()
196200
/**
197201
* init mock calculation model
198202
*
203+
* @param boolean $isTaxIncluded
199204
*/
200205

201-
protected function initMockCalculationTool()
206+
protected function initMockCalculationTool($isTaxIncluded)
202207
{
203-
$this->mockReturnValues(
204-
$this->mockCalculationTool,
208+
$mockValues = [
205209
[
206-
[
207-
self::ONCE => false,
208-
self::MOCK_METHOD_NAME => 'calcTaxAmount',
209-
self::MOCK_VALUE => 1.5,
210-
],
211-
[
212-
self::ONCE => true,
213-
self::MOCK_METHOD_NAME => 'getRate',
214-
self::MOCK_VALUE => self::RATE
215-
],
216-
[
217-
self::ONCE => true,
218-
self::MOCK_METHOD_NAME => 'getAppliedRates',
219-
self::MOCK_VALUE => [
220-
[
221-
'id' => 0,
222-
'percent' => 1.4,
223-
'rates' => [
224-
[
225-
'code' => 'sku_1',
226-
'title' => 'title1',
227-
'percent' => 1.1,
228-
],
210+
self::ONCE => false,
211+
self::MOCK_METHOD_NAME => 'getRate',
212+
self::MOCK_VALUE => self::RATE
213+
],
214+
[
215+
self::ONCE => false,
216+
self::MOCK_METHOD_NAME => 'getAppliedRates',
217+
self::MOCK_VALUE => [
218+
[
219+
'id' => 0,
220+
'percent' => 1.4,
221+
'rates' => [
222+
[
223+
'code' => 'sku_1',
224+
'title' => 'title1',
225+
'percent' => 1.1,
229226
],
230227
],
231-
]
232-
],
233-
[
234-
self::ONCE => false,
235-
self::MOCK_METHOD_NAME => 'round',
236-
self::MOCK_VALUE => 1.3
228+
],
237229
]
238-
]
230+
],
231+
];
232+
233+
if ($isTaxIncluded) {
234+
$mockValues[] = [
235+
self::ONCE => false,
236+
self::MOCK_METHOD_NAME => 'getStoreRate',
237+
self::MOCK_VALUE => self::STORE_RATE
238+
];
239+
}
240+
241+
$this->mockReturnValues(
242+
$this->mockCalculationTool,
243+
$mockValues
239244
);
245+
$this->mockCalculationTool->expects($this->atLeastOnce())
246+
->method('round')
247+
->willReturnCallback(
248+
function ($price) {
249+
return round($price, 2);
250+
}
251+
);
240252
}
241253

242254
/**
@@ -249,7 +261,7 @@ protected function initMockAppliedTaxDataObjectFactory()
249261
$this->appliedTaxDataObjectFactory,
250262
[
251263
[
252-
self::ONCE => true,
264+
self::ONCE => false,
253265
self::MOCK_METHOD_NAME => 'create',
254266
self::MOCK_VALUE => $this->mockAppliedTax,
255267
]

‎app/code/Magento/Tax/Test/Unit/Model/Calculation/RowBaseCalculatorTest.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,15 @@ public function testCalculateWithTaxInPrice()
2626

2727
$this->assertSame(
2828
$this->taxDetailsItem,
29-
$this->calculate($this->rowBaseCalculator)
29+
$this->calculate($this->rowBaseCalculator, true)
30+
);
31+
$this->assertEquals(self::UNIT_PRICE_INCL_TAX_ROUNDED, $this->taxDetailsItem->getPriceInclTax());
32+
33+
$this->assertSame(
34+
$this->taxDetailsItem,
35+
$this->calculate($this->rowBaseCalculator, false)
3036
);
37+
$this->assertEquals(self::UNIT_PRICE_INCL_TAX, $this->taxDetailsItem->getPriceInclTax());
3138
}
3239

3340
public function testCalculateWithTaxNotInPrice()

‎app/code/Magento/Tax/Test/Unit/Model/Calculation/TotalBaseCalculatorTest.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,21 @@ public function testCalculateWithTaxInPrice()
2222
$this->taxDetailsItem,
2323
$this->calculate($this->totalBaseCalculator)
2424
);
25+
$this->assertEquals(self::UNIT_PRICE_INCL_TAX_ROUNDED, $this->taxDetailsItem->getPriceInclTax());
26+
}
27+
28+
public function testCalculateWithTaxInPriceNoRounding()
29+
{
30+
$this->initTotalBaseCalculator();
31+
$this->totalBaseCalculator->expects($this->exactly(3))
32+
->method('deltaRound')->will($this->returnValue(0));
33+
$this->initMocks(true);
34+
35+
$this->assertSame(
36+
$this->taxDetailsItem,
37+
$this->calculate($this->totalBaseCalculator, false)
38+
);
39+
$this->assertEquals(self::UNIT_PRICE_INCL_TAX, $this->taxDetailsItem->getPriceInclTax());
2540
}
2641

2742
public function testCalculateWithTaxNotInPrice()

‎app/code/Magento/Tax/Test/Unit/Model/Calculation/UnitBaseCalculatorTest.php

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ class UnitBaseCalculatorTest extends \PHPUnit_Framework_TestCase
1818

1919
const CODE = 'CODE';
2020
const TYPE = 'TYPE';
21-
const ROW_TAX = 44.954136954136;
21+
const ROW_TAX = 44.958682408681;
22+
const ROW_TAX_ROUNDED = 44.95;
23+
const PRICE_INCL_TAX = 495.4954954955;
24+
const PRICE_INCL_TAX_ROUNDED = 495.50;
2225

2326
/** @var \PHPUnit_Framework_MockObject_MockObject */
2427
protected $taxDetailsItemDataObjectFactoryMock;
@@ -68,7 +71,11 @@ public function setUp()
6871
$this->mockCalculationTool->expects($this->any())
6972
->method('round')
7073
->withAnyParameters()
71-
->will($this->returnArgument(0));
74+
->willReturnCallback(
75+
function ($price) {
76+
return round($price, 2);
77+
}
78+
);
7279
$this->mockConfig = $this->getMockBuilder('\Magento\Tax\Model\Config')
7380
->disableOriginalConstructor()
7481
->getMock();
@@ -113,34 +120,41 @@ public function setUp()
113120
public function testCalculateWithTaxInPrice()
114121
{
115122
$mockItem = $this->getMockItem();
116-
$mockItem->expects($this->once())
123+
$mockItem->expects($this->atLeastOnce())
117124
->method('getIsTaxIncluded')
118125
->will($this->returnValue(true));
119126

120-
$this->mockConfig->expects($this->once())
127+
$this->mockConfig->expects($this->atLeastOnce())
121128
->method('crossBorderTradeEnabled')
122129
->will($this->returnValue(false));
123-
$this->mockConfig->expects($this->once())
130+
$this->mockConfig->expects($this->atLeastOnce())
124131
->method('applyTaxAfterDiscount')
125132
->will($this->returnValue(true));
126133

127-
$this->mockCalculationTool->expects($this->once())
134+
$this->mockCalculationTool->expects($this->atLeastOnce())
128135
->method('getRate')
129136
->with($this->addressRateRequest)
130137
->will($this->returnValue(self::RATE));
131-
$this->mockCalculationTool->expects($this->once())
138+
$this->mockCalculationTool->expects($this->atLeastOnce())
132139
->method('getStoreRate')
133140
->with($this->addressRateRequest, self::STORE_ID)
134141
->will($this->returnValue(self::STORE_RATE));
135-
$this->mockCalculationTool->expects($this->once())
142+
$this->mockCalculationTool->expects($this->atLeastOnce())
136143
->method('getAppliedRates')
137144
->withAnyParameters()
138145
->will($this->returnValue([]));
139146

140147
$this->assertSame($this->taxDetailsItem, $this->model->calculate($mockItem, self::QUANTITY));
141148
$this->assertSame(self::CODE, $this->taxDetailsItem->getCode());
142149
$this->assertSame(self::TYPE, $this->taxDetailsItem->getType());
150+
$this->assertSame(self::ROW_TAX_ROUNDED, $this->taxDetailsItem->getRowTax());
151+
$this->assertEquals(self::PRICE_INCL_TAX_ROUNDED, $this->taxDetailsItem->getPriceInclTax());
152+
153+
$this->assertSame($this->taxDetailsItem, $this->model->calculate($mockItem, self::QUANTITY, false));
154+
$this->assertSame(self::CODE, $this->taxDetailsItem->getCode());
155+
$this->assertSame(self::TYPE, $this->taxDetailsItem->getType());
143156
$this->assertSame(self::ROW_TAX, $this->taxDetailsItem->getRowTax());
157+
$this->assertEquals(self::PRICE_INCL_TAX, $this->taxDetailsItem->getPriceInclTax());
144158
}
145159

146160
public function testCalculateWithTaxNotInPrice()
@@ -178,16 +192,16 @@ protected function getMockItem()
178192
$mockItem = $this->getMockBuilder('Magento\Tax\Api\Data\QuoteDetailsItemInterface')
179193
->disableOriginalConstructor()
180194
->getMock();
181-
$mockItem->expects($this->once())
195+
$mockItem->expects($this->atLeastOnce())
182196
->method('getDiscountAmount')
183197
->will($this->returnValue(1));
184198
$mockItem->expects($this->atLeastOnce())
185199
->method('getCode')
186200
->will($this->returnValue(self::CODE));
187-
$mockItem->expects($this->once())
201+
$mockItem->expects($this->atLeastOnce())
188202
->method('getType')
189203
->will($this->returnValue(self::TYPE));
190-
$mockItem->expects($this->once())
204+
$mockItem->expects($this->atLeastOnce())
191205
->method('getUnitPrice')
192206
->will($this->returnValue(self::UNIT_PRICE));
193207

0 commit comments

Comments
 (0)