MC-24262: Async multistore webapi test fails with elasticsearch on CI

Author: viktorpetryk

dev/tests/api-functional/testsuite/Magento/WebapiAsync/Model/AsyncScheduleMultiStoreTest.php

@@ -8,20 +8,20 @@
 
 namespace Magento\WebapiAsync\Model;
 
-use Magento\Catalog\Api\Data\ProductInterface as Product;
-use Magento\TestFramework\MessageQueue\PreconditionFailedException;
-use Magento\TestFramework\MessageQueue\PublisherConsumerController;
-use Magento\TestFramework\MessageQueue\EnvironmentPreconditionException;
-use Magento\TestFramework\TestCase\WebapiAbstract;
-use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\ResourceModel\Product\Collection;
+use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\Phrase;
 use Magento\Framework\Registry;
 use Magento\Framework\Webapi\Exception;
-use Magento\Catalog\Api\ProductRepositoryInterface;
-use Magento\Framework\ObjectManagerInterface;
-use Magento\Store\Model\Store;
 use Magento\Framework\Webapi\Rest\Request;
+use Magento\Store\Model\Store;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\MessageQueue\EnvironmentPreconditionException;
+use Magento\TestFramework\MessageQueue\PreconditionFailedException;
+use Magento\TestFramework\MessageQueue\PublisherConsumerController;
+use Magento\TestFramework\TestCase\WebapiAbstract;
 
 /**
  * Check async request for multistore product creation service, scheduling bulk
@@ -86,27 +86,29 @@ class AsyncScheduleMultiStoreTest extends WebapiAbstract
      */
     private $registry;
 
+    /**
+     * @inheritDoc
+     */
     protected function setUp(): void
     {
+        $logFilePath = TESTS_TEMP_DIR . "/MessageQueueTestLog.txt";
         $this->objectManager = Bootstrap::getObjectManager();
-        $this->logFilePath = TESTS_TEMP_DIR . "/MessageQueueTestLog.txt";
         $this->registry = $this->objectManager->get(Registry::class);
 
         $params = array_merge_recursive(
             Bootstrap::getInstance()->getAppInitParams(),
             ['MAGE_DIRS' => ['cache' => ['path' => TESTS_TEMP_DIR . '/cache']]]
         );
 
-        /** @var PublisherConsumerController publisherConsumerController */
         $this->publisherConsumerController = $this->objectManager->create(
             PublisherConsumerController::class,
             [
                 'consumers' => $this->consumers,
-                'logFilePath' => $this->logFilePath,
+                'logFilePath' => $logFilePath,
                 'appInitParams' => $params,
             ]
         );
-        $this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
+        $this->productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
 
         try {
             $this->publisherConsumerController->initialize();
@@ -124,16 +126,11 @@ protected function setUp(): void
     /**
      * @dataProvider storeProvider
      * @magentoApiDataFixture Magento/Store/_files/core_fixturestore.php
+     * @param string|null $storeCode
+     * @return void
      */
-    public function testAsyncScheduleBulkMultistore($storeCode)
+    public function testAsyncScheduleBulkMultistore($storeCode): void
     {
-        if ($storeCode === self::STORE_CODE_FROM_FIXTURE) {
-            /** @var \Magento\Config\Model\Config $config */
-            $config = Bootstrap::getObjectManager()->get(\Magento\Config\Model\Config::class);
-            if (strpos($config->getConfigDataValue('catalog/search/engine'), 'elasticsearch') !== false) {
-                $this->markTestSkipped('MC-20452');
-            }
-        }
         $product = $this->getProductData();
         $this->_markTestAsRestOnly();
 
@@ -147,9 +144,9 @@ public function testAsyncScheduleBulkMultistore($storeCode)
         );
 
         try {
-            /** @var Product $productModel */
+            /** @var ProductInterface $productModel */
             $productModel = $this->objectManager->create(
-                Product::class,
+                ProductInterface::class,
                 ['data' => $product['product']]
             );
             $this->productRepository->save($productModel);
@@ -161,16 +158,21 @@ public function testAsyncScheduleBulkMultistore($storeCode)
         $this->clearProducts();
     }
 
-    private function asyncScheduleAndTest($product, $storeCode = null)
+    /**
+     * @param array $product
+     * @param string|null $storeCode
+     * @return void
+     */
+    private function asyncScheduleAndTest(array $product, $storeCode = null): void
     {
-        $sku = $product['product'][Product::SKU];
-        $productName = $product['product'][Product::NAME];
-        $newProductName = $product['product'][Product::NAME] . $storeCode;
+        $sku = $product['product'][ProductInterface::SKU];
+        $productName = $product['product'][ProductInterface::NAME];
+        $newProductName = $product['product'][ProductInterface::NAME] . $storeCode;
 
         $this->skus[] = $sku;
 
-        $product['product'][Product::NAME] = $newProductName;
-        $product['product'][Product::TYPE_ID] = 'virtual';
+        $product['product'][ProductInterface::NAME] = $newProductName;
+        $product['product'][ProductInterface::TYPE_ID] = 'virtual';
 
         $response = $this->updateProductAsync($product, $sku, $storeCode);
 
@@ -197,14 +199,14 @@ private function asyncScheduleAndTest($product, $storeCode = null)
             $serviceInfo = [
                 'rest' => [
                     'resourcePath' => self::REST_RESOURCE_PATH . '/' . $sku,
-                    'httpMethod' => Request::HTTP_METHOD_GET
+                    'httpMethod' => Request::HTTP_METHOD_GET,
                 ]
             ];
             $storeResponse = $this->_webApiCall($serviceInfo, $requestData, null, $checkingStore);
             if ($checkingStore == $storeCode || $storeCode == self::STORE_CODE_ALL) {
                 $this->assertEquals(
                     $newProductName,
-                    $storeResponse[Product::NAME],
+                    $storeResponse[ProductInterface::NAME],
                     sprintf(
                         'Product name in %s store is invalid after updating in store %s.',
                         $checkingStore,
@@ -214,7 +216,7 @@ private function asyncScheduleAndTest($product, $storeCode = null)
             } else {
                 $this->assertEquals(
                     $productName,
-                    $storeResponse[Product::NAME],
+                    $storeResponse[ProductInterface::NAME],
                     sprintf(
                         'Product name in %s store is invalid after updating in store %s.',
                         $checkingStore,
@@ -225,14 +227,20 @@ private function asyncScheduleAndTest($product, $storeCode = null)
         }
     }
 
+    /**
+     * @inheritDoc
+     */
     protected function tearDown(): void
     {
         $this->clearProducts();
         $this->publisherConsumerController->stopConsumers();
         parent::tearDown();
     }
 
-    private function clearProducts()
+    /**
+     * @return void
+     */
+    private function clearProducts(): void
     {
         $size = $this->objectManager->create(Collection::class)
             ->addAttributeToFilter('sku', ['in' => $this->skus])
@@ -270,7 +278,7 @@ private function clearProducts()
     /**
      * @return array
      */
-    public function getProductData()
+    public function getProductData(): array
     {
         $productBuilder = function ($data) {
             return array_replace_recursive(
@@ -280,23 +288,26 @@ public function getProductData()
         };
 
         return [
-            'product' =>
-                $productBuilder(
-                    [
-                        Product::TYPE_ID => 'simple',
-                        Product::SKU => 'multistore-sku-test-1',
-                        Product::NAME => 'Test Name ',
-                    ]
-                ),
+            'product' => $productBuilder(
+                [
+                    ProductInterface::TYPE_ID => 'simple',
+                    ProductInterface::SKU => 'multistore-sku-test-1',
+                    ProductInterface::NAME => 'Test Name ',
+                ]
+            ),
         ];
     }
 
-    public function storeProvider()
+    /**
+     * @return array
+     */
+    public function storeProvider(): array
     {
         $dataSets = [];
         foreach ($this->stores as $store) {
             $dataSets[$store] = [$store];
         }
+
         return $dataSets;
     }
 
@@ -306,28 +317,28 @@ public function storeProvider()
      * @param array $productData
      * @return array
      */
-    private function getSimpleProductData($productData = [])
+    private function getSimpleProductData($productData = []): array
     {
         return [
-            Product::SKU => isset($productData[Product::SKU])
-                ? $productData[Product::SKU] : uniqid('sku-', true),
-            Product::NAME => isset($productData[Product::NAME])
-                ? $productData[Product::NAME] : uniqid('sku-', true),
-            Product::VISIBILITY => 4,
-            Product::TYPE_ID => 'simple',
-            Product::PRICE => 3.62,
-            Product::STATUS => 1,
-            Product::TYPE_ID => 'simple',
-            Product::ATTRIBUTE_SET_ID => 4,
+            ProductInterface::SKU => isset($productData[ProductInterface::SKU])
+                ? $productData[ProductInterface::SKU] : uniqid('sku-', true),
+            ProductInterface::NAME => isset($productData[ProductInterface::NAME])
+                ? $productData[ProductInterface::NAME] : uniqid('sku-', true),
+            ProductInterface::VISIBILITY => 4,
+            ProductInterface::TYPE_ID => 'simple',
+            ProductInterface::PRICE => 3.62,
+            ProductInterface::STATUS => 1,
+            ProductInterface::ATTRIBUTE_SET_ID => 4,
         ];
     }
 
     /**
-     * @param $requestData
+     * @param array $requestData
+     * @param string $sku
      * @param string|null $storeCode
      * @return mixed
      */
-    private function updateProductAsync($requestData, $sku, $storeCode = null)
+    private function updateProductAsync(array $requestData, string $sku, $storeCode = null)
     {
         $serviceInfo = [
             'rest' => [
@@ -339,40 +350,19 @@ private function updateProductAsync($requestData, $sku, $storeCode = null)
         return $this->_webApiCall($serviceInfo, $requestData, null, $storeCode);
     }
 
-    public function assertProductCreation($product)
+    /**
+     * @param array $product
+     * @return bool
+     */
+    public function assertProductCreation(array $product): bool
     {
-        $sku = $product['product'][Product::SKU];
+        $sku = $product['product'][ProductInterface::SKU];
         $collection = $this->objectManager->create(Collection::class)
-            ->addAttributeToFilter(Product::SKU, ['eq' => $sku])
-            ->addAttributeToFilter(Product::TYPE_ID, ['eq' => 'virtual'])
+            ->addAttributeToFilter(ProductInterface::SKU, ['eq' => $sku])
+            ->addAttributeToFilter(ProductInterface::TYPE_ID, ['eq' => 'virtual'])
             ->load();
         $size = $collection->getSize();
 
         return $size > 0;
     }
-
-    /**
-     * Remove test store
-     * //phpcs:disable
-     */
-    public static function tearDownAfterClass(): void
-    {
-        parent::tearDownAfterClass();
-        //phpcs:enable
-        /** @var Registry $registry */
-        $registry = Bootstrap::getObjectManager()->get(Registry::class);
-
-        $registry->unregister('isSecureArea');
-        $registry->register('isSecureArea', true);
-
-        /** @var Store $store*/
-        $store = Bootstrap::getObjectManager()->create(Store::class);
-        $store->load('fixturestore');
-        if ($store->getId()) {
-            $store->delete();
-        }
-
-        $registry->unregister('isSecureArea');
-        $registry->register('isSecureArea', false);
-    }
 }