MAGETWO-56743: Unable to upgrade with split databases

Author: Stanislav Idolov

app/code/Magento/OfflineShipping/composer.json

@@ -8,14 +8,14 @@
         "magento/module-backend": "100.2.*",
         "magento/module-shipping": "100.2.*",
         "magento/module-catalog": "101.1.*",
-        "magento/module-sales": "100.2.*",
         "magento/module-sales-rule": "100.2.*",
         "magento/module-directory": "100.2.*",
         "magento/module-quote": "100.2.*",
         "magento/framework": "100.2.*"
     },
     "suggest": {
         "magento/module-checkout": "100.2.*",
+        "magento/module-sales": "100.2.*",
         "magento/module-offline-shipping-sample-data": "Sample Data version:100.2.*"
     },
     "type": "magento2-module",

app/code/Magento/Sales/Setup/SalesSetup.php

@@ -15,6 +15,7 @@
 /**
  * Setup Model of Sales Module
  * @codeCoverageIgnore
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SalesSetup extends \Magento\Eav\Setup\EavSetup
 {

app/code/Magento/Sales/Setup/UpgradeSchema.php

@@ -4,6 +4,7 @@
  * See COPYING.txt for license details.
  */
 namespace Magento\Sales\Setup;
+
 use Magento\Framework\Setup\UpgradeSchemaInterface;
 use Magento\Framework\Setup\ModuleContextInterface;
 use Magento\Framework\Setup\SchemaSetupInterface;
@@ -35,7 +36,8 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
                     'product_id',
                     'catalog_product_entity',
                     'entity_id',
-                    self::$connectionName)
+                    self::$connectionName
+                )
             );
             //sales_bestsellers_aggregated_monthly
             $connection->dropForeignKey(
@@ -45,7 +47,8 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
                     'product_id',
                     'catalog_product_entity',
                     'entity_id',
-                    self::$connectionName)
+                    self::$connectionName
+                )
             );
 
             //sales_bestsellers_aggregated_yearly
@@ -56,7 +59,8 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
                     'product_id',
                     'catalog_product_entity',
                     'entity_id',
-                    self::$connectionName)
+                    self::$connectionName
+                )
             );
 
             $installer->endSetup();

app/code/Magento/SalesSequence/Setup/InstallSchema.php

@@ -100,7 +100,8 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
                 'sales_sequence_profile',
                 'meta_id',
                 'sales_sequence_meta',
-                'meta_id', self::$connectionName
+                'meta_id',
+                self::$connectionName
             ),
             'meta_id',
             $installer->getTable('sales_sequence_meta', self::$connectionName),

lib/internal/Magento/Framework/Module/Setup.php

@@ -144,6 +144,7 @@ private function _getTableCacheName($tableName)
      * Check is table exists
      *
      * @param string $table
+     * @param string $connectionName
      * @return bool
      */
     public function tableExists($table, $connectionName = ResourceConnection::DEFAULT_CONNECTION)