Skip to content

Commit f1e0250

Browse files
ENGCOM-4392: Database Rollback not working M2.3.0 #21151
- Merge Pull Request #21151 from Stepa4man/magento2:MSI-1988 - Merged commits: 1. 07e3cf5 2. b11652b
2 parents 64bf751 + b11652b commit f1e0250

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

app/code/Magento/Backup/Model/Db.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,12 @@ class Db implements \Magento\Framework\Backup\Db\BackupDbInterface
5656
private $getViewsBackup;
5757

5858
/**
59-
* @param \Magento\Backup\Model\ResourceModel\Db $resourceDb
59+
* Db constructor.
60+
* @param ResourceModel\Db $resourceDb
6061
* @param \Magento\Framework\App\ResourceConnection $resource
62+
* @param Helper|null $helper
6163
* @param GetListTables|null $getListTables
6264
* @param GetViewsBackup|null $getViewsBackup
63-
* @param Helper|null $helper
6465
*/
6566
public function __construct(
6667
\Magento\Backup\Model\ResourceModel\Db $resourceDb,

app/code/Magento/Backup/Model/ResourceModel/Table/GetListTables.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,14 @@ public function __construct(ResourceConnection $resource)
3030
}
3131

3232
/**
33+
* Get base tables
34+
*
3335
* @return array
3436
*/
3537
public function execute()
3638
{
3739
return $this->resource->getConnection('backup')->fetchCol(
38-
"SHOW FULL TABLES WHERE `Table_type` = ?",
40+
"SHOW FULL TABLES WHERE `Table_type` = ?",
3941
self::TABLE_TYPE
4042
);
4143
}

app/code/Magento/Backup/Model/ResourceModel/View/GetListViews.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ public function __construct(ResourceConnection $resource)
2929
}
3030

3131
/**
32+
* Get view tables
33+
*
3234
* @return array
3335
*/
3436
public function execute()

app/code/Magento/Backup/Model/ResourceModel/View/GetViewsBackup.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public function __construct(
4444
}
4545

4646
/**
47+
* Backup
48+
*
4749
* @param BackupInterface $backup
4850
*/
4951
public function execute(BackupInterface $backup)
@@ -58,6 +60,8 @@ public function execute(BackupInterface $backup)
5860
}
5961

6062
/**
63+
* Get connection
64+
*
6165
* @return AdapterInterface
6266
*/
6367
private function getConnection()
@@ -70,6 +74,8 @@ private function getConnection()
7074
}
7175

7276
/**
77+
* Get show create view
78+
*
7379
* @param string $viewName
7480
* @return string
7581
*/
@@ -85,6 +91,8 @@ private function getShowCreateView($viewName)
8591
}
8692

8793
/**
94+
* Get view header
95+
*
8896
* @param string $viewName
8997
* @return string
9098
*/
@@ -95,6 +103,8 @@ public function getViewHeader($viewName)
95103
}
96104

97105
/**
106+
* Get drop view SQL
107+
*
98108
* @param string $viewName
99109
* @return string
100110
*/

0 commit comments

Comments
 (0)