MC-33069: Stabilize Unit tests

SeruyV · SeruyV · commit f18a9afbb05e · 2020-05-06T13:59:37.000+03:00
diff --git a/lib/internal/Magento/Framework/DB/FieldDataConverter.php b/lib/internal/Magento/Framework/DB/FieldDataConverter.php
@@ -128,7 +128,7 @@ private function getBatchSize()
     {
         if (null !== $this->envBatchSize) {
             $batchSize = (int) $this->envBatchSize;
-            if (bccomp($batchSize, PHP_INT_MAX, 0) === 1 || $batchSize < 1) {
+            if (bccomp($batchSize, PHP_INT_MAX, 0) >= 0 || $batchSize < 1) {
                 throw new \InvalidArgumentException(
                     'Invalid value for environment variable ' . self::BATCH_SIZE_VARIABLE_NAME . '. '
                     . 'Should be integer, >= 1 and < value of PHP_INT_MAX'

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ private function getBatchSize()`
`128`	`128`	`{`
`129`	`129`	`if (null !== $this->envBatchSize) {`
`130`	`130`	`$batchSize = (int) $this->envBatchSize;`
`131`		`- if (bccomp($batchSize, PHP_INT_MAX, 0) === 1 \|\| $batchSize < 1) {`
	`131`	`+ if (bccomp($batchSize, PHP_INT_MAX, 0) >= 0 \|\| $batchSize < 1) {`
`132`	`132`	`throw new \InvalidArgumentException(`
`133`	`133`	`'Invalid value for environment variable ' . self::BATCH_SIZE_VARIABLE_NAME . '. '`
`134`	`134`	`. 'Should be integer, >= 1 and < value of PHP_INT_MAX'`