Skip to content

Commit f16a0bf

Browse files
committed
MC-18487: Merge release branch into 2.2-develop
- Fixed conflicts in files non composer files - Updated version of mftf framework in composer.json
1 parent dc9b1bd commit f16a0bf

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

app/code/Magento/CatalogRule/Test/Mftf/ActionGroup/CatalogPriceRuleActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
<fillField selector="{{AdminCatalogPriceRuleActionsSection.discountAmount}}" userInput="{{catalogRule.discount_amount}}" stepKey="fillDiscountValue"/>
151151
<selectOption selector="{{AdminCatalogPriceRuleActionsSection.disregardRules}}" userInput="Yes" stepKey="discardSubsequentRules"/>
152152
</actionGroup>
153-
153+
154154
<actionGroup name="AdminFillCatalogRuleConditionActionGroup">
155155
<arguments>
156156
<argument name="condition" type="string"/>

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use Magento\Framework\Event\ObserverInterface;
1212
use Magento\Framework\Exception\NoSuchEntityException;
1313
use Magento\Quote\Api\CartRepositoryInterface;
14-
use Magento\Quote\Api\Data\CartInterface;
1514
use Magento\Quote\Model\Quote;
1615

1716
/**
@@ -132,6 +131,7 @@ public function execute(\Magento\Framework\Event\Observer $observer)
132131
$this->_eventManager->dispatch('persistent_session_expired');
133132
$this->quoteManager->expire();
134133
$this->_checkoutSession->clearQuote();
134+
$this->_customerSession->setCustomerId(null)->setCustomerGroupId(null);
135135
return;
136136
}
137137

@@ -156,7 +156,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
156156
*/
157157
private function isPersistentQuoteOutdated(): bool
158158
{
159-
if (!$this->_persistentData->isEnabled() && !$this->_customerSession->isLoggedIn()
159+
if ((!$this->_persistentData->isEnabled() || !$this->_persistentData->isShoppingCartPersist())
160+
&& !$this->_customerSession->isLoggedIn()
160161
&& $this->_checkoutSession->getQuoteId()
161162
&& $this->isActiveQuote()
162163
) {

app/code/Magento/Sales/Test/Mftf/Test/AdminReorderWithCatalogPriceTest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@
5252
<actionGroup ref="logout" stepKey="logout"/>
5353
</after>
5454
<!--Open order by Id-->
55-
<actionGroup ref="OpenOrderById" stepKey="openOrderById">
55+
<actionGroup ref="OpenOrderByName" stepKey="openOrderById">
5656
<argument name="orderId" value="$createGuestCart.return$"/>
57+
<argument name="orderName" value="{{ShippingAddressTX.fullname}}"/>
5758
</actionGroup>
5859
<!--Reorder-->
5960
<click selector="{{AdminOrderDetailsMainActionsSection.reorder}}" stepKey="clickReorder"/>

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
},
7777
"require-dev": {
7878
"allure-framework/allure-phpunit": "~1.2.0",
79-
"magento/magento2-functional-testing-framework": "2.4.5",
79+
"magento/magento2-functional-testing-framework": "2.5.0",
8080
"phpunit/phpunit": "~6.2.0",
8181
"squizlabs/php_codesniffer": "3.2.2",
8282
"phpmd/phpmd": "@stable",

0 commit comments

Comments
 (0)