Skip to content

Commit f165c8f

Browse files
committed
Code review improvements
1 parent a156298 commit f165c8f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/WriteIptc.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,12 @@ public function execute(FileInterface $file, MetadataInterface $metadata): FileI
9696
*/
9797
private function insertPngIptcSegment(array $segments, SegmentInterface $xmpSegment): array
9898
{
99+
$iendSegmentIndex = count($segments) - 1;
100+
99101
return array_merge(
100-
array_slice($segments, 0, count($segments) - 1),
102+
array_slice($segments, 0, $iendSegmentIndex),
101103
[$xmpSegment],
102-
array_slice($segments, count($segments) - 1)
104+
array_slice($segments, $iendSegmentIndex)
103105
);
104106
}
105107

app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/WriteXmp.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,11 @@ public function execute(FileInterface $file, MetadataInterface $metadata): FileI
105105
*/
106106
private function insertPngXmpSegment(array $segments, SegmentInterface $xmpSegment): array
107107
{
108+
$iendSegmentIndex = count($segments) - 1;
108109
return array_merge(
109-
array_slice($segments, 0, count($segments) - 1),
110+
array_slice($segments, 0, $iendSegmentIndex),
110111
[$xmpSegment],
111-
array_slice($segments, count($segments) - 1)
112+
array_slice($segments, $iendSegmentIndex)
112113
);
113114
}
114115

0 commit comments

Comments
 (0)