PWA-1576: GQL gaps for Admin configuration

 - update schema descriptions

Author: cspruiell

app/code/Magento/PaymentGraphQl/etc/schema.graphqls

@@ -1,21 +1,21 @@
 # Copyright © Magento, Inc. All rights reserved.
 # See COPYING.txt for license details.
-type StoreConfig @doc(description: "The type contains information about a store config") {
-    zero_subtotal_enabled: String @doc(description: "Zero Subtotal payment method functionality status: enabled/disabled")
-    zero_subtotal_title: String @doc(description: "Zero Subtotal payment method title on frontend")
+type StoreConfig {
+    zero_subtotal_enabled: Boolean @doc(description: "Zero Subtotal payment method functionality status: enabled/disabled")
+    zero_subtotal_title: String @doc(description: "The title of the Zero Subtotal payment method displayed on the storefront")
     zero_subtotal_new_order_status: String @doc(description: "Status of new orders placed using the Zero Subtotal payment method")
-    zero_subtotal_payment_action: String @doc(description: "Automatically invoice all items that have a zero balance")
-    zero_subtotal_payment_from_applicable_countries: String @doc(description: "Which countries may use the Zero Subtotal payment method: All Allowed Countries/Specific Countries")
-    zero_subtotal_payment_from_specific_countries: String @doc(description: "Specific countries allowed to use the Zero Subtotal payment method")
-    zero_subtotal_sort_order: String @doc(description: "The position of the Zero Subtotal payment method in the list of available payment methods during checkout")
-    check_money_order_enabled: String @doc(description: "Check/Money Order payment method status: enabled/disabled")
-    check_money_order_title: String @doc(description: "Check/Money Order payment method title on frontend")
+    zero_subtotal_payment_action: String @doc(description: "When the new order status is 'Processing', this can be set to 'authorize_capture' to automatically invoice all items that have a zero balance")
+    zero_subtotal_payment_from_applicable_countries: String @doc(description: "States whether All Allowed Countries or Specific Countries can use the Zero Subtotal payment method")
+    zero_subtotal_payment_from_specific_countries: String @doc(description: "Comma-separated list of specific countries allowed to use the Zero Subtotal payment method")
+    zero_subtotal_sort_order: String @doc(description: "A number indicating the position of the Zero Subtotal payment method in the list of available payment methods during checkout")
+    check_money_order_enabled: Boolean @doc(description: "Check/Money Order payment method status: enabled/disabled")
+    check_money_order_title: String @doc(description: "The title of the Check/Money Order payment method displayed on the storefront")
     check_money_order_new_order_status: String @doc(description: "Status of new orders placed using the Check/Money Order payment method")
-    check_money_order_payment_from_applicable_countries: String @doc(description: "Which countries may use the Check/Money Order payment method: All Allowed Countries/Specific Countries")
-    check_money_order_payment_from_specific_countries: String @doc(description: "Specific countries allowed to use the Check/Money Order payment method")
+    check_money_order_payment_from_applicable_countries: String @doc(description: "States whether All Allowed Countries or Specific Countries can use the Check/Money Order payment method")
+    check_money_order_payment_from_specific_countries: String @doc(description: "Comma-separated list of specific countries allowed to use the Check/Money Order payment method")
     check_money_order_make_check_payable_to: String @doc(description: "The name of the party to whom the check must be payable")
-    check_money_order_send_check_to: String @doc(description: "The street address or PO Box where the checks are mailed")
+    check_money_order_send_check_to: String @doc(description: "The full street address or PO Box where the checks are mailed")
     check_money_order_min_order_total: String @doc(description: "Minimum order amount required to qualify for the Check/Money Order payment method")
     check_money_order_max_order_total: String @doc(description: "Maximum order amount required to qualify for the Check/Money Order payment method")
-    check_money_order_sort_order: String @doc(description: "The position of the Check/Money Order payment method in the list of available payment methods during checkout")
+    check_money_order_sort_order: String @doc(description: "A number indicating the position of the Check/Money Order payment method in the list of available payment methods during checkout")
 }

dev/tests/api-functional/testsuite/Magento/GraphQl/PaymentGraphQl/StoreConfigTest.php

@@ -66,14 +66,14 @@ public function testStoreConfigZeroSubtotalCheckMoneyOrderDefaultValues()
         self::assertArrayHasKey('check_money_order_max_order_total', $response['storeConfig']);
         self::assertArrayHasKey('check_money_order_sort_order', $response['storeConfig']);
 
-        self::assertEquals('1', $response['storeConfig']['zero_subtotal_enabled']);
+        self::assertTrue($response['storeConfig']['zero_subtotal_enabled']);
         self::assertEquals('No Payment Information Required', $response['storeConfig']['zero_subtotal_title']);
         self::assertEquals('pending', $response['storeConfig']['zero_subtotal_new_order_status']);
         self::assertEquals('authorize_capture', $response['storeConfig']['zero_subtotal_payment_action']);
         self::assertEquals('0', $response['storeConfig']['zero_subtotal_payment_from_applicable_countries']);
         self::assertNull($response['storeConfig']['zero_subtotal_payment_from_specific_countries']);
         self::assertEquals('1', $response['storeConfig']['zero_subtotal_sort_order']);
-        self::assertEquals('1', $response['storeConfig']['check_money_order_enabled']);
+        self::assertTrue($response['storeConfig']['check_money_order_enabled']);
         self::assertEquals('Check / Money order', $response['storeConfig']['check_money_order_title']);
         self::assertEquals('pending', $response['storeConfig']['check_money_order_new_order_status']);
         self::assertEquals('0', $response['storeConfig']['check_money_order_payment_from_applicable_countries']);
@@ -114,14 +114,14 @@ public function testStoreConfigZeroSubtotalCheckMoneyOrderDisabled()
         self::assertArrayHasKey('check_money_order_max_order_total', $response['storeConfig']);
         self::assertArrayHasKey('check_money_order_sort_order', $response['storeConfig']);
 
-        self::assertEquals('0', $response['storeConfig']['zero_subtotal_enabled']);
+        self::assertFalse($response['storeConfig']['zero_subtotal_enabled']);
         self::assertEquals('No Payment Information Required', $response['storeConfig']['zero_subtotal_title']);
         self::assertEquals('pending', $response['storeConfig']['zero_subtotal_new_order_status']);
         self::assertEquals('authorize_capture', $response['storeConfig']['zero_subtotal_payment_action']);
         self::assertEquals('0', $response['storeConfig']['zero_subtotal_payment_from_applicable_countries']);
         self::assertNull($response['storeConfig']['zero_subtotal_payment_from_specific_countries']);
         self::assertEquals('1', $response['storeConfig']['zero_subtotal_sort_order']);
-        self::assertEquals('0', $response['storeConfig']['check_money_order_enabled']);
+        self::assertFalse($response['storeConfig']['check_money_order_enabled']);
         self::assertEquals('Check / Money order', $response['storeConfig']['check_money_order_title']);
         self::assertEquals('pending', $response['storeConfig']['check_money_order_new_order_status']);
         self::assertEquals('0', $response['storeConfig']['check_money_order_payment_from_applicable_countries']);
@@ -173,14 +173,14 @@ public function testStoreConfigZeroSubtotalCheckMoneyOrderCustom()
         self::assertArrayHasKey('check_money_order_max_order_total', $response['storeConfig']);
         self::assertArrayHasKey('check_money_order_sort_order', $response['storeConfig']);
 
-        self::assertEquals('1', $response['storeConfig']['zero_subtotal_enabled']);
+        self::assertTrue($response['storeConfig']['zero_subtotal_enabled']);
         self::assertEquals('Test Zero Subtotal Title', $response['storeConfig']['zero_subtotal_title']);
         self::assertEquals('processing', $response['storeConfig']['zero_subtotal_new_order_status']);
         self::assertEquals('authorize_capture', $response['storeConfig']['zero_subtotal_payment_action']);
         self::assertEquals('1', $response['storeConfig']['zero_subtotal_payment_from_applicable_countries']);
         self::assertEquals('DZ', $response['storeConfig']['zero_subtotal_payment_from_specific_countries']);
         self::assertEquals('5', $response['storeConfig']['zero_subtotal_sort_order']);
-        self::assertEquals('1', $response['storeConfig']['check_money_order_enabled']);
+        self::assertTrue($response['storeConfig']['check_money_order_enabled']);
         self::assertEquals('Test Check / Money Order Title', $response['storeConfig']['check_money_order_title']);
         self::assertEquals('pending', $response['storeConfig']['check_money_order_new_order_status']);
         self::assertEquals('1', $response['storeConfig']['check_money_order_payment_from_applicable_countries']);