Merge pull request #6615 from magento-lynx/MC-39923

MC-39923 Stabilize Integration Tests (PageBuilder)

Author: svera

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Gallery/UploadTest.php

@@ -167,7 +167,7 @@ public function testUploadActionWithErrors(array $file, array $expectation): voi
         $this->assertEquals($expectation['errorcode'], $jsonBody['errorcode']);
 
         if (!empty($expectation['tmp_media_path'])) {
-            $this->assertFileNotExists(
+            $this->assertFileDoesNotExist(
                 $this->getFileAbsolutePath($expectation['tmp_media_path'])
             );
         }

dev/tests/integration/testsuite/Magento/Catalog/Model/ImageUploaderTest.php

@@ -90,7 +90,7 @@ public function testMoveFileFromTmp(): void
     {
         $expectedFilePath = $this->imageUploader->getBasePath() . DIRECTORY_SEPARATOR . 'magento_small_image_1.jpg';
 
-        $this->assertFileNotExists($this->mediaDirectory->getAbsolutePath($expectedFilePath));
+        $this->assertFileDoesNotExist($this->mediaDirectory->getAbsolutePath($expectedFilePath));
 
         $this->imageUploader->moveFileFromTmp('magento_small_image.jpg');
 

dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Gallery/UpdateHandlerTest.php

@@ -289,7 +289,7 @@ public function testExecuteWithImageToDelete(): void
         $this->updateHandler->execute($product);
         $productImages = $this->galleryResource->loadProductGalleryByAttributeId($product, $this->mediaAttributeId);
         $this->assertCount(0, $productImages);
-        $this->assertFileNotExists(
+        $this->assertFileDoesNotExist(
             $this->mediaDirectory->getAbsolutePath($this->config->getBaseMediaPath() . $image)
         );
         $defaultImages = $this->productResource->getAttributeRawValue(

dev/tests/integration/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/Images/NewFolderTest.php

@@ -111,7 +111,7 @@ public function testExecuteWithWrongPath()
         $this->model->getStorage()->getSession()->setCurrentPath($this->fullDirectoryPath . $dirPath);
         $this->model->execute();
 
-        $this->assertFileNotExists(
+        $this->assertFileDoesNotExist(
             $this->fullDirectoryPath . $dirPath . $this->dirName
         );
     }

dev/tests/integration/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/Images/UploadTest.php

@@ -182,7 +182,7 @@ public function testExecuteWithWrongPath()
         $this->model->getStorage()->getSession()->setCurrentPath($dirPath);
         $this->model->execute();
 
-        $this->assertFileNotExists(
+        $this->assertFileDoesNotExist(
             $this->fullDirectoryPath . $dirPath . $this->fileName
         );
     }
@@ -202,7 +202,7 @@ public function testExecuteWithWrongFileName()
         $this->model->getStorage()->getSession()->setCurrentPath($this->fullDirectoryPath);
         $this->model->execute();
 
-        $this->assertFileNotExists($this->fullDirectoryPath . $newFilename);
+        $this->assertFileDoesNotExist($this->fullDirectoryPath . $newFilename);
     }
 
     /**

dev/tests/integration/testsuite/Magento/Cms/Model/Wysiwyg/Images/StorageTest.php

@@ -121,7 +121,7 @@ public function testDeleteDirectory(): void
         $this->storage->createDirectory($dir, $path);
         $this->assertFileExists($fullPath);
         $this->storage->deleteDirectory($fullPath);
-        $this->assertFileNotExists($fullPath);
+        $this->assertFileDoesNotExist($fullPath);
     }
 
     /**
@@ -167,7 +167,9 @@ public function testUploadFile(): void
      */
     public function testUploadFileWithExcludedDirPath(): void
     {
-        $this->expectExceptionMessage("We can't upload the file to current folder right now. Please try another folder.");
+        $this->expectExceptionMessage(
+            "We can't upload the file to current folder right now. Please try another folder."
+        );
         $this->expectException(\Magento\Framework\Exception\LocalizedException::class);
         $fileName = 'magento_small_image.jpg';
         $tmpDirectory = $this->filesystem->getDirectoryWrite(\Magento\Framework\App\Filesystem\DirectoryList::SYS_TMP);

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/UseCase/WildcardTopicTest.php

@@ -63,15 +63,15 @@ public function testWildCardNonMatchingTopic()
         $testObject = $this->generateTestObject();
         $this->publisher->publish('not.matching.wildcard.topic', $testObject);
         sleep(2);
-        $this->assertFileNotExists($this->logFilePath, "No log file must be created for non-matching topic.");
+        $this->assertFileDoesNotExist($this->logFilePath, "No log file must be created for non-matching topic.");
     }
 
     /**
      * @return AsyncTestData
      */
     private function generateTestObject()
     {
-        $testObject = $this->objectManager->create(AsyncTestData::class);
+        $testObject = $this->objectManager->create(AsyncTestData::class); // @phpstan-ignore-line
         $testObject->setValue('||Message Contents||');
         $testObject->setTextFilePath($this->logFilePath);
         return $testObject;

dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/Adapter/CsvTest.php

@@ -62,7 +62,7 @@ public function testDestruct(): void
         );
         /** Assert that the destination file was removed after destruct */
         $this->csv = null;
-        $this->assertFileNotExists(
+        $this->assertFileDoesNotExist(
             $directoryHandle->getAbsolutePath($this->destination),
             'The destination file was\'t removed after destruct'
         );

dev/tests/integration/testsuite/Magento/Setup/Module/I18n/Pack/GeneratorTest.php

@@ -86,7 +86,7 @@ protected function tearDown(): void
 
     public function testGeneration()
     {
-        $this->assertFileNotExists($this->_packPath);
+        $this->assertFileDoesNotExist($this->_packPath);
 
         ComponentRegistrar::register(
             ComponentRegistrar::MODULE,