MAGETWO-61240: Fix \Magento\Sniffs\Translation\ConstantUsageSniff

Fixing static test

Author: Igor Melnikov

dev/tests/static/framework/Magento/Sniffs/Translation/ConstantUsageSniff.php

@@ -27,15 +27,15 @@ public function register()
     }
 
     /**
-     * Copied from \Generic_Sniffs_Files_LineLengthSniff
+     * Copied from \Generic_Sniffs_Files_LineLengthSniff, minor changes made
      *
      * {@inheritDoc}
      */
     public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
-        // Make sure this is the first open tag.
+        // Make sure this is the first open tag
         $previousOpenTag = $phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1));
         if ($previousOpenTag !== false) {
             return;
@@ -45,19 +45,16 @@ public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
         $currentLineContent = '';
         $currentLine = 1;
 
-        $trim = (strlen($phpcsFile->eolChar) * -1);
         for (; $tokenCount < $phpcsFile->numTokens; $tokenCount++) {
             if ($tokens[$tokenCount]['line'] === $currentLine) {
                 $currentLineContent .= $tokens[$tokenCount]['content'];
             } else {
-                $currentLineContent = substr($currentLineContent, 0, $trim);
                 $this->checkIfFirstArgumentConstant($phpcsFile, ($tokenCount - 1), $currentLineContent);
                 $currentLineContent = $tokens[$tokenCount]['content'];
                 $currentLine++;
             }
         }
 
-        $currentLineContent = substr($currentLineContent, 0, $trim);
         $this->checkIfFirstArgumentConstant($phpcsFile, ($tokenCount - 1), $currentLineContent);
     }
 

dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/ConstantUsageSniffTest.php

@@ -43,7 +43,6 @@ public function testProcessIncorrectArguments($file, $numIncorrectUsages)
         $this->fileMock->expects($this->once())
             ->method('getTokens')
             ->willReturn($tokens);
-        $this->fileMock->eolChar = 2;
         $this->fileMock->numTokens = count($tokens);
         $this->fileMock->expects($this->exactly($numIncorrectUsages))
             ->method('addError')