MAGETWO-30809: Compiled definitions can cause unexpected errors compared to runtime definitions

 - Removed unit test method from serializedTest
 - added new test for abstract class Compiled

Author: Bibu Mathew

dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Definition/Compiled/SerializedTest.php

@@ -31,30 +31,4 @@ public function testGetParametersWithUnpacking()
         $model = new \Magento\Framework\ObjectManager\Definition\Compiled\Serialized([$signatures, $definitions]);
         $this->assertEquals($checkString, $model->getParameters('wonderful'));
     }
-
-    public function testGetParametersWithUndefinedDefinition()
-    {
-        $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
-        $undefinedDefinitionSignature = new \stdClass();
-        $className = 'undefinedDefinition';
-        $readerMock = $this->getMock(
-            '\Magento\Framework\Code\Reader\ClassReader',
-            ['getConstructor'],
-            [],
-            '',
-            false
-        );
-        $readerMock->expects($this->once())
-            ->method('getConstructor')
-            ->with($className)
-            ->willReturn($undefinedDefinitionSignature);
-        $model = $objectManager->getObject(
-            'Magento\Framework\ObjectManager\Definition\Compiled\Serialized',
-            [
-                'definitions' => [[], []],
-                'reader' => $readerMock
-            ]
-        );
-        $this->assertEquals($undefinedDefinitionSignature, $model->getParameters($className));
-    }
 }

dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Definition/CompiledTest.php

@@ -0,0 +1,52 @@
+<?php
+/**
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ */
+namespace Magento\Framework\ObjectManager\Definition;
+
+class CompiledTest extends \PHPUnit_Framework_TestCase
+{
+    public function testGetParametersWithUndefinedDefinition()
+    {
+        $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+        $undefinedDefinitionSignature = new \stdClass();
+        $className = 'undefinedDefinition';
+        $readerMock = $this->getMock(
+            '\Magento\Framework\Code\Reader\ClassReader',
+            ['getConstructor'],
+            [],
+            '',
+            false
+        );
+        $readerMock->expects($this->once())
+            ->method('getConstructor')
+            ->with($className)
+            ->willReturn($undefinedDefinitionSignature);
+        $model = $objectManager->getObject(
+            'Magento\Framework\ObjectManager\Definition\CompiledStub',
+            [
+                'definitions' => [[], []],
+                'reader' => $readerMock
+            ]
+        );
+        $this->assertEquals($undefinedDefinitionSignature, $model->getParameters($className));
+    }
+}
+
+/**
+ * Stub class for abstract Magento\Framework\ObjectManager\Definition
+ */
+class CompiledStub extends Compiled
+{
+
+    /**
+     * Unpack signature
+     *
+     * @param string $signature
+     * @return mixed
+     */
+    protected function _unpack($signature)
+    {
+        return unserialize($signature);
+    }
+}