Merge pull request #77 from magento-goinc/pr_branch

[SWAT] Bugfixes

Author: kandy

app/code/Magento/Catalog/Api/AttributeSetFinderInterface.php

@@ -6,6 +6,10 @@
  */
 namespace Magento\Catalog\Api;
 
+/**
+ * Interface AttributeSetFinderInterface
+ * @api
+ */
 interface AttributeSetFinderInterface
 {
     /**

app/code/Magento/Catalog/Api/Data/CategoryProductSearchResultInterface.php

@@ -6,6 +6,10 @@
  */
 namespace Magento\Catalog\Api\Data;
 
+/**
+ * Interface CategoryProductSearchResultInterface
+ * @api
+ */
 interface CategoryProductSearchResultInterface extends \Magento\Framework\Api\SearchResultsInterface
 {
     /**

app/code/Magento/Catalog/Api/Data/ProductOptionInterface.php

@@ -9,6 +9,7 @@
 
 /**
  * Product option interface
+ * @api
  */
 interface ProductOptionInterface extends ExtensibleDataInterface
 {

app/code/Magento/Catalog/Api/ProductWebsiteLinkRepositoryInterface.php

@@ -6,6 +6,10 @@
 
 namespace Magento\Catalog\Api;
 
+/**
+ * Interface ProductWebsiteLinkRepositoryInterface
+ * @api
+ */
 interface ProductWebsiteLinkRepositoryInterface
 {
     /**

app/code/Magento/CatalogImportExport/Model/Import/Product.php

@@ -16,9 +16,8 @@
 use Magento\ImportExport\Model\Import;
 use Magento\ImportExport\Model\Import\ErrorProcessing\ProcessingError;
 use Magento\ImportExport\Model\Import\ErrorProcessing\ProcessingErrorAggregatorInterface;
-use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\ImportExport\Model\Import\Entity\AbstractEntity;
-
+use Magento\Catalog\Model\Product\Visibility;
 /**
  * Import entity product model
  * @SuppressWarnings(PHPMD.TooManyFields)
@@ -104,6 +103,11 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
      */
     const COL_CATEGORY = 'categories';
 
+    /**
+     * Column product visibility.
+     */
+    const COL_VISIBILITY = 'visibility';
+
     /**
      * Column product sku.
      */
@@ -2286,7 +2290,8 @@ public function validateRow(array $rowData, $rowNum)
         }
         // validate custom options
         $this->getOptionEntity()->validateRow($rowData, $rowNum);
-        if (!empty($rowData[self::URL_KEY]) || !empty($rowData[self::COL_NAME])) {
+
+        if ($this->isNeedToValidateUrlKey($rowData)) {
             $urlKey = $this->getUrlKey($rowData);
             $storeCodes = empty($rowData[self::COL_STORE_VIEW_CODE])
                 ? array_flip($this->storeResolver->getStoreCodeToId())
@@ -2308,6 +2313,18 @@ public function validateRow(array $rowData, $rowNum)
         return !$this->getErrorAggregator()->isRowInvalid($rowNum);
     }
 
+    /**
+     * @param array $rowData
+     * @return bool
+     */
+    private function isNeedToValidateUrlKey($rowData)
+    {
+        return (!empty($rowData[self::URL_KEY]) || !empty($rowData[self::COL_NAME]))
+            && (empty($rowData[self::COL_VISIBILITY])
+            || $rowData[self::COL_VISIBILITY]
+            !== (string)Visibility::getOptionArray()[Visibility::VISIBILITY_NOT_VISIBLE]);
+    }
+
     /**
      * Prepare new SKU data
      *

app/code/Magento/CatalogRule/Api/CatalogRuleRepositoryInterface.php

@@ -5,34 +5,34 @@
  */
 namespace Magento\CatalogRule\Api;
 
+/**
+ * Interface CatalogRuleRepositoryInterface
+ * @api
+ */
 interface CatalogRuleRepositoryInterface
 {
     /**
-     * @api
      * @param \Magento\CatalogRule\Api\Data\RuleInterface $rule
      * @return \Magento\CatalogRule\Api\Data\RuleInterface
      * @throws \Magento\Framework\Exception\CouldNotSaveException
      */
     public function save(\Magento\CatalogRule\Api\Data\RuleInterface $rule);
 
     /**
-     * @api
      * @param int $ruleId
      * @return \Magento\CatalogRule\Api\Data\RuleInterface
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
     public function get($ruleId);
 
     /**
-     * @api
      * @param \Magento\CatalogRule\Api\Data\RuleInterface $rule
      * @return bool
      * @throws \Magento\Framework\Exception\CouldNotDeleteException
      */
     public function delete(\Magento\CatalogRule\Api\Data\RuleInterface $rule);
 
     /**
-     * @api
      * @param int $ruleId
      * @return bool
      * @throws \Magento\Framework\Exception\CouldNotDeleteException

app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php

@@ -113,7 +113,7 @@ protected function generateProductUrls($websiteId, $originWebsiteId)
         $collection = $this->productFactory->create()
             ->getCollection()
             ->addCategoryIds()
-            ->addAttributeToSelect(['name', 'url_path', 'url_key'])
+            ->addAttributeToSelect(['name', 'url_path', 'url_key', 'visibility'])
             ->addWebsiteFilter($websiteIds);
         foreach ($collection as $product) {
             /** @var \Magento\Catalog\Model\Product $product */

app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/View.php

@@ -100,7 +100,7 @@ protected function generateProductUrls($websiteId, $originWebsiteId, $storeId)
         $collection = $this->productFactory->create()
             ->getCollection()
             ->addCategoryIds()
-            ->addAttributeToSelect(['name', 'url_path', 'url_key'])
+            ->addAttributeToSelect(['name', 'url_path', 'url_key', 'visibility'])
             ->addWebsiteFilter($websiteIds);
         foreach ($collection as $product) {
             $product->setStoreId($storeId);

app/code/Magento/CatalogUrlRewrite/Model/ProductUrlRewriteGenerator.php

@@ -12,6 +12,7 @@
 use Magento\CatalogUrlRewrite\Model\Product\AnchorUrlRewriteGenerator;
 use Magento\CatalogUrlRewrite\Service\V1\StoreViewService;
 use Magento\Store\Model\Store;
+use Magento\Catalog\Model\Product\Visibility;
 
 /**
  * Class ProductUrlRewriteGenerator
@@ -98,6 +99,10 @@ private function getAnchorUrlRewriteGenerator()
      */
     public function generate(Product $product)
     {
+        if ($product->getVisibility() == Visibility::VISIBILITY_NOT_VISIBLE) {
+            return [];
+        }
+
         $this->product = $product;
         $storeId = $this->product->getStoreId();
 

app/code/Magento/CatalogUrlRewrite/Observer/AfterImportDataObserver.php

@@ -19,7 +19,7 @@
 use Magento\UrlRewrite\Model\OptionProvider;
 use Magento\UrlRewrite\Model\UrlFinderInterface;
 use Magento\Framework\Event\ObserverInterface;
-
+use Magento\Catalog\Model\Product\Visibility;
 /**
  * Class AfterImportDataObserver
  *
@@ -93,6 +93,7 @@ class AfterImportDataObserver implements ObserverInterface
         'url_key',
         'url_path',
         'name',
+        'visibility',
     ];
 
     /**
@@ -221,6 +222,9 @@ protected function setStoreToProduct(\Magento\Catalog\Model\Product $product, ar
      */
     protected function addProductToImport($product, $storeId)
     {
+        if ($product->getVisibility() == (string)Visibility::getOptionArray()[Visibility::VISIBILITY_NOT_VISIBLE]) {
+            return $this;
+        }
         if (!isset($this->products[$product->getId()])) {
             $this->products[$product->getId()] = [];
         }
@@ -321,6 +325,9 @@ protected function categoriesUrlRewriteGenerate()
             foreach ($productsByStores as $storeId => $product) {
                 foreach ($this->categoryCache[$productId] as $categoryId) {
                     $category = $this->import->getCategoryProcessor()->getCategoryById($categoryId);
+                    if ($category->getParentId() == Category::TREE_ROOT_ID) {
+                        continue;
+                    }
                     $requestPath = $this->productUrlPathGenerator->getUrlPathWithSuffix($product, $storeId, $category);
                     $urls[] = $this->urlRewriteFactory->create()
                         ->setEntityType(ProductUrlRewriteGenerator::ENTITY_TYPE)