Skip to content

Commit f02efd0

Browse files
committed
AC-1685: Fix Integration Tests to be compatible with PHP 8.1
- changes after code review
1 parent f1e19d8 commit f02efd0

File tree

8 files changed

+9
-27
lines changed

8 files changed

+9
-27
lines changed

app/code/Magento/Catalog/Model/ResourceModel/Product/Collection/ProductLimitation.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function offsetUnset($offset)
8282
}
8383

8484
/**
85-
* Returns Store ID.
85+
* Returns store ID.
8686
*
8787
* @return int|null
8888
* @since 101.0.0
@@ -104,7 +104,7 @@ public function getCategoryId()
104104
}
105105

106106
/**
107-
* Returns is category an anchor.
107+
* Check if the category is an anchor.
108108
*
109109
* @return int|null
110110
* @since 101.0.0
@@ -159,7 +159,7 @@ public function isUsingPriceIndex()
159159
}
160160

161161
/**
162-
* Sets 'Use Price' index flag.
162+
* Set 'use price index' offset.
163163
*
164164
* @param bool $value
165165
* @return void

lib/internal/Magento/Framework/App/RouterList.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ protected function getRouterInstance($routerId)
5555
}
5656

5757
/**
58-
* @inheritdoc
58+
* {@inheritDoc}
59+
*
60+
* @return RouterInterface
5961
*/
6062
#[\ReturnTypeWillChange]
6163
public function current()
@@ -73,7 +75,9 @@ public function next()
7375
}
7476

7577
/**
76-
* @inheritdoc
78+
* {@inheritDoc}
79+
*
80+
* @return string|int|null
7781
*/
7882
#[\ReturnTypeWillChange]
7983
public function key()

lib/internal/Magento/Framework/Config/CompositeFileIterator.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public function __construct(ReadFactory $readFactory, array $paths, FileIterator
3434
/**
3535
* @inheritDoc
3636
*/
37-
#[\ReturnTypeWillChange]
3837
public function rewind()
3938
{
4039
$this->existingIterator->rewind();
@@ -44,7 +43,6 @@ public function rewind()
4443
/**
4544
* @inheritDoc
4645
*/
47-
#[\ReturnTypeWillChange]
4846
public function current()
4947
{
5048
if ($this->existingIterator->valid()) {
@@ -57,7 +55,6 @@ public function current()
5755
/**
5856
* @inheritDoc
5957
*/
60-
#[\ReturnTypeWillChange]
6158
public function key()
6259
{
6360
if ($this->existingIterator->valid()) {
@@ -70,7 +67,6 @@ public function key()
7067
/**
7168
* @inheritDoc
7269
*/
73-
#[\ReturnTypeWillChange]
7470
public function next()
7571
{
7672
if ($this->existingIterator->valid()) {
@@ -83,7 +79,6 @@ public function next()
8379
/**
8480
* @inheritDoc
8581
*/
86-
#[\ReturnTypeWillChange]
8782
public function valid()
8883
{
8984
return $this->existingIterator->valid() || parent::valid();
@@ -100,7 +95,6 @@ public function toArray()
10095
/**
10196
* @inheritDoc
10297
*/
103-
#[\ReturnTypeWillChange]
10498
public function count()
10599
{
106100
return $this->existingIterator->count() + parent::count();

lib/internal/Magento/Framework/DB/Query/BatchIterator.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ public function __construct(
9292
*
9393
* @return Select
9494
*/
95-
#[\ReturnTypeWillChange]
9695
public function current()
9796
{
9897
if (null == $this->currentSelect) {
@@ -108,7 +107,6 @@ public function current()
108107
*
109108
* @return Select
110109
*/
111-
#[\ReturnTypeWillChange]
112110
public function next()
113111
{
114112
if (null == $this->currentSelect) {
@@ -131,7 +129,6 @@ public function next()
131129
*
132130
* @return int
133131
*/
134-
#[\ReturnTypeWillChange]
135132
public function key()
136133
{
137134
return $this->iteration;
@@ -142,7 +139,6 @@ public function key()
142139
*
143140
* @return bool
144141
*/
145-
#[\ReturnTypeWillChange]
146142
public function valid()
147143
{
148144
return $this->isValid;
@@ -153,7 +149,6 @@ public function valid()
153149
*
154150
* @return void
155151
*/
156-
#[\ReturnTypeWillChange]
157152
public function rewind()
158153
{
159154
$this->minValue = 0;

lib/internal/Magento/Framework/DB/Query/BatchRangeIterator.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ public function __construct(
110110
*
111111
* @return Select
112112
*/
113-
#[\ReturnTypeWillChange]
114113
public function current()
115114
{
116115
if (null === $this->currentSelect) {
@@ -127,7 +126,6 @@ public function current()
127126
*
128127
* @return int
129128
*/
130-
#[\ReturnTypeWillChange]
131129
public function key()
132130
{
133131
return $this->iteration;
@@ -141,7 +139,6 @@ public function key()
141139
*
142140
* @return Select
143141
*/
144-
#[\ReturnTypeWillChange]
145142
public function next()
146143
{
147144
if (null === $this->currentSelect) {
@@ -165,7 +162,6 @@ public function next()
165162
*
166163
* @return void
167164
*/
168-
#[\ReturnTypeWillChange]
169165
public function rewind()
170166
{
171167
$this->currentSelect = null;
@@ -179,7 +175,6 @@ public function rewind()
179175
*
180176
* @return bool
181177
*/
182-
#[\ReturnTypeWillChange]
183178
public function valid()
184179
{
185180
return $this->isValid;

lib/internal/Magento/Framework/Data/Collection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,6 @@ protected function _toOptionArray($valueField = 'id', $labelField = 'name', $add
780780
*
781781
* @return array
782782
*/
783-
#[\ReturnTypeWillChange]
784783
public function toOptionArray()
785784
{
786785
return $this->_toOptionArray();

lib/internal/Magento/Framework/Data/SearchResultIterator.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ public function __construct(AbstractSearchResult $searchResult, QueryInterface $
4141

4242
/**
4343
* @inheritdoc
44-
*
45-
* @return array|mixed
4644
*/
4745
#[\ReturnTypeWillChange]
4846
public function current()
@@ -62,8 +60,6 @@ public function next()
6260

6361
/**
6462
* @inheritdoc
65-
*
66-
* @return int|mixed
6763
*/
6864
#[\ReturnTypeWillChange]
6965
public function key()

lib/internal/Magento/Framework/Search/Response/QueryResponse.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ public function getIterator()
7272
/**
7373
* @inheritdoc
7474
*/
75-
#[\ReturnTypeWillChange]
7675
public function getAggregations()
7776
{
7877
return $this->aggregations;

0 commit comments

Comments
 (0)