ACP2E-3842: [Mainline]After applying ACP2E-3769_2.4.6-p9 - Deprecated Functionality: Implicit conversion from float

Author: soklymeach

app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php

@@ -208,10 +208,10 @@ private function validateSubSelectConditions(mixed $item): bool
      * @param mixed $item
      * @param mixed $attr
      * @param float $total
-     * @return float
+     * @return float|mixed
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
-    private function getBaseRowTotalForChildrenProduct(mixed $item, mixed $attr, float $total): float
+    private function getBaseRowTotalForChildrenProduct(mixed $item, mixed $attr, float $total): mixed
     {
         $hasValidChild = false;
         $useChildrenTotal = ($item->getProductType() == Type::TYPE_BUNDLE);

dev/tests/integration/testsuite/Magento/SalesRule/Model/Rule/Condition/Product/SubselectTest.php

@@ -0,0 +1,92 @@
+<?php
+/**
+ * Copyright 2025 Adobe
+ * All Rights Reserved.
+ */
+
+namespace Magento\SalesRule\Model\Rule\Condition\Product;
+
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Quote\Model\Quote;
+use Magento\SalesRule\Model\Rule\Condition\Product as SalesRuleProduct;
+use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Integration test for Subselect::validate() method returning true.
+ *
+ * @magentoAppArea frontend
+ * @magentoDbIsolation enabled
+ */
+class SubselectTest extends TestCase
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    /**
+     * @var Subselect
+     */
+    private $subselectCondition;
+
+    /**
+     * @var SalesRuleProduct
+     */
+    private $productCondition;
+
+    protected function setUp(): void
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+        $this->productCondition = $this->objectManager->create(SalesRuleProduct::class);
+        $this->subselectCondition = $this->objectManager->create(
+            Subselect::class,
+            [
+                'context' => $this->objectManager->get(\Magento\Rule\Model\Condition\Context::class),
+                'ruleConditionProduct' => $this->productCondition
+            ]
+        );
+    }
+
+    /**
+     * Test validate() method returning true for total quantity >= 2 with single shipping.
+     *
+     * @magentoDataFixture Magento/Catalog/_files/products.php
+     */
+    public function testValidateReturnsTrueForSufficientQuantity()
+    {
+        $this->subselectCondition->setData([
+            'attribute' => 'qty',
+            'operator' => '>=',
+            'value' => 2,
+            'aggregator' => 'all',
+        ]);
+        $productCondition = $this->objectManager->create(SalesRuleProduct::class);
+        $productCondition->setData([
+            'attribute' => 'sku',
+            'operator' => '==',
+            'value' => 'simple',
+        ]);
+        $this->subselectCondition->setConditions([$productCondition]);
+        $productRepository = $this->objectManager->create(\Magento\Catalog\Api\ProductRepositoryInterface::class);
+        $product = $productRepository->get('simple');
+        $product->setPrice(100.50);
+        $this->assertNotNull($product->getId());
+        $quote = $this->objectManager->create(Quote::class);
+        $quote->setStoreId(1)
+            ->setIsActive(true)
+            ->setIsMultiShipping(false)
+            ->setReservedOrderId('test_quote')
+            ->addProduct($product, 2);
+        $quote->collectTotals()->save();
+        $this->assertNotNull($quote->getId());
+        $this->assertNotEmpty($quote->getAllVisibleItems());
+        $quoteItem = $quote->getAllVisibleItems()[0];
+        $this->assertNotNull($quoteItem);
+        $this->assertNotNull($quoteItem->getProduct());
+        $this->assertEquals(2, $quoteItem->getQty());
+        $this->assertNotNull($quoteItem->getQuote());
+        $result = $this->subselectCondition->validate($quoteItem);
+        $this->assertTrue($result);
+    }
+}