MAGETWO-37672: Responsive Email Foundation

- Moved logo email ID to a constant
- Misc code cleanup

Author: Erik Hansen

app/code/Magento/Email/Model/AbstractTemplate.php

@@ -24,6 +24,11 @@ abstract class AbstractTemplate extends AbstractModel implements TemplateTypesIn
      */
     const DEFAULT_DESIGN_AREA = 'frontend';
 
+    /**
+     * Default path to email logo
+     */
+    const DEFAULT_LOGO_FILE_ID = 'Magento_Email::logo_email.png';
+
     /**
      * Email logo url
      *
@@ -368,7 +373,7 @@ public function getDefaultEmailLogo()
     {
         $designParams = $this->getDesignParams();
         return $this->assetRepo->getUrlWithParams(
-            'Magento_Email::logo_email.png',
+            self::DEFAULT_LOGO_FILE_ID,
             $designParams
         );
     }

app/code/Magento/Email/Test/Unit/Model/Template/FilterTest.php

@@ -76,7 +76,7 @@ class FilterTest extends \PHPUnit_Framework_TestCase
     private $backendUrlBuilder;
 
     /**
-     * @var \Pelago\Emogrifier|\PHPUnit_Framework_MockObject_MockObject
+     * @var \Pelago\Emogrifier
      */
     private $emogrifier;
 

app/code/Magento/Newsletter/Model/Template.php

@@ -232,7 +232,7 @@ protected function getFilterFactory()
      */
     public function isValidForSend()
     {
-        return !$this->_scopeConfig->isSetFlag(
+        return !$this->scopeConfig->isSetFlag(
             \Magento\Email\Model\Template::XML_PATH_SYSTEM_SMTP_DISABLE,
             \Magento\Store\Model\ScopeInterface::SCOPE_STORE
         ) && $this->getTemplateSenderName() && $this->getTemplateSenderEmail() && $this->getTemplateSubject();

app/code/Magento/Newsletter/Test/Unit/Model/TemplateTest.php

@@ -301,7 +301,7 @@ public function testGetProcessedTemplate($variables, $templateType, $storeId, $e
     /**
      * @return array
      */
-    public function getProcessedTemplateProvider()
+    public function getProcessedTemplateDataProvider()
     {
         return [
             'default' => [