MAGETWO-36376: Magento\Quote\Api\GuestCartItemRepository

 - refactor GuestCartItemRepository to use composition instead of inheritance
 - updated unit tests
 - removed saveForCustomer from guest interface and implementation
 - updated GuestCartTestHelper to allow magic method to be mocked

Author: Cari Spruiell

app/code/Magento/Quote/Api/GuestCartItemRepositoryInterface.php

@@ -49,16 +49,4 @@ public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem);
      * @throws \Magento\Framework\Exception\CouldNotSaveException The item could not be removed.
      */
     public function deleteById($cartId, $itemId);
-
-    /**
-     * Adds the specified item to the specified cart.
-     *
-     * @param int $customerId Customer ID.
-     * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem The item.
-     * @return \Magento\Quote\Api\Data\CartItemInterface Item.
-     * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist.
-     * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart.
-     * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid.
-     */
-    public function saveForCustomer($customerId, \Magento\Quote\Api\Data\CartItemInterface $cartItem);
 }

app/code/Magento/Quote/Model/GuestCart/GuestCartItemRepository.php

@@ -14,8 +14,13 @@
 /**
  * Cart Item repository class for guest carts.
  */
-class GuestCartItemRepository extends Repository implements \Magento\Quote\Api\GuestCartItemRepositoryInterface
+class GuestCartItemRepository implements \Magento\Quote\Api\GuestCartItemRepositoryInterface
 {
+    /**
+     * @var Repository
+     */
+    protected $repository;
+
     /**
      * @var QuoteIdMaskFactory
      */
@@ -24,19 +29,15 @@ class GuestCartItemRepository extends Repository implements \Magento\Quote\Api\G
     /**
      * Constructs a read service object.
      *
-     * @param \Magento\Quote\Model\QuoteRepository $quoteRepository
-     * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository
-     * @param \Magento\Quote\Api\Data\CartItemInterfaceFactory $itemDataFactory
+     * @param \Magento\Quote\Model\Quote\Item\Repository $repository
      * @param QuoteIdMaskFactory $quoteIdMaskFactory
      */
     public function __construct(
-        \Magento\Quote\Model\QuoteRepository $quoteRepository,
-        \Magento\Catalog\Api\ProductRepositoryInterface $productRepository,
-        \Magento\Quote\Api\Data\CartItemInterfaceFactory $itemDataFactory,
+        \Magento\Quote\Model\Quote\Item\Repository $repository,
         QuoteIdMaskFactory $quoteIdMaskFactory
     ) {
         $this->quoteIdMaskFactory = $quoteIdMaskFactory;
-        parent::__construct($quoteRepository, $productRepository, $itemDataFactory);
+        $this->repository = $repository;
     }
 
     /**
@@ -46,7 +47,7 @@ public function getList($cartId)
     {
         /** @var $quoteIdMask QuoteIdMask */
         $quoteIdMask = $this->quoteIdMaskFactory->create()->load($cartId, 'masked_id');
-        $cartItemList = parent::getList($quoteIdMask->getId());
+        $cartItemList = $this->repository->getList($quoteIdMask->getId());
         /** @var $item CartItemInterface */
         foreach ($cartItemList as $item) {
             $item->setQuoteId($quoteIdMask->getMaskedId());
@@ -62,7 +63,7 @@ public function save(\Magento\Quote\Api\Data\CartItemInterface $cartItem)
         /** @var $quoteIdMask QuoteIdMask */
         $quoteIdMask = $this->quoteIdMaskFactory->create()->load($cartItem->getQuoteId(), 'masked_id');
         $cartItem->setQuoteId($quoteIdMask->getId());
-        return parent::save($cartItem);
+        return $this->repository->save($cartItem);
     }
 
     /**
@@ -72,17 +73,17 @@ public function deleteById($cartId, $itemId)
     {
         /** @var $quoteIdMask QuoteIdMask */
         $quoteIdMask = $this->quoteIdMaskFactory->create()->load($cartId, 'masked_id');
-        return parent::deleteById($quoteIdMask->getId(), $itemId);
+        return $this->repository->deleteById($quoteIdMask->getId(), $itemId);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function saveForCustomer($customerId, \Magento\Quote\Api\Data\CartItemInterface $cartItem)
+    public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem)
     {
         /** @var $quoteIdMask QuoteIdMask */
         $quoteIdMask = $this->quoteIdMaskFactory->create()->load($cartItem->getQuoteId(), 'masked_id');
         $cartItem->setQuoteId($quoteIdMask->getId());
-        return parent::saveForCustomer($customerId, $cartItem);
+        return $this->repository->delete($cartItem);
     }
 }