MQE-478: Deliver Pangolins Sprint 11

- code review fixes

Author: imeron2433

dev/tests/acceptance/RoboFile.php

@@ -15,6 +15,8 @@ class RoboFile extends \Robo\Tasks
 
     /**
      * Duplicate the Example configuration files used to customize the Project for customization
+     *
+     * @return void
      */
     function cloneFiles()
     {
@@ -26,6 +28,8 @@ function cloneFiles()
     /**
      * Clone the Example configuration files
      * Build the Codeception project
+     *
+     * @return void
      */
     function buildProject()
     {
@@ -34,25 +38,32 @@ function buildProject()
     }
 
     /**
-     * Generate all Tests
+     * Generate all Tests command.
+     *
+     * @param string[] $opts
+     * @return void
      */
     function generateTests($opts = ['config' => null, 'env' => 'chrome'])
     {
-        require 'tests/functional/_bootstrap.php';
+        require 'tests'. DIRECTORY_SEPARATOR . 'functional' . DIRECTORY_SEPARATOR . '_bootstrap.php';
         \Magento\FunctionalTestingFramework\Util\TestGenerator::getInstance()->createAllCestFiles($opts['config'], $opts['env']);
         $this->say("Generate Tests Command Run");
     }
 
     /**
      * Generate a suite based on name(s) passed in as args
+     *
+     * @param string[] args
+     * @return void
+     * @throws Exception
      */
     function generateSuite(array $args)
     {
         if (empty($args)) {
             throw new Exception("Please provide suite name(s) after generate:suite command");
         }
 
-        require 'tests/functional/_bootstrap.php';
+        require 'tests'. DIRECTORY_SEPARATOR . 'functional' . DIRECTORY_SEPARATOR . '_bootstrap.php';
         $sg = \Magento\FunctionalTestingFramework\Suite\SuiteGenerator::getInstance();
 
         foreach ($args as $arg) {
@@ -62,6 +73,8 @@ function generateSuite(array $args)
 
     /**
      * Run all Functional tests using the Chrome environment
+     *
+     * @return void
      */
     function chrome()
     {
@@ -70,6 +83,8 @@ function chrome()
 
     /**
      * Run all Functional tests using the FireFox environment
+     *
+     * @return void
      */
     function firefox()
     {
@@ -78,6 +93,8 @@ function firefox()
 
     /**
      * Run all Functional tests using the PhantomJS environment
+     *
+     * @return void
      */
     function phantomjs()
     {
@@ -86,6 +103,8 @@ function phantomjs()
 
     /**
      * Run all Functional tests using the Chrome Headless environment
+     *
+     * @return void
      */
     function headless()
     {
@@ -94,7 +113,9 @@ function headless()
 
     /**
      * Run all Tests with the specified @group tag, excluding @group 'skip', using the Chrome environment
+     *
      * @param string $args
+     * @return void
      */
     function group($args = '')
     {
@@ -103,7 +124,9 @@ function group($args = '')
 
     /**
      * Run all Functional tests located under the Directory Path provided using the Chrome environment
+     *
      * @param string $args
+     * @return void
      */
     function folder($args = '')
     {
@@ -112,6 +135,8 @@ function folder($args = '')
 
     /**
      * Run all Tests marked with the @group tag 'example', using the Chrome environment
+     *
+     * @return void
      */
     function example()
     {
@@ -120,6 +145,8 @@ function example()
 
     /**
      * Generate the HTML for the Allure report based on the Test XML output - Allure v1.4.X
+     *
+     * @return void
      */
     function allure1Generate()
     {
@@ -128,6 +155,8 @@ function allure1Generate()
 
     /**
      * Generate the HTML for the Allure report based on the Test XML output - Allure v2.3.X
+     *
+     * @return void
      */
     function allure2Generate()
     {
@@ -136,6 +165,8 @@ function allure2Generate()
 
     /**
      * Open the HTML Allure report - Allure v1.4.xX
+     *
+     * @return void
      */
     function allure1Open()
     {
@@ -144,6 +175,8 @@ function allure1Open()
 
     /**
      * Open the HTML Allure report - Allure v2.3.X
+     *
+     * @return void
      */
     function allure2Open()
     {
@@ -152,6 +185,8 @@ function allure2Open()
 
     /**
      * Generate and open the HTML Allure report - Allure v1.4.X
+     *
+     * @return void
      */
     function allure1Report()
     {
@@ -164,6 +199,8 @@ function allure1Report()
 
     /**
      * Generate and open the HTML Allure report - Allure v2.3.X
+     *
+     * @return void
      */
     function allure2Report()
     {
@@ -176,6 +213,8 @@ function allure2Report()
 
     /**
      * Run the Pre-Install Check Script
+     *
+     * @return void
      */
     function preInstall()
     {

dev/tests/acceptance/pre-install.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
+// @codingStandardsIgnoreStart
 class CliColors {
     private $foreground_colors = array();
     private $background_colors = array();
@@ -384,4 +384,5 @@ public function verifyVersion($softwareName, $installedVersion, $supportedVersio
     }
 }
 
-$preCheck = new PreInstallCheck();
+$preCheck = new PreInstallCheck();
+// @codingStandardsIgnoreEnd

dev/tests/acceptance/tests/_suite/sampleSuite.xml

@@ -1,4 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
 <suites xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Suite/etc/suiteSchema.xsd">
     <suite name="mySuite">
         <before>
@@ -20,4 +27,4 @@
             <group name="testGroup"/>
         </exclude>
     </suite>
-</suites>
+</suites>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Customer/Data/CustomerData.xml

@@ -47,6 +47,5 @@
     <entity name="Simple_US_Customer_For_Update" type="customer">
         <var key="id" entityKey="id" entityType="customer"/>
         <data key="firstname">Jane</data>
-
     </entity>
 </config>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/SampleTests/Cest/UpdateSimpleProductByApiCest.xml

@@ -1,5 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Test XML Example -->
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
     <cest name="UpdateSimpleProductByApiCest">
         <annotations>
@@ -18,12 +24,11 @@
             </createData>
             <updateData mergeKey="productHandle" entity="NewSimpleProduct" createDataKey="originalProductHandle">
             </updateData>
-            
         </before>
         <after>
             <deleteData mergeKey="delete" createDataKey="productHandle"/>
         </after>
         <test name="UpdateSimpleProductByApiTest">
         </test>
     </cest>
-</config>
+</config>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Wishlist/Cest/StorefrontDeletePersistedWishlistCest.xml

@@ -1,5 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Test XML Example -->
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
     <cest name="StorefrontDeletePersistedWishlistCest">
         <annotations>
@@ -48,4 +54,4 @@
             <see mergeKey="seeEmptyWishlist" userInput="You have no items in your wish list" selector="{{StorefrontCustomerWishlistSection.emptyWishlistText}}"/>
         </test>
     </cest>
-</config>
+</config>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Wishlist/Data/WishlistData.xml

@@ -1,4 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
 
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/DataGenerator/etc/dataProfileSchema.xsd">
     <entity name="Wishlist" type="wishlist">

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Wishlist/Metadata/wishlist-meta.xml

@@ -1,4 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
 
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/DataGenerator/etc/dataOperation.xsd">
@@ -9,4 +15,4 @@
         <field key="customer_email">string</field>
         <field key="customer_password">string</field>
     </operation>
-</config>
+</config>