MAGETWO-92931: HTML entities in product name do not display properly in breadcrumb

cpartica · cpartica · commit eb8aa49351cc · 2018-07-25T13:38:55.000-05:00
- escape html, and the frontend will safely render html
diff --git a/app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php b/app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php
@@ -106,7 +106,7 @@ public function getJsonConfiguration() : string
                 'breadcrumbs' => [
                     'categoryUrlSuffix' => $this->getCategoryUrlSuffix(),
                     'userCategoryPathInUrl' => (int)$this->isCategoryUsedInProductUrl(),
-                    'product' => $this->getProductName()
+                    'product' => $this->escaper->escapeHtml($this->getProductName())
                 ]
             ],
             JSON_HEX_TAG

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function getJsonConfiguration() : string`
`106`	`106`	`'breadcrumbs' => [`
`107`	`107`	`'categoryUrlSuffix' => $this->getCategoryUrlSuffix(),`
`108`	`108`	`'userCategoryPathInUrl' => (int)$this->isCategoryUsedInProductUrl(),`
`109`		`- 'product' => $this->getProductName()`
	`109`	`+ 'product' => $this->escaper->escapeHtml($this->getProductName())`
`110`	`110`	`]`
`111`	`111`	`],`
`112`	`112`	`JSON_HEX_TAG`