Skip to content

Commit eb53071

Browse files
committed
MC-18514: API functional test to cover filterable custom attributes in layered navigation
- review comments
1 parent 6ff0c12 commit eb53071

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,11 @@ public function testFilterProductsByDropDownCustomAttribute()
302302
]
303303
);
304304
}
305-
private function reIndexAndCleanCache()
305+
306+
/**
307+
* @return void
308+
*/
309+
private function reIndexAndCleanCache() : void
306310
{
307311
$objectManager = Bootstrap::getObjectManager();
308312
$indexer = $objectManager->create(Indexer::class);
@@ -1558,7 +1562,7 @@ public function testFilterByExactSkuAndSortByPriceDesc()
15581562
*/
15591563
public function testProductBasicFullTextSearchQuery()
15601564
{
1561-
$this->reIndexAndCleanCache();
1565+
$this->reIndexAndCleanCache();
15621566
$textToSearch = 'blue';
15631567
$query
15641568
=<<<QUERY

dev/tests/integration/testsuite/Magento/Catalog/_files/products_for_relevance_sorting.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@
6565
->setSku('navy-striped-shoes')
6666
->setPrice(40)
6767
->setWeight(8)
68-
->setDescription('Blue striped flip flops at <b>one</b>')
68+
->setDescription('blue striped flip flops at <b>one</b>')
6969
->setMetaTitle('navy blue colored shoes meta title')
7070
->setMetaKeyword('blue, navy, striped , women, kids')
71-
->setMetaDescription('blue', 'shoes women kids meta description')
71+
->setMetaDescription('blue shoes women kids meta description')
7272
->setStockData(['use_config_manage_stock' => 0])
7373
->setVisibility(\Magento\Catalog\Model\Product\Visibility::VISIBILITY_BOTH)
7474
->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
@@ -96,7 +96,7 @@
9696

9797
/** @var \Magento\Catalog\Model\Product $greyProduct */
9898
$greyProduct = $productRepository->get('grey_shorts');
99-
$greyProduct->setDescription('Description with blue lines');
99+
$greyProduct->setDescription('Description with Blue lines');
100100
$productRepository->save($greyProduct);
101101

102102
$skus = ['green_socks', 'white_shorts','red_trousers','blue_briefs','grey_shorts',

0 commit comments

Comments
 (0)