Skip to content

Commit eb2a9b0

Browse files
author
Yu Tang
committed
MAGETWO-44491: [TD] ActionInterface has Method dispatch() Instead of execute()
- Fix test failures
1 parent 489db08 commit eb2a9b0

File tree

3 files changed

+5
-3
lines changed
  • app/code/Magento/Indexer/Test/Unit/Controller/Adminhtml/Indexer
  • dev/tests
    • api-functional/_files/Magento/TestModule1/Controller
    • integration/testsuite/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment

3 files changed

+5
-3
lines changed

app/code/Magento/Indexer/Test/Unit/Controller/Adminhtml/Indexer/ListActionTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class ListActionTest extends \PHPUnit_Framework_TestCase
6060

6161
/**
6262
* Set up test
63+
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
6364
*/
6465
protected function setUp()
6566
{

dev/tests/api-functional/_files/Magento/TestModule1/Controller/CookieTester.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ abstract protected function executeInternal(RequestInterface $request);
7171
*/
7272
public function execute(RequestInterface $request)
7373
{
74-
$result = $this->execute($request);
74+
$result = $this->executeInternal($request);
7575
return $result ? $result : $this->_response;
7676
}
7777
}

dev/tests/integration/testsuite/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment/PlaceTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class PlaceTest extends \Magento\TestFramework\TestCase\AbstractBackendControlle
1313
/**
1414
* Test requestToAuthorizenetData returning
1515
*/
16-
public function testExecuteAuthorizenetDataReturning()
16+
public function testExecuteInternalAuthorizenetDataReturning()
1717
{
1818
$requestToAuthorizenetData = ['Authorizenet' => 'data'];
1919

@@ -56,11 +56,12 @@ public function testExecuteAuthorizenetDataReturning()
5656
]
5757
);
5858

59+
/** @var \Magento\Authorizenet\Controller\Adminhtml\Authorizenet\Directpost\Payment\PlaceTesting $controller */
5960
$controller = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
6061
'Magento\Authorizenet\Controller\Adminhtml\Authorizenet\Directpost\Payment\PlaceTesting',
6162
['context' => $context]
6263
);
63-
$controller->execute();
64+
$controller->executeInternal();
6465
$this->assertContains(json_encode($requestToAuthorizenetData), $this->getResponse()->getBody());
6566
}
6667

0 commit comments

Comments
 (0)