MAGETWO-86323: Create XSD tests

Author: cpartica

app/code/Magento/GraphQl/Test/Unit/Model/Config/XsdTest.php

@@ -7,26 +7,25 @@
 
 class XsdTest extends \PHPUnit\Framework\TestCase
 {
-
     /**
      * Path to xsd schema file
      * @var string
      */
-    protected $_xsdSchema;
+    private $xsdSchema;
 
     /**
      * @var \Magento\Framework\TestFramework\Unit\Utility\XsdValidator
      */
-    protected $_xsdValidator;
+    private $xsdValidator;
 
     protected function setUp()
     {
         if (!function_exists('libxml_set_external_entity_loader')) {
             $this->markTestSkipped('Skipped on HHVM. Will be fixed in MAGETWO-45033');
         }
         $urnResolver = new \Magento\Framework\Config\Dom\UrnResolver();
-        $this->_xsdSchema = $urnResolver->getRealPath('urn:magento:module:Magento_GraphQl:etc/graphql.xsd');
-        $this->_xsdValidator = new \Magento\Framework\TestFramework\Unit\Utility\XsdValidator();
+        $this->xsdSchema = $urnResolver->getRealPath('urn:magento:module:Magento_GraphQl:etc/graphql.xsd');
+        $this->xsdValidator = new \Magento\Framework\TestFramework\Unit\Utility\XsdValidator();
     }
 
     /**
@@ -36,14 +35,14 @@ protected function setUp()
      */
     public function testSchemaCorrectlyIdentifiesInvalidXml($xmlString, $expectedError)
     {
-        $actualError = $this->_xsdValidator->validate($this->_xsdSchema, $xmlString);
+        $actualError = $this->xsdValidator->validate($this->xsdSchema, $xmlString);
         $this->assertEquals($expectedError, $actualError);
     }
 
     public function testSchemaCorrectlyIdentifiesValidXml()
     {
         $xmlString = file_get_contents(__DIR__ . '/_files/graphql_simple_configurable.xml');
-        $actualResult = $this->_xsdValidator->validate($this->_xsdSchema, $xmlString);
+        $actualResult = $this->xsdValidator->validate($this->xsdSchema, $xmlString);
         $this->assertEmpty($actualResult);
     }
 

app/code/Magento/GraphQl/Test/Unit/Model/Config/_files/invalidGraphQlXmlArray.php

@@ -181,7 +181,7 @@
             <argument xsi:type="SortArgument" name="Sort"/></field>
          </type></config>',
         [
-            "Element 'argument': The attribute 'baseType' is required but missing.\nLine: 7\n"
+            "Element 'argument': The attribute 'baseType' is required but missing.\nLine: 11\n"
         ],
     ],
     'invalid_argument_FilterArgument_with missing baseType attribute' => [

dev/tests/integration/testsuite/Magento/Framework/GraphQl/Config/ConverterTest.php

@@ -10,12 +10,12 @@ class ConverterTest extends \PHPUnit\Framework\TestCase
     /**
      * @var \Magento\Framework\GraphQl\Config\Converter
      */
-    protected $graphQlConverter;
+    private $graphQlConverter;
 
     /**
      * @var \DOMDocument
      */
-    protected $source;
+    private $source;
 
     protected function setUp()
     {
@@ -27,10 +27,8 @@ protected function setUp()
     /**
      * @return void
      */
-
     public function testConvert()
     {
-        $actualOutput = [];
         $this->source= new \DOMDocument();
         $this->source->load(__DIR__ . '../../_files/input_graphql.xml');
         $actualOutput = $this->graphQlConverter->convert($this->source);

dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/output_graphql.php

@@ -4,7 +4,6 @@
  * See COPYING.txt for license details.
  */
 return [
-
     [
         "Query" =>
             [
@@ -132,5 +131,4 @@
               ]
 
     ]
-
 ];