ACP2E-2978: Saving product by admin user with different role scope overwrites/deletes existing Related product information in the product

Author: glanujnehra

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -302,11 +302,9 @@ protected function setProductLinks(Product $product)
             unset($linkTypes[$productLink->getLinkType()]);
         }
 
-        $isReadOnlyUpSellItems = false;
         foreach ($linkTypes as $linkType => $readonly) {
-            $isReadOnlyRelatedItems = $readonly && $linkType === 'related' ||
-                ($isReadOnlyUpSellItems = $readonly && $linkType === 'upsell');
-            if ($isReadOnlyRelatedItems && $isReadOnlyUpSellItems) {
+            $isReadOnlyLinks = $readonly && in_array($linkType, ['upsell', 'related']);
+            if ($isReadOnlyLinks) {
                 $productLinks = null;
                 break;
             } else {