🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #18967: fixed - Magento 2.2.6 Default values are not rendering on Wishlist product edit page (by @webkul-ratnesh)
 - #18873: [Backport] Prevent exception when option text converts to false (by @gelanivishal)
 - #18875: [Backport] Sections LESS mixins: fix the issue with missing rules and incorrect default variables (by @gelanivishal)


Fixed GitHub Issues:
 - #18555: Magento 2.2.6 Default values are not rendering on Wishlist product edit page. (reported by @kirtinariya1) has been fixed in #18967 by @webkul-ratnesh in 2.2-develop branch
   Related commits:
     1. 2bb0329

 - #13083: OptionManagement.validateOption throws NoSuchEntityException for "0" option label (reported by @rzinnatullin) has been fixed in #18873 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. 06ca13a

 - #18729: Bug in "_sections.less" mixins: missing rules and incorrect default variables (reported by @dmytro-ch) has been fixed in #18875 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. 999e79f
     2. 5333810

Author: magento-engcom-team

app/code/Magento/ConfigurableProduct/view/frontend/web/js/options-updater.js

@@ -61,6 +61,7 @@ define([
             this.setProductOptions(cartData());
             this.updateOptions();
         }.bind(this));
+        this.updateOptions();
     },
 
     /**

app/code/Magento/Eav/Model/Entity/Attribute/OptionManagement.php

@@ -132,7 +132,7 @@ public function getItems($entityType, $attributeCode)
      */
     protected function validateOption($attribute, $optionId)
     {
-        if (!$attribute->getSource()->getOptionText($optionId)) {
+        if ($attribute->getSource()->getOptionText($optionId) === false) {
             throw new NoSuchEntityException(
                 __('Attribute %1 does not contain option with Id %2', $attribute->getAttributeCode(), $optionId)
             );

lib/web/css/source/lib/_sections.less

@@ -49,16 +49,16 @@
     @_tab-control-color: @tab-control__color,
     @_tab-control-text-decoration: @tab-control__text-decoration,
 
-    @_tab-control-color-visited: @tab-control__color,
-    @_tab-control-text-decoration-visited: @tab-control__text-decoration,
+    @_tab-control-color-visited: @tab-control__visited__color,
+    @_tab-control-text-decoration-visited: @tab-control__visited__text-decoration,
 
     @_tab-control-background-color-hover: @tab-control__hover__background-color,
     @_tab-control-color-hover: @tab-control__hover__color,
-    @_tab-control-text-decoration-hover: @tab-control__text-decoration,
+    @_tab-control-text-decoration-hover: @tab-control__hover__text-decoration,
 
     @_tab-control-background-color-active: @tab-control__active__background-color,
     @_tab-control-color-active: @tab-control__active__color,
-    @_tab-control-text-decoration-active: @tab-control__text-decoration,
+    @_tab-control-text-decoration-active: @tab-control__active__text-decoration,
 
     @_tab-control-height: @tab-control__height,
     @_tab-control-margin-right: @tab-control__margin-right,
@@ -121,6 +121,7 @@
         &.active > .switch:hover {
             .lib-css(background, @_tab-control-background-color-active);
             .lib-css(color, @_tab-control-color-active);
+            .lib-css(text-decoration, @_tab-control-text-decoration-active);
         }
 
         &.active > .switch,
@@ -200,8 +201,8 @@
     @_accordion-control-color: @accordion-control__color,
     @_accordion-control-text-decoration: @accordion-control__text-decoration,
 
-    @_accordion-control-color-visited: @accordion-control__color,
-    @_accordion-control-text-decoration-visited: @accordion-control__text-decoration,
+    @_accordion-control-color-visited: @accordion-control__visited__color,
+    @_accordion-control-text-decoration-visited: @accordion-control__visited__text-decoration,
 
     @_accordion-control-background-color-hover: @accordion-control__hover__background-color,
     @_accordion-control-color-hover: @accordion-control__hover__color,
@@ -275,6 +276,8 @@
         &.active > .switch:focus,
         &.active > .switch:hover {
             .lib-css(background, @_accordion-control-background-color-active);
+            .lib-css(color, @_accordion-control-color-active);
+            .lib-css(text-decoration, @_accordion-control-text-decoration-active);
             .lib-css(padding-bottom, @_accordion-control-padding-bottom);
         }
     }

lib/web/css/source/lib/variables/_sections.less

@@ -40,6 +40,9 @@
 @tab-control__active__color: @text__color;
 @tab-control__active__text-decoration: @tab-control__text-decoration;
 
+@tab-control__visited__color: @tab-control__color;
+@tab-control__visited__text-decoration: @tab-control__text-decoration;
+
 @tab-content__background-color: @tab-control__active__background-color;
 @tab-content__border-top-status: false;
 @tab-content__border: @tab-control__border-width solid @tab-control__border-color;
@@ -72,8 +75,8 @@
 @accordion-control__padding-bottom: @tab-control__padding-bottom;
 @accordion-control__padding-left: @accordion-control__padding-right;
 
-@accordion-control__visited__color: @accordion-control__color;
-@accordion-control__visited__text-decoration: @accordion-control__text-decoration;
+@accordion-control__visited__color: @tab-control__visited__color;
+@accordion-control__visited__text-decoration: @tab-control__visited__text-decoration;
 
 @accordion-control__hover__background-color: @tab-control__hover__background-color;
 @accordion-control__hover__color: @tab-control__hover__color;