Merge pull request #424 from magento-mpi/MAGETWO-32931

[MPI]  Accepting and Rejecting Transactions Marked as "Held for Review" by Gateway

Author: vpelipenko

app/code/Magento/Payment/Model/Method/Adapter.php

@@ -366,6 +366,7 @@ public function order(InfoInterface $payment, $amount)
             $payment,
             ['amount' => $amount]
         );
+
         return $this;
     }
 
@@ -379,6 +380,7 @@ public function authorize(InfoInterface $payment, $amount)
             $payment,
             ['amount' => $amount]
         );
+
         return $this;
     }
 
@@ -406,6 +408,7 @@ public function refund(InfoInterface $payment, $amount)
             $payment,
             ['amount' => $amount]
         );
+
         return $this;
     }
 
@@ -418,6 +421,7 @@ public function cancel(InfoInterface $payment)
             'cancel',
             $payment
         );
+
         return $this;
     }
 
@@ -430,6 +434,7 @@ public function void(InfoInterface $payment)
             'void',
             $payment
         );
+
         return $this;
     }
 
@@ -442,6 +447,7 @@ public function acceptPayment(InfoInterface $payment)
             'accept_payment',
             $payment
         );
+
         return $this;
     }
 
@@ -454,7 +460,8 @@ public function denyPayment(InfoInterface $payment)
             'deny_payment',
             $payment
         );
-        return false;
+
+        return $this;
     }
 
     /**

app/code/Magento/Sales/Model/Order/Payment.php

@@ -1020,9 +1020,15 @@ public function deny($isOnline = true)
     {
         $transactionId = $isOnline ? $this->getLastTransId() : $this->getTransactionId();
 
-        $result = $isOnline ?
-            $this->getMethodInstance()->setStore($this->getOrder()->getStoreId())->denyPayment($this) :
-            (bool)$this->getNotificationResult();
+        if ($isOnline) {
+            /** @var \Magento\Payment\Model\Method\AbstractMethod $method */
+            $method = $this->getMethodInstance();
+            $method->setStore($this->getOrder()->getStoreId());
+
+            $result = $method->denyPayment($this);
+        } else {
+            $result = (bool)$this->getNotificationResult();
+        }
 
         if ($result) {
             $invoice = $this->_getInvoiceForTransactionId($transactionId);