Skip to content

Commit e8f1369

Browse files
committed
#631 Rename qty by quantity
Rename CartItemQuantityInput by CartItemUpdateQuantityInput Rename CartItemInput by CartItemQuantityInput Adapt tests
1 parent ae611f6 commit e8f1369

22 files changed

+58
-58
lines changed

app/code/Magento/ConfigurableProductGraphQl/etc/schema.graphqls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ type AddConfigurableProductsToCartOutput {
4949
}
5050

5151
input ConfigurableProductCartItemInput {
52-
data: CartItemInput!
52+
data: CartItemQuantityInput!
5353
variant_sku: String!
5454
customizable_options:[CustomizableOptionInput!]
5555
}

app/code/Magento/QuoteGraphQl/Model/Cart/AddSimpleProductToCart.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ private function extractSku(array $cartItemData): string
121121
*/
122122
private function extractQty(array $cartItemData): float
123123
{
124-
$qty = $this->arrayManager->get('data/qty', $cartItemData);
124+
$qty = $this->arrayManager->get('data/quantity', $cartItemData);
125125
if (!isset($qty)) {
126-
throw new GraphQlInputException(__('Missing key "qty" in cart item data'));
126+
throw new GraphQlInputException(__('Missing key "quantity" in cart item data'));
127127
}
128128
return (float)$qty;
129129
}

app/code/Magento/QuoteGraphQl/Model/Resolver/CartItems.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
3838

3939
$itemsData[] = [
4040
'id' => $cartItem->getItemId(),
41-
'qty' => $cartItem->getQty(),
41+
'quantity' => $cartItem->getQty(),
4242
'product' => $productData,
4343
'model' => $cartItem,
4444
];

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ input AddSimpleProductsToCartInput {
3131
}
3232

3333
input SimpleProductCartItemInput {
34-
data: CartItemInput!
34+
data: CartItemQuantityInput!
3535
customizable_options:[CustomizableOptionInput!]
3636
}
3737

@@ -41,13 +41,13 @@ input AddVirtualProductsToCartInput {
4141
}
4242

4343
input VirtualProductCartItemInput {
44-
data: CartItemInput!
44+
data: CartItemQuantityInput!
4545
customizable_options:[CustomizableOptionInput!]
4646
}
4747

48-
input CartItemInput {
48+
input CartItemQuantityInput {
4949
sku: String!
50-
qty: Float!
50+
quantity: Float!
5151
}
5252

5353
input CustomizableOptionInput {
@@ -62,10 +62,10 @@ input ApplyCouponToCartInput {
6262

6363
input UpdateCartItemsInput {
6464
cart_id: String!
65-
cart_items: [CartItemQuantityInput!]!
65+
cart_items: [CartItemUpdateQuantityInput!]!
6666
}
6767

68-
input CartItemQuantityInput {
68+
input CartItemUpdateQuantityInput {
6969
cart_item_id: Int!
7070
quantity: Float!
7171
}
@@ -297,7 +297,7 @@ type VirtualCartItem implements CartItemInterface @doc(description: "Virtual Car
297297

298298
interface CartItemInterface @typeResolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\CartItemTypeResolver") {
299299
id: String!
300-
qty: Float!
300+
quantity: Float!
301301
product: ProductInterface!
302302
}
303303

dev/tests/api-functional/testsuite/Magento/GraphQl/CatalogInventory/AddProductToCartTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty) : string
9797
cartItems: [
9898
{
9999
data: {
100-
qty: $qty
100+
quantity: $qty
101101
sku: "$sku"
102102
}
103103
}
@@ -106,7 +106,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty) : string
106106
) {
107107
cart {
108108
items {
109-
qty
109+
quantity
110110
}
111111
}
112112
}

dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function testAddConfigurableProductToCart()
4444
$response = $this->graphQlMutation($query);
4545

4646
$cartItems = $response['addConfigurableProductsToCart']['cart']['items'];
47-
self::assertEquals($qty, $cartItems[0]['qty']);
47+
self::assertEquals($qty, $cartItems[0]['quantity']);
4848
self::assertEquals($variantSku, $cartItems[0]['product']['sku']);
4949
}
5050

@@ -97,7 +97,7 @@ private function getQuery(string $maskedQuoteId, string $variantSku, int $qty):
9797
{
9898
variant_sku: "{$variantSku}"
9999
data: {
100-
qty: {$qty}
100+
quantity: {$qty}
101101
sku: "{$variantSku}"
102102
}
103103
}
@@ -107,7 +107,7 @@ private function getQuery(string $maskedQuoteId, string $variantSku, int $qty):
107107
cart {
108108
items {
109109
id
110-
qty
110+
quantity
111111
product {
112112
name
113113
sku

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductWithCustomOptionsToCartTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function testAddSimpleProductWithOptions()
6262
cartItems: [
6363
{
6464
data: {
65-
qty: $qty
65+
quantity: $qty
6666
sku: "$sku"
6767
},
6868
customizable_options: $queryCustomizableOptions
@@ -121,7 +121,7 @@ public function testAddSimpleProductWithNoRequiredOptionsSet()
121121
cartItems: [
122122
{
123123
data: {
124-
qty: $qty
124+
quantity: $qty
125125
sku: "$sku"
126126
}
127127
}

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddVirtualProductWithCustomOptionsToCartTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function testAddVirtualProductWithOptions()
6262
cartItems: [
6363
{
6464
data: {
65-
qty: $qty
65+
quantity: $qty
6666
sku: "$sku"
6767
},
6868
customizable_options: $queryCustomizableOptions
@@ -121,7 +121,7 @@ public function testAddVirtualProductWithNoRequiredOptionsSet()
121121
cartItems: [
122122
{
123123
data: {
124-
qty: $qty
124+
quantity: $qty
125125
sku: "$sku"
126126
}
127127
}

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/AddSimpleProductToCartTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testAddSimpleProductToCart()
4949
$response = $this->graphQlMutation($query, [], '', $this->getHeaderMap());
5050

5151
self::assertArrayHasKey('cart', $response['addSimpleProductsToCart']);
52-
self::assertEquals($qty, $response['addSimpleProductsToCart']['cart']['items'][0]['qty']);
52+
self::assertEquals($qty, $response['addSimpleProductsToCart']['cart']['items'][0]['quantity']);
5353
self::assertEquals($sku, $response['addSimpleProductsToCart']['cart']['items'][0]['product']['sku']);
5454
}
5555

@@ -142,7 +142,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty): string
142142
cartItems: [
143143
{
144144
data: {
145-
qty: {$qty}
145+
quantity: {$qty}
146146
sku: "{$sku}"
147147
}
148148
}
@@ -151,7 +151,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty): string
151151
cart {
152152
items {
153153
id
154-
qty
154+
quantity
155155
product {
156156
sku
157157
}

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/AddVirtualProductToCartTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testAddVirtualProductToCart()
4949
$response = $this->graphQlMutation($query, [], '', $this->getHeaderMap());
5050

5151
self::assertArrayHasKey('cart', $response['addVirtualProductsToCart']);
52-
self::assertEquals($qty, $response['addVirtualProductsToCart']['cart']['items'][0]['qty']);
52+
self::assertEquals($qty, $response['addVirtualProductsToCart']['cart']['items'][0]['quantity']);
5353
self::assertEquals($sku, $response['addVirtualProductsToCart']['cart']['items'][0]['product']['sku']);
5454
}
5555

@@ -142,7 +142,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty): string
142142
cartItems: [
143143
{
144144
data: {
145-
qty: {$qty}
145+
quantity: {$qty}
146146
sku: "{$sku}"
147147
}
148148
}
@@ -151,7 +151,7 @@ private function getQuery(string $maskedQuoteId, string $sku, int $qty): string
151151
cart {
152152
items {
153153
id
154-
qty
154+
quantity
155155
product {
156156
sku
157157
}

0 commit comments

Comments
 (0)