Skip to content

Commit e8daab5

Browse files
committed
[ACQE-7378]Login as customer opt-in checkbox not translatable
Fixed review comments
1 parent 655ed0a commit e8daab5

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

app/code/Magento/LoginAsCustomer/Test/Mftf/Section/AdminCustomerConfigSection.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313
<element name="enableExtensionLabel" type="text" selector="//span[contains(text(),'Enable Extension') and contains(@data-config-scope,'[GLOBAL]')]" timeout="30"/>
1414
<element name="disablePageCacheLabel" type="text" selector="//span[contains(text(),'Disable Page Cache For Admin User') and contains(@data-config-scope,'[GLOBAL]')]" timeout="30"/>
1515
<element name="storeViewToLoginToLabel" type="text" selector="//span[contains(text(),'Store To Login To') and contains(@data-config-scope,'[GLOBAL]')]" timeout="30"/>
16-
<element name="TitleForLoginAsCustomerOptInCheckbox" type="text" selector="//span[normalize-space()='Title for Login as Customer opt-in checkbox']"/>
16+
<element name="TitleForLoginAsCustomer" type="text" selector="//span[normalize-space()='{{option}}']" parameterized="true"/>
1717
<element name="LoginAsCustomerOptInCheckboxTextField" type="text" selector="//tr[@id='row_login_as_customer_general_shopping_assistance_checkbox_title']//td[@class='value']"/>
18-
<element name="TitleForLoginAsCustomerCheckboxToolTip" type="text" selector="//span[normalize-space()='Login as Customer checkbox tooltip']"/>
1918
<element name="LoginAsCustomerCheckboxToolTipTextField" type="text" selector="//tr[@id='row_login_as_customer_general_shopping_assistance_checkbox_tooltip']//td[@class='value']"/>
2019
</section>
2120
</sections>

app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerOptInCheckboxNotTranslatableTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@
2626
</after>
2727
<amOnPage url="{{AdminLoginAsCustomerConfigPage.url}}" stepKey="navigateToLoginAsCustomerConfigSection"/>
2828
<!--Look for fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip"-->
29-
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomerOptInCheckbox}}" stepKey="TitleForLoginAsCustomerOptInCheckbox"/>
29+
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomer('Title for Login as Customer opt-in checkbox')}}" stepKey="TitleForLoginAsCustomerOptInCheckbox"/>
3030
<waitForElementVisible selector="{{AdminCustomerConfigSection.LoginAsCustomerOptInCheckboxTextField}}" stepKey="LoginAsCustomerOptInCheckboxTextField"/>
31-
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomerCheckboxToolTip}}" stepKey="TitleForLoginAsCustomerCheckboxToolTip"/>
31+
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomer('Login as Customer checkbox tooltip')}}" stepKey="TitleForLoginAsCustomerCheckboxToolTip"/>
3232
<waitForElementVisible selector="{{AdminCustomerConfigSection.LoginAsCustomerCheckboxToolTipTextField}}" stepKey="LoginAsCustomerCheckboxToolTipTextField"/>
3333
<!--Switch to Default Store view-->
3434
<actionGroup ref="SwitchToTheNewStoreViewActionGroup" stepKey="selectDefaultStoreView">
3535
<argument name="storeViewName" value="Default Store View"/>
3636
</actionGroup>
3737
<!--Look for fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip"-->
38-
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomerOptInCheckbox}}" stepKey="TitleForLoginAsCustomerOptInCheckboxInDefaultStoreView"/>
38+
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomer('Title for Login as Customer opt-in checkbox')}}" stepKey="TitleForLoginAsCustomerOptInCheckboxInDefaultStoreView"/>
3939
<waitForElementVisible selector="{{AdminCustomerConfigSection.LoginAsCustomerOptInCheckboxTextField}}" stepKey="LoginAsCustomerOptInCheckboxTextFieldInDefaultStoreView"/>
40-
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomerCheckboxToolTip}}" stepKey="TitleForLoginAsCustomerCheckboxToolTipInDefaultStoreView"/>
40+
<waitForElementVisible selector="{{AdminCustomerConfigSection.TitleForLoginAsCustomer('Login as Customer checkbox tooltip')}}" stepKey="TitleForLoginAsCustomerCheckboxToolTipInDefaultStoreView"/>
4141
<waitForElementVisible selector="{{AdminCustomerConfigSection.LoginAsCustomerCheckboxToolTipTextField}}" stepKey="LoginAsCustomerCheckboxToolTipTextFieldInDefaultStoreView"/>
4242
</test>
4343
</tests>

0 commit comments

Comments
 (0)