🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #13563: #11252: fix adminhtml file attribute edit form (by @Mkennethsmith)
 - #13528: Fix for #12081: missing translations in the js-translations.json (by @mattijv)
 - #13462: Switch updatecart qty input validators to dynamic instead of hardcoding (by @gil--)


Fixed GitHub Issues:
 - #11252: Custom attribute - File not allowing uploads (reported by @stevenlavine) has been fixed in #13563 by @Mkennethsmith in 2.2-develop branch
   Related commits:
     1. 6cc8bdb
     2. 54254ad

 - #12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. (reported by @jhruehl) has been fixed in #13528 by @mattijv in 2.2-develop branch
   Related commits:
     1. 9c35c45

Author: magento-engcom-team

app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml

@@ -23,7 +23,7 @@
                            value=""
                            title="<?= /* @escapeNotVerified */ __('Qty') ?>"
                            class="input-text qty"
-                           data-validate="{'required-number':true,digits:true}"/>
+                           data-validate="<?= $block->escapeHtml(json_encode($block->getQuantityValidators())) ?>"/>
                 </div>
             </div>
             <?php endif; ?>

app/code/Magento/Customer/Model/FileUploader.php

@@ -110,7 +110,7 @@ public function upload()
         $result = $fileProcessor->saveTemporaryFile($this->scope . '[' . $this->getAttributeCode() . ']');
 
         // Update tmp_name param. Required for attribute validation!
-        $result['tmp_name'] = $result['path'] . '/' . ltrim($result['file'], '/');
+        $result['tmp_name'] = ltrim($result['file'], '/');
 
         $result['url'] = $fileProcessor->getViewUrl(
             FileProcessor::TMP_DIR . '/' . ltrim($result['name'], '/'),

app/code/Magento/Customer/Test/Unit/Model/FileUploaderTest.php

@@ -140,7 +140,7 @@ public function testUpload()
             'name' => $resultFileName,
             'file' => $resultFileName,
             'path' => $resultFilePath,
-            'tmp_name' => $resultFilePath . $resultFileName,
+            'tmp_name' => ltrim($resultFileName, '/'),
             'url' => $resultFileUrl,
         ];
 

app/code/Magento/Translation/etc/di.xml

@@ -67,6 +67,7 @@
                 <item name="translate_wrapping" xsi:type="string"><![CDATA[~translate\=("')([^\'].*?)\'\"~]]></item>
                 <item name="mage_translation_widget" xsi:type="string"><![CDATA[~(?:\$|jQuery)\.mage\.__\((?s)[^'"]*?(['"])(.+?)(?<!\\)\1(?s).*?\)~]]></item>
                 <item name="mage_translation_static" xsi:type="string"><![CDATA[~\$t\((?s)[^'"]*?(["'])(.+?)\1(?s).*?\)~]]></item>
+                <item name="translate_args" xsi:type="string"><![CDATA[~translate args\=("|'|"')([^\'].*?)('"|'|")~]]></item>
             </argument>
         </arguments>
     </type>