MAGETWO-55657: Implement new service OrderInvoice

 - add interfaces for exceptions and change their location

Author: NadiyaS

app/code/Magento/Sales/Api/Data/InvoiceCommentInterface.php

@@ -13,7 +13,7 @@
  * @api
  */
 interface InvoiceCommentInterface extends \Magento\Framework\Api\ExtensibleDataInterface,
-    \Magento\Sales\Api\Data\InvoiceCommentCreationInterface
+\Magento\Sales\Api\Data\InvoiceCommentCreationInterface
 {
     /**#@+
      * Constants for keys of data array. Identical to the name of the getter in snake case.

app/code/Magento/Sales/Api/DocumentValidationException.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Sales\Api\Exception;
+
+/**
+ * @api
+ */
+interface CouldNotInvoiceExceptionInterface
+{
+
+}

app/code/Magento/Sales/Api/Exception/CouldNotInvoiceExceptionInterface.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Sales\Api\Exception;
+
+/**
+ * @api
+ */
+interface DocumentValidationExceptionInterface
+{
+
+}

app/code/Magento/Sales/Api/Exception/DocumentValidationExceptionInterface.php

@@ -3,15 +3,15 @@
  * Copyright © 2016 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Sales\Api;
+namespace Magento\Sales\Exception;
 
 use Magento\Framework\Exception\LocalizedException;
+use Magento\Sales\Api\Exception\CouldNotInvoiceExceptionInterface;
 
 /**
  * Class CouldNotInvoiceException
- * @api
  */
-class CouldNotInvoiceException extends LocalizedException
+class CouldNotInvoiceException extends LocalizedException implements CouldNotInvoiceExceptionInterface
 {
 
 }

app/code/Magento/Sales/Api/CouldNotInvoiceException.php renamed to app/code/Magento/Sales/Exception/CouldNotInvoiceException.php

@@ -0,0 +1,17 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Sales\Exception;
+
+use Magento\Framework\Exception\LocalizedException;
+use Magento\Sales\Api\Exception\DocumentValidationExceptionInterface;
+
+/**
+ * Class DocumentValidationException
+ */
+class DocumentValidationException extends LocalizedException implements DocumentValidationExceptionInterface
+{
+
+}

app/code/Magento/Sales/Exception/DocumentValidationException.php

@@ -17,10 +17,7 @@
 use Magento\Sales\Model\Order\PaymentAdapterInterface;
 use Magento\Sales\Model\Order\OrderStateResolverInterface;
 use Magento\Sales\Model\Order\Config as OrderConfig;
-use Magento\Sales\Api\Data\InvoiceInterface;
 use Magento\Sales\Model\Order\InvoiceRepository;
-use Magento\Sales\Api\DocumentValidationException;
-use Magento\Sales\Api\CouldNotInvoiceException;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -126,8 +123,8 @@ public function __construct(
      * @param \Magento\Sales\Api\Data\InvoiceCommentCreationInterface|null $comment
      * @param \Magento\Sales\Api\Data\InvoiceCreationArgumentsInterface|null $arguments
      * @return int
-     * @throws DocumentValidationException
-     * @throws CouldNotInvoiceException
+     * @throws \Magento\Sales\Api\Exception\DocumentValidationExceptionInterface
+     * @throws \Magento\Sales\Api\Exception\CouldNotInvoiceExceptionInterface
      * @throws \Magento\Framework\Exception\InputException
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @throws \DomainException
@@ -152,7 +149,7 @@ public function execute(
         );
         $errorMessages = $this->invoiceValidator->validate($invoice, $order);
         if (!empty($errorMessages)) {
-            throw new DocumentValidationException(
+            throw new \Magento\Sales\Exception\DocumentValidationException(
                 __("Invoice Document Validation Error(s):\n" . implode("\n", $errorMessages))
             );
         }
@@ -170,7 +167,9 @@ public function execute(
         } catch (\Exception $e) {
             $this->logger->critical($e);
             $connection->rollBack();
-            throw new CouldNotInvoiceException(__('Could not save an invoice, see error log for details'));
+            throw new \Magento\Sales\Exception\CouldNotInvoiceException(
+                __('Could not save an invoice, see error log for details')
+            );
         }
         if ($notify) {
             if (!$appendComment) {