Skip to content

Commit e7d98ad

Browse files
committed
MC-4872: Convert CreateStoreGroupEntityTest to MFTF
Addressing review comments
1 parent 0d0122c commit e7d98ad

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateNewStoreGroupActionGroup.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
<fillField userInput="{{storeGroupName}}" selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" stepKey="fillSearchStoreGroupField"/>
5353
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearchButton"/>
5454
<waitForPageLoad stepKey="waitForStoreToLoad"/>
55-
<see selector="{{AdminStoresGridSection.firstRow('1')}}" userInput="{{storeGroupName}}" stepKey="seeAssertStoreGroupInGridMessage"/>
55+
<see selector="{{AdminStoresGridSection.nthRow('1')}}" userInput="{{storeGroupName}}" stepKey="seeAssertStoreGroupInGridMessage"/>
5656
</actionGroup>
5757
<actionGroup name="AssertStoreGroupForm">
5858
<arguments>
@@ -63,8 +63,6 @@
6363
</arguments>
6464
<click selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}" stepKey="clickEditExistingStoreRow"/>
6565
<waitForPageLoad stepKey="waitTillAdminSystemStoreGroupPage"/>
66-
<grabFromCurrentUrl regex="~(\d+)/~" stepKey="grabStoreGroupIdFromCurrentUrl"/>
67-
<seeInCurrentUrl url="system_store/editGroup/group_id/{$grabStoreGroupIdFromCurrentUrl}" stepKey="seeStoreGroupId"/>
6866
<seeInField selector="{{AdminNewStoreGroupSection.storeGrpWebsiteDropdown}}" userInput="{{website}}" stepKey="seeAssertWebsite"/>
6967
<seeInField selector="{{AdminNewStoreGroupSection.storeGrpNameTextField}}" userInput="{{storeGroupName}}" stepKey="seeAssertStoreGroupName"/>
7068
<seeInField selector="{{AdminNewStoreGroupSection.storeGrpCodeTextField}}" userInput="{{storeGroupCode}}" stepKey="seeAssertStoreGroupCode"/>

app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@
2020
<element name="websiteNameInFirstRow" type="text" selector=".col-website_title>a"/>
2121
<element name="storeGrpNameInFirstRow" type="text" selector=".col-group_title>a"/>
2222
<element name="storeNameInFirstRow" type="text" selector=".col-store_title>a"/>
23-
<element name="firstRow" type="textarea" selector="(//*[@id='storeGrid_table']/tbody/tr)[{{rownum}}]" parameterized="true"/>
23+
<element name="firstRow" type="textarea" selector="(//*[@id='storeGrid_table']/tbody/tr)[1]"/>
24+
<element name="nthRow" type="textarea" selector="(//*[@id='storeGrid_table']/tbody/tr)[{{rownum}}]" parameterized="true"/>
2425
<element name="successMessage" type="text" selector="//div[@class='message message-success success']/div"/>
2526
<element name="emptyText" type="text" selector="//tr[@class='data-grid-tr-no-data even']/td[@class='empty-text']"/>
2627
<element name="websiteName" type="text" selector="//td[@class='a-left col-website_title ']/a[contains(.,'{{websiteName}}')]" parameterized="true"/>
2728
</section>
28-
</sections>
29+
</sections>

0 commit comments

Comments
 (0)