Skip to content

Commit e756ebe

Browse files
committed
MAGETWO-51910: CSRF delete the cart items
1 parent b52f031 commit e756ebe

File tree

1 file changed

+17
-25
lines changed

1 file changed

+17
-25
lines changed

app/code/Magento/Checkout/Controller/Sidebar/RemoveItem.php

Lines changed: 17 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,26 @@
55
*/
66
namespace Magento\Checkout\Controller\Sidebar;
77

8-
use Magento\Checkout\Model\Sidebar;
9-
use Magento\Framework\App\Action\Action;
10-
use Magento\Framework\App\Action\Context;
11-
use Magento\Framework\App\Response\Http;
12-
use Magento\Framework\Exception\LocalizedException;
13-
use Magento\Framework\Json\Helper\Data;
14-
use Magento\Framework\View\Result\PageFactory;
15-
use Psr\Log\LoggerInterface;
168

17-
class RemoveItem extends Action
9+
class RemoveItem extends \Magento\Framework\App\Action\Action
1810
{
1911
/**
20-
* @var Sidebar
12+
* @var \Magento\Checkout\Model\Sidebar
2113
*/
2214
protected $sidebar;
2315

2416
/**
25-
* @var LoggerInterface
17+
* @var \Psr\Log\LoggerInterface
2618
*/
2719
protected $logger;
2820

2921
/**
30-
* @var Data
22+
* @var \Magento\Framework\Json\Helper\Data
3123
*/
3224
protected $jsonHelper;
3325

3426
/**
35-
* @var PageFactory
27+
* @var \Magento\Framework\View\Result\PageFactory
3628
*/
3729
protected $resultPageFactory;
3830

@@ -42,18 +34,18 @@ class RemoveItem extends Action
4234
private $formKeyValidator;
4335

4436
/**
45-
* @param Context $context
46-
* @param Sidebar $sidebar
47-
* @param LoggerInterface $logger
48-
* @param Data $jsonHelper
49-
* @param PageFactory $resultPageFactory
37+
* @param \Magento\Framework\App\Action\Context $context
38+
* @param \Magento\Checkout\Model\Sidebar $sidebar
39+
* @param \Psr\Log\LoggerInterface $logger
40+
* @param \Magento\Framework\Json\Helper\Data $jsonHelper
41+
* @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
5042
*/
5143
public function __construct(
52-
Context $context,
53-
Sidebar $sidebar,
54-
LoggerInterface $logger,
55-
Data $jsonHelper,
56-
PageFactory $resultPageFactory
44+
\Magento\Framework\App\Action\Context $context,
45+
\Magento\Checkout\Model\Sidebar $sidebar,
46+
\Psr\Log\LoggerInterface $logger,
47+
\Magento\Framework\Json\Helper\Data $jsonHelper,
48+
\Magento\Framework\View\Result\PageFactory $resultPageFactory
5749
) {
5850
$this->sidebar = $sidebar;
5951
$this->logger = $logger;
@@ -75,7 +67,7 @@ public function execute()
7567
$this->sidebar->checkQuoteItem($itemId);
7668
$this->sidebar->removeQuoteItem($itemId);
7769
return $this->jsonResponse();
78-
} catch (LocalizedException $e) {
70+
} catch (\Magento\Framework\Exception\LocalizedException $e) {
7971
return $this->jsonResponse($e->getMessage());
8072
} catch (\Exception $e) {
8173
$this->logger->critical($e);
@@ -87,7 +79,7 @@ public function execute()
8779
* Compile JSON response
8880
*
8981
* @param string $error
90-
* @return Http
82+
* @return \Magento\Framework\App\Response\Http
9183
*/
9284
protected function jsonResponse($error = '')
9385
{

0 commit comments

Comments
 (0)