ACP2E-99: "Search Synonyms" no longer works when value is added in "Minimum Terms to Match"

Author: thiaramus

app/code/Magento/Elasticsearch/Model/Adapter/Index/Builder.php

@@ -5,8 +5,10 @@
  */
 namespace Magento\Elasticsearch\Model\Adapter\Index;
 
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Locale\Resolver as LocaleResolver;
 use Magento\Elasticsearch\Model\Adapter\Index\Config\EsConfigInterface;
+use Magento\Search\Model\ResourceModel\SynonymReader;
 
 /**
  * Index Builder
@@ -30,16 +32,24 @@ class Builder implements BuilderInterface
      */
     protected $storeId;
 
+    /**
+     * @var SynonymReader
+     */
+    private $synonymReader;
+
     /**
      * @param LocaleResolver $localeResolver
      * @param EsConfigInterface $esConfig
+     * @param SynonymReader $synonymReader
      */
     public function __construct(
         LocaleResolver $localeResolver,
-        EsConfigInterface $esConfig
+        EsConfigInterface $esConfig,
+        SynonymReader $synonymReader
     ) {
         $this->localeResolver = $localeResolver;
         $this->esConfig = $esConfig;
+        $this->synonymReader = $synonymReader;
     }
 
     /**
@@ -50,6 +60,7 @@ public function build()
         $tokenizer = $this->getTokenizer();
         $filter = $this->getFilter();
         $charFilter = $this->getCharFilter();
+        $synonymFilter = $this->getSynonymFilter();
 
         $settings = [
             'analysis' => [
@@ -67,7 +78,10 @@ public function build()
                     'prefix_search' => [
                         'type' => 'custom',
                         'tokenizer' => key($tokenizer),
-                        'filter' => ['lowercase', 'asciifolding'],
+                        'filter' => array_merge(
+                            ['lowercase', 'asciifolding'],
+                            array_keys($synonymFilter)
+                        ),
                         'char_filter' => array_keys($charFilter)
                     ],
                     'sku' => [
@@ -82,11 +96,14 @@ public function build()
                     'sku_prefix_search' => [
                         'type' => 'custom',
                         'tokenizer' => 'keyword',
-                        'filter' => ['lowercase', 'asciifolding']
+                        'filter' => array_merge(
+                            ['lowercase', 'asciifolding'],
+                            array_keys($synonymFilter)
+                        ),
                     ]
                 ],
                 'tokenizer' => $tokenizer,
-                'filter' => $filter,
+                'filter' => array_merge($filter, $synonymFilter),
                 'char_filter' => $charFilter,
             ],
         ];
@@ -170,4 +187,28 @@ protected function getStemmerConfig()
             'language' => $stemmerInfo['default'],
         ];
     }
+
+    /**
+     * Get filter based on defined synonyms
+     *
+     * @throws LocalizedException
+     */
+    private function getSynonymFilter(): array {
+        $connection = $this->synonymReader->getConnection();
+        $select = $connection->select()->from($this->synonymReader->getMainTable(), 'synonyms');
+        $synonyms = $connection->fetchCol($select);
+
+        $synonymFilter = [];
+
+        if ($synonyms) {
+            $synonymFilter = [
+                'synonyms' => [
+                    'type' => 'synonym_graph',
+                    'synonyms' => $synonyms
+                ]
+            ];
+        }
+
+        return $synonymFilter;
+    }
 }

app/code/Magento/Elasticsearch/Model/Indexer/Fulltext/Plugin/Search/Model/SynonymReaderPlugin.php

@@ -0,0 +1,61 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\Elasticsearch\Model\Indexer\Fulltext\Plugin\Search\Model;
+
+use Magento\CatalogSearch\Model\Indexer\Fulltext;
+use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
+use Magento\Search\Model\ResourceModel\SynonymGroup;
+
+class SynonymReaderPlugin
+{
+    /**
+     * @var IndexerRegistry
+     */
+    private $indexerRegistry;
+
+    /**
+     * @param IndexerRegistry $indexerRegistry
+     */
+    public function __construct(IndexerRegistry $indexerRegistry) {
+        $this->indexerRegistry = $indexerRegistry;
+    }
+
+    /**
+     * @param SynonymGroup $subject
+     * @param AbstractDb $synonymGroup
+     * @return void
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function afterSave(SynonymGroup $subject, AbstractDb $synonymGroup) {
+        $this->invalidateIndexer();
+    }
+
+    /**
+     * @param SynonymGroup $subject
+     * @param AbstractDb $synonymGroup
+     * @return void
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function afterDelete(SynonymGroup $subject, AbstractDb $synonymGroup) {
+        $this->invalidateIndexer();
+    }
+
+    /**
+     * Invalidate fulltext indexer
+     *
+     * @return void
+     */
+    private function invalidateIndexer() {
+        $fulltextIndexer = $this->indexerRegistry->get(Fulltext::INDEXER_ID);
+        if (!$fulltextIndexer->isScheduled()) {
+            $fulltextIndexer->invalidate();
+        }
+    }
+}

app/code/Magento/Elasticsearch/etc/di.xml

@@ -515,7 +515,6 @@
         <arguments>
             <argument name="preprocessors" xsi:type="array">
                 <item name="stopwordsPreprocessor" xsi:type="object">Magento\Elasticsearch\SearchAdapter\Query\Preprocessor\Stopwords</item>
-                <item name="synonymsPreprocessor" xsi:type="object">Magento\Search\Adapter\Query\Preprocessor\Synonyms</item>
             </argument>
         </arguments>
     </type>
@@ -564,6 +563,9 @@
     <type name="Magento\Catalog\Model\ResourceModel\Attribute">
         <plugin name="updateElasticsearchIndexerMapping" type="Magento\Elasticsearch\Model\Indexer\Fulltext\Plugin\Category\Product\Attribute"/>
     </type>
+    <type name="Magento\Search\Model\ResourceModel\SynonymGroup">
+        <plugin name="synonymReaderPlugin" type="Magento\Elasticsearch\Model\Indexer\Fulltext\Plugin\Search\Model\SynonymReaderPlugin"/>
+    </type>
     <type name="Magento\Elasticsearch\Model\Indexer\IndexerHandler">
         <arguments>
             <argument name="cacheContext" xsi:type="object">Magento\Framework\Indexer\CacheContext\Proxy</argument>