MAGETWO-43908: Rename misspelled functions in Weee helper

 -- rename some Weee functions

Author: Robert He

app/code/Magento/Weee/Helper/Data.php

@@ -744,7 +744,7 @@ public function getTotalAmounts($items, $store = null)
      * @param  int|null $storeId
      * @return bool
      */
-    public function getDisplayIncl($storeId = null)
+    public function isDisplayIncl($storeId = null)
     {
         return $this->typeOfDisplay(
             WeeeDisplayConfig::DISPLAY_INCL,
@@ -759,7 +759,7 @@ public function getDisplayIncl($storeId = null)
      * @param  int|null $storeId
      * @return bool
      */
-    public function getDisplayInclDesc($storeId = null)
+    public function isDisplayInclDesc($storeId = null)
     {
         return $this->typeOfDisplay(
             WeeeDisplayConfig::DISPLAY_INCL_DESCR,
@@ -774,7 +774,7 @@ public function getDisplayInclDesc($storeId = null)
      * @param  int|null $storeId
      * @return bool
      */
-    public function getDisplayExlDescIncl($storeId = null)
+    public function isDisplayExlDescIncl($storeId = null)
     {
         return $this->typeOfDisplay(
             WeeeDisplayConfig::DISPLAY_EXCL_DESCR_INCL,
@@ -789,7 +789,7 @@ public function getDisplayExlDescIncl($storeId = null)
      * @param  int|null $storeId
      * @return bool
      */
-    public function getDisplayExcl($storeId = null)
+    public function isDisplayExcl($storeId = null)
     {
         return $this->typeOfDisplay(
             WeeeDisplayConfig::DISPLAY_EXCL,

app/code/Magento/Weee/Observer/GetPriceConfigurationObserver.php

@@ -142,8 +142,8 @@ private function insertWeeePrice($holder, $key, $weeeAttributes)
     protected function getWhichCalcPriceToUse($storeId = null)
     {
         $calcPrice = 'finalPrice';
-        if ($this->weeeData->getDisplayExcl($storeId) ||
-            $this->weeeData->getDisplayExlDescIncl($storeId) ||
+        if ($this->weeeData->isDisplayExcl($storeId) ||
+            $this->weeeData->isDisplayExlDescIncl($storeId) ||
             ($this->taxData->priceIncludesTax() && $this->taxData->displayPriceExcludingTax())
         ) {
             $calcPrice = 'basePrice';

app/code/Magento/Weee/Observer/UpdateProductOptionsObserver.php

@@ -60,8 +60,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
         }
 
         if ($this->weeeData->isEnabled() &&
-            !$this->weeeData->getDisplayIncl($product->getStoreId()) &&
-            !$this->weeeData->getDisplayExcl($product->getStoreId())
+            !$this->weeeData->isDisplayIncl($product->getStoreId()) &&
+            !$this->weeeData->isDisplayExcl($product->getStoreId())
         ) {
             // only do processing on bundle product
             if ($product->getTypeId() == \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE) {
@@ -87,7 +87,7 @@ public function execute(\Magento\Framework\Event\Observer $observer)
                     }
                 }
 
-                if ($this->weeeData->getDisplayExlDescIncl($product->getStoreId())) {
+                if ($this->weeeData->isDisplayExlDescIncl($product->getStoreId())) {
                     $options['optionTemplate'] .= sprintf(
                         ' <%% if (data.weeePrice) { %%>'
                         . '<%%- data.weeePrice.formatted %%>'
@@ -110,8 +110,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
     protected function getWhichCalcPriceToUse($storeId = null)
     {
         $calcPrice = 'finalPrice';
-        if ($this->weeeData->getDisplayExcl($storeId) ||
-            $this->weeeData->getDisplayExlDescIncl($storeId) ||
+        if ($this->weeeData->isDisplayExcl($storeId) ||
+            $this->weeeData->isDisplayExlDescIncl($storeId) ||
             ($this->taxData->priceIncludesTax() && $this->taxData->displayPriceExcludingTax())
         ) {
             $calcPrice = 'basePrice';

app/code/Magento/Weee/Test/Unit/Observer/UpdateProductOptionsObserverTest.php

@@ -47,7 +47,7 @@ public function testUpdateProductOptions($testArray, $weeeEnabled, $weeeDisplayE
             ->method('isEnabled')
             ->will($this->returnValue($weeeEnabled));
         $weeeHelper->expects($this->any())
-            ->method('getDisplayExlDescIncl')
+            ->method('isDisplayExlDescIncl')
             ->will($this->returnValue($weeeDisplayExclDescIncl));
         $weeeHelper->expects($this->any())
             ->method('getWeeeAttributesForBundle')