MTA-548: Re-factor Tests for Create Products

- Fixed logical and code style errors

Author: Oleksandr Manchenko

dev/tests/functional/lib/Magento/Mtf/Client/Element/SuggestElement.php

@@ -59,7 +59,7 @@ public function setValue($value)
 
         $this->clear();
 
-        if ($value == ''){
+        if ($value == '') {
             return;
         }
         foreach (str_split($value) as $symbol) {

dev/tests/functional/tests/app/Magento/Bundle/Test/Fixture/BundleProduct/BundleSelections.php

@@ -672,7 +672,7 @@ protected function getPreset($name)
                 'products' => [
                     [
                         'catalogProductSimple::simple',
-                        'catalogProductVirtual::for_bundle_fixed',
+                        'catalogProductVirtual::product_15_dollar',
                     ],
                 ],
             ],

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/ProductList/Related.php

@@ -19,7 +19,7 @@ class Related extends PromotedSection
      * Return product item block.
      *
      * @param FixtureInterface $product
-     * @return ProductItem
+     * @return RelatedProductItem
      */
     public function getProductItem(FixtureInterface $product)
     {

dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductSimple.xml

@@ -856,35 +856,6 @@
             </field>
         </dataset>
 
-        <dataset name="with_msrp">
-            <field name="attribute_set_id" xsi:type="array">
-                <item name="dataSet" xsi:type="string">default</item>
-            </field>
-            <field name="name" xsi:type="string">Simple Product with msrp %isolation%</field>
-            <field name="sku" xsi:type="string">sku_simple_product_with_msrp_%isolation%</field>
-            <field name="weight" xsi:type="string">1</field>
-            <field name="quantity_and_stock_status" xsi:type="array">
-                <item name="qty" xsi:type="string">25</item>
-                <item name="is_in_stock" xsi:type="string">In Stock</item>
-            </field>
-            <field name="price" xsi:type="array">
-                <item name="value" xsi:type="string">560</item>
-                <item name="preset" xsi:type="string">-</item>
-            </field>
-            <field name="tax_class_id" xsi:type="array">
-                <item name="dataSet" xsi:type="string">taxable_goods</item>
-            </field>
-            <field name="website_ids" xsi:type="array">
-                <item name="0" xsi:type="string">Main Website</item>
-            </field>
-            <field name="visibility" xsi:type="string">Catalog, Search</field>
-            <field name="checkout_data" xsi:type="array">
-                <item name="preset" xsi:type="string">order_default</item>
-            </field>
-            <field name="msrp" xsi:type="string">600</field>
-            <field name="msrp_display_actual_price_type" xsi:type="string">Before Order Confirmation</field>
-        </dataset>
-
         <dataset name="product_with_category_with_anchor">
             <field name="sku" xsi:type="string">simple_product_with_category_%isolation%</field>
             <field name="name" xsi:type="string">Simple product with category %isolation%</field>

dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductVirtual.xml

@@ -143,7 +143,7 @@
             </field>
         </dataset>
 
-        <dataset name="for_bundle_fixed">
+        <dataset name="product_15_dollar">
             <field name="tax_class_id" xsi:type="array">
                 <item name="dataSet" xsi:type="string">taxable_goods</item>
             </field>