Skip to content

Commit e69ff7b

Browse files
committed
Added strict_types and some cleanup
1 parent 7a70a47 commit e69ff7b

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

app/code/Magento/Fedex/Test/Unit/Plugin/Block/DataProviders/Tracking/ChangeTitleTest.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@
44
* See COPYING.txt for license details.
55
*/
66

7+
declare(strict_types=1);
8+
79
namespace Magento\Fedex\Test\Unit\Plugin\Block\DataProviders\Tracking;
810

11+
use Magento\Fedex\Model\Carrier;
912
use Magento\Fedex\Plugin\Block\DataProviders\Tracking\ChangeTitle;
1013
use Magento\Framework\Phrase;
1114
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
@@ -15,7 +18,7 @@
1518
use PHPUnit\Framework\TestCase;
1619

1720
/**
18-
* Unit Test for @see \Magento\Fedex\Plugin\Block\DataProviders\Tracking\ChangeTitle
21+
* Unit Test for @see ChangeTitle
1922
*/
2023
class ChangeTitleTest extends TestCase
2124
{
@@ -41,7 +44,7 @@ protected function setUp()
4144
* @param Phrase|string $finalResult
4245
* @dataProvider testAfterGetTitleDataProvider
4346
*/
44-
public function testAfterGetTitle($carrierCode, $originalResult, $finalResult)
47+
public function testAfterGetTitle(string $carrierCode, string $originalResult, $finalResult)
4548
{
4649
/** @var DeliveryDateTitle|MockObject $subjectMock */
4750
$subjectMock = $this->getMockBuilder(DeliveryDateTitle::class)
@@ -67,10 +70,10 @@ public function testAfterGetTitle($carrierCode, $originalResult, $finalResult)
6770
*
6871
* @return array
6972
*/
70-
public function testAfterGetTitleDataProvider()
73+
public function testAfterGetTitleDataProvider(): array
7174
{
7275
return [
73-
[\Magento\Fedex\Model\Carrier::CODE, 'Original Title', __('Expected Delivery:')],
76+
[Carrier::CODE, 'Original Title', __('Expected Delivery:')],
7477
['not-fedex', 'Original Title', 'Original Title'],
7578
];
7679
}

0 commit comments

Comments
 (0)