ENGCOM-2569: [Backport] FIXED: FTP user and password strings urldecoded #17247

magento-engcom-team · magento-engcom-team · commit e65d3e51bfc8 · 2018-07-28T15:01:16.000-05:00
- Merge Pull Request #17247 from mage2pratik/magento2:2.1-develop-PR-port-16876 - Merged commits: 1. f1120da 2. cd7fbb6
diff --git a/lib/internal/Magento/Framework/System/Ftp.php b/lib/internal/Magento/Framework/System/Ftp.php
@@ -107,6 +107,12 @@ public function validateConnectionString($string)
         if ($data['scheme'] != 'ftp') {
             throw new \Exception("Support for scheme unsupported: '{$data['scheme']}'");
         }
+        
+        // Decode user & password strings from URL
+        foreach (array_intersect(array_keys($data), ['user','pass']) as $key) {
+            $data[$key] = urldecode($data[$key]);
+        }
+        
         return $data;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,12 @@ public function validateConnectionString($string)`
`107`	`107`	`if ($data['scheme'] != 'ftp') {`
`108`	`108`	`throw new \Exception("Support for scheme unsupported: '{$data['scheme']}'");`
`109`	`109`	`}`
	`110`	`+`
	`111`	`+ // Decode user & password strings from URL`
	`112`	`+ foreach (array_intersect(array_keys($data), ['user','pass']) as $key) {`
	`113`	`+ $data[$key] = urldecode($data[$key]);`
	`114`	`+ }`
	`115`	`+`
`110`	`116`	`return $data;`
`111`	`117`	`}`
`112`	`118`