Skip to content

Commit e5a97f3

Browse files
ENGCOM-7773: [MFTF] use action group to click save button #28959
- Merge Pull Request #28959 from Usik2203/magento2:mftf-use-action-group-to-click-save-button - Merged commits: 1. f272d02 2. bc25960 3. ba82552 4. 6d30170
2 parents 878b1c9 + 6d30170 commit e5a97f3

File tree

33 files changed

+65
-70
lines changed

33 files changed

+65
-70
lines changed
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminProductFormSaveButtonClickActionGroup">
12+
<annotations>
13+
<description>Click Save button of product form.</description>
14+
</annotations>
15+
16+
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
17+
<waitForPageLoad stepKey="waitForProductSaved"/>
18+
</actionGroup>
19+
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCustomProductAttributeWithDropdownFieldTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@
9494
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
9595
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
9696
<waitForPageLoad stepKey="waitForAttributeToSave"/>
97-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
98-
<waitForPageLoad stepKey="waitForProductToSave"/>
97+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
9998
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
10099

101100
<!--Verify product attribute added in product form -->

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductAttributeFromProductPageTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@
8686
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
8787
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
8888
<waitForPageLoad stepKey="waitForAttributeToSave"/>
89-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
90-
<waitForPageLoad stepKey="waitForProductToSave"/>
89+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
9190
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
9291

9392
<!--Run Re-Index task -->

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductAttributeRequiredTextFieldTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@
7474
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
7575
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
7676
<waitForPageLoad stepKey="waitForAttributeToSave"/>
77-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
78-
<waitForPageLoad stepKey="waitForProductToSave"/>
77+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
7978

8079
<!--Verify product attribute added in product form and Is Required message displayed-->
8180
<scrollTo selector="{{AdminProductFormSection.contentTab}}" stepKey="scrollToContentTab"/>
@@ -85,8 +84,7 @@
8584
<!--Fill the Required field and save the product -->
8685
<fillField selector="{{AdminProductFormSection.attributeRequiredInput(newProductAttribute.attribute_code)}}" userInput="attribute" stepKey="fillTheAttributeRequiredInputField"/>
8786
<scrollToTopOfPage stepKey="scrollToTopOfProductFormPage"/>
88-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct1"/>
89-
<waitForPageLoad stepKey="waitForProductToSave1"/>
87+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct1"/>
9088
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
9189
</test>
9290
</tests>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateSimpleProductWithCountryOfManufactureAttributeSKUMaskTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@
4242
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.price}}" stepKey="fillSimpleProductPrice"/>
4343
<fillField selector="{{AdminProductFormSection.productWeight}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.weight}}" stepKey="fillSimpleProductWeight"/>
4444
<fillField selector="{{AdminProductFormSection.productQuantity}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.quantity}}" stepKey="fillSimpleProductQuantity"/>
45-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
46-
<waitForPageLoad stepKey="waitForSimpleProductToSave"/>
45+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
4746
<!-- Verify customer see success message -->
4847
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
4948

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductFillingRequiredFieldsOnlyTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@
3434
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName"/>
3535
<fillField selector="{{AdminProductFormSection.productSku}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillProductSku"/>
3636
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{virtualProductWithRequiredFields.price}}" stepKey="fillProductPrice"/>
37-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
38-
<waitForPageLoad stepKey="waitForVirtualProductSaved" />
37+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
3938

4039
<!-- Verify we see success message -->
4140
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductOutOfStockWithTierPriceTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
6262
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductOutOfStock.urlKey}}" stepKey="fillUrlKey"/>
6363
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
64-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
65-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
64+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
6665

6766
<!-- Verify we see success message -->
6867
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithCustomOptionsSuiteAndImportOptionsTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@
111111
<selectOption selector="{{AdminProductCustomizableOptionsSection.clickSelectPriceType(virtualProductCustomizableOption4.title,'1')}}" userInput="{{virtualProductCustomizableOption4.option_1_price_type}}" stepKey="selectOptionPriceTypeForFourthDataSetSecondRow"/>
112112
<fillField selector="{{AdminProductCustomizableOptionsSection.fillOptionValueSku(virtualProductCustomizableOption4.title,'1')}}" userInput="{{virtualProductCustomizableOption4.option_1_sku}}" stepKey="fillOptionSkuForFourthDataSetSecondRow"/>
113113
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
114-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
115-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
114+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
116115

117116
<!-- Verify we see success message -->
118117
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithTierPriceTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@
5353
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
5454
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductBigQty.urlKey}}" stepKey="fillUrlKey"/>
5555
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
56-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
57-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
56+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
5857

5958
<!-- Verify we see success message -->
6059
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithoutManageStockTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@
5151
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
5252
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductWithoutManageStock.urlKey}}" stepKey="fillUrlKey"/>
5353
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
54-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
55-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
54+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
5655

5756
<!-- Verify we see success message -->
5857
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

0 commit comments

Comments
 (0)