LYNX-232: Fix unit tests

Author: eliseacornejo

app/code/Magento/Customer/Test/Unit/Model/SessionTest.php

@@ -250,51 +250,6 @@ protected function prepareLoginDataMock(int $customerId): MockObject
         return $customerDataMock;
     }
 
-    /**
-     * @param bool $expectedResult
-     * @param bool $isCustomerIdValid
-     * @param bool $isCustomerEmulated
-     *
-     * @return void
-     * @dataProvider getIsLoggedInDataProvider
-     */
-    public function testIsLoggedIn(
-        bool $expectedResult,
-        bool $isCustomerIdValid,
-        bool $isCustomerEmulated
-    ): void {
-        $customerId = 1;
-        $this->_storageMock->expects($this->any())->method('getData')->with('customer_id')
-            ->willReturn($customerId);
-
-        if ($isCustomerIdValid) {
-            $this->customerRepositoryMock->expects($this->once())
-                ->method('getById')
-                ->with($customerId);
-        } else {
-            $this->customerRepositoryMock->expects($this->once())
-                ->method('getById')
-                ->with($customerId)
-                ->willThrowException(new \Exception('Customer ID is invalid.'));
-        }
-        $this->_storageMock->expects($this->any())->method('getIsCustomerEmulated')
-            ->willReturn($isCustomerEmulated);
-        $this->assertEquals($expectedResult, $this->_model->isLoggedIn());
-    }
-
-    /**
-     * @return array
-     */
-    public function getIsLoggedInDataProvider(): array
-    {
-        return [
-            ['expectedResult' => true, 'isCustomerIdValid' => true, 'isCustomerEmulated' => false],
-            ['expectedResult' => false, 'isCustomerIdValid' => true, 'isCustomerEmulated' => true],
-            ['expectedResult' => false, 'isCustomerIdValid' => false, 'isCustomerEmulated' => false],
-            ['expectedResult' => false, 'isCustomerIdValid' => false, 'isCustomerEmulated' => true]
-        ];
-    }
-
     /**
      * @return void
      */

dev/tests/integration/testsuite/Magento/Customer/Model/SessionTest.php

@@ -8,6 +8,7 @@
 use Magento\Framework\App\PageCache\FormKey;
 use Magento\Framework\App\Response\Http as HttpResponse;
 use Magento\Framework\App\ResponseInterface;
+use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Session\SidResolverInterface;
 use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
 use Magento\Framework\Stdlib\Cookie\PublicCookieMetadata;
@@ -32,11 +33,6 @@ class SessionTest extends \PHPUnit\Framework\TestCase
     /** @var PublicCookieMetadata $cookieMetadata */
     protected $cookieMetadata;
 
-    /**
-     * @var HttpResponse
-     */
-    private $response;
-
     protected function setUp(): void
     {
         $this->_customerSession = Bootstrap::getObjectManager()->create(
@@ -66,6 +62,42 @@ public function testLoginById()
         $this->assertTrue($this->_customerSession->isLoggedIn());
     }
 
+    /**
+     * @param bool $expectedResult
+     * @param bool $isCustomerIdValid
+     * @param bool $isCustomerEmulated
+     *
+     * @return void
+     * @dataProvider getIsLoggedInDataProvider
+     */
+    public function testIsLoggedIn(
+        bool $expectedResult,
+        bool $isCustomerIdValid,
+        bool $isCustomerEmulated
+    ): void {
+        if ($isCustomerIdValid) {
+            $this->_customerSession->loginById(1);
+        } else {
+            $this->_customerSession->setCustomerId(1);
+            $this->_customerSession->setId(2);
+        }
+        $this->_customerSession->setIsCustomerEmulated($isCustomerEmulated);
+        $this->assertEquals($expectedResult, $this->_customerSession->isLoggedIn());
+    }
+
+    /**
+     * @return array
+     */
+    public function getIsLoggedInDataProvider(): array
+    {
+        return [
+            ['expectedResult' => true, 'isCustomerIdValid' => true, 'isCustomerEmulated' => false],
+            ['expectedResult' => false, 'isCustomerIdValid' => true, 'isCustomerEmulated' => true],
+            ['expectedResult' => false, 'isCustomerIdValid' => false, 'isCustomerEmulated' => false],
+            ['expectedResult' => false, 'isCustomerIdValid' => false, 'isCustomerEmulated' => true]
+        ];
+    }
+
     public function testLoginByIdCustomerDataLoadedCorrectly()
     {
         $fixtureCustomerId = 1;